bernhard

Preview/Discussion: RockDataTables

Recommended Posts

can you post your $pages->findObjects() call please?

Sorry, missed that you already did that.

Quote

in the DBMS it take 0.3908 second(s) for 18119 pages.

You can try dumping the query that is created by my module and throw that to the dbms and analyse it.

As I wrote in the related thread I'm working on another implementation of RockSqlFinder as I came across some limitations yesterday

  • Like 1

Share this post


Link to post
Share on other sites

Okay,

Not sure how to debug the right query in the module, but

The findIDs() in buildQuery(), in the DBMS take 0.3087 second for 18119 pages.

The query ($query) in findObjects(), in the DBMS take 1.9846 seconds for 18119 pages.

 

And, why we have a difference of ~10 seconds when calling findObjects() or even findMany() from Tracy ?

 

Edit 1:  same average with 96611 pages.

Edit 2 :

I stumbled on this thread :

 

If you are interested, I have the code of two hooks which implement COUNT(), SUM() and DATEDIFF().

Share this post


Link to post
Share on other sites
1 hour ago, flydev said:

And, why we have a difference of ~10 seconds when calling findObjects() or even findMany() from Tracy ?

Sorry, no idea. Only situation where I know that it is slow is when it loads pages because of closures.

Do you have the current version? Is this check available in your module? https://gitlab.com/baumrock/RockSqlFinder/commit/17464b0397ed5f3d62bc86177d0c2395f33b5d9e

Quote

If you are interested, I have the code of two hooks which implement COUNT(), SUM() and DATEDIFF().

Thanks, no need at the moment :)

  • Like 1

Share this post


Link to post
Share on other sites

I finally found my mistake - it was an autoload module.

Also another mistake was the selector. I was using the has_parent keyword on a ~360k pages, growing each night. Selecting a direct parent reduced considerably the time of the aggregation.  It take ~18 seconds to do some calculation on 112 689 pages fetched, but it take 60 seconds to build and show two charts from theses 112k pages.

Still looking to improve it before scratching my head into MySQL stocked procedures.

 

Didn't checked the repo, do you have pushed an update regarding the implementation in RockSqlFinder yet ?

 

On 11/04/2018 at 2:23 PM, bernhard said:

Thanks, no need at the moment :)

okay

Share this post


Link to post
Share on other sites
8 minutes ago, flydev said:

I finally found my mistake - it was an autoload module.

Also another mistake was the selector. I was using the has_parent keyword on a ~360k pages, growing each night. Selecting a direct parent reduced considerably the time of the aggregation.  It take ~18 seconds to do some calculation on 112 689 pages fetched, but it take 60 seconds to build and show two charts from theses 112k pages.

Still looking to improve it before scratching my head into MySQL stocked procedures.

thanks for the headsup :) glad you found it!

 

8 minutes ago, flydev said:

Didn't checked the repo, do you have pushed an update regarding the implementation in RockSqlFinder yet ?

I'm right now working on a complete rewrite of the module. The syntax will change a little bit but be a lot more flexible. I'm working on a recursive version that should make it possible to easily query pages that are referenced by pagefields. This is a huge timesaver when working with mysql because this joins can really be a tedious task. This setup should also make it possible to do easy aggregations via custom SQL statements. That's why I think I will not need your aggregation functions for $pages api :)

Hmm... Thinking about it... Maybe this could be helpful in some situations. Maybe you want to share it in the dev board with all of us?

 

I hope I can push an update this week.

  • Like 2

Share this post


Link to post
Share on other sites
17 minutes ago, bernhard said:

Maybe you want to share it in the dev board with all of us?

I Will make a thread 👍

  • Like 1

Share this post


Link to post
Share on other sites

Hey @bernhard any updates on a release date or progress with RockDataTables?

RockFinder repo at gitlab even mentions, that you renamed it to RockGrid?!

I can't wait to get this module into my hands.

  • Like 2

Share this post


Link to post
Share on other sites

hey @jmartsch, not really. I'm fighting with it on several new projects ;) Some changes turn out to be not as simple as I thought (as always). I'll release a version when I finished my projects and did some more testing.

Yes, it will be renamed to "RockGrid" because I changed the grid library from datatables.net to ag-grid.com

Share this post


Link to post
Share on other sites

I'm making progress! Current state is really, really nice. See these two examples of a feedback software that I've built for a client:

demo1.thumb.png.c7035271b11f957146628e0863f9a1e5.png

  • full multi-language-support
  • all kinds of custom cell stylings (backgrounds, icons, etc)
  • custom filters
  • filter by doubleclick on a cell (really handy)
  • custom buttons-plugin (not part of aggrid):
    • reload data via ajax (very performant thanks to RockFinder)
    • reset filters
    • fullscreen mode (really handy for large grids)
    • excel export as CSV data
  • reload grid automatically when a pw-panel is closed

 

Another example: A list of all ratings for several categories

demo2.thumb.png.69b4d01f6c56d82cca97905f90259213.png

See the bottom line: this is another plugin that is not part of aggrid. You can just show the sum of the column (like the second column) or render custom statistics (like min, max, avg). When you select multiple lines you also get the statistics only for the selected rows :) This is also an example how you can use pinned rows with aggrid (really awesome library!).

 

Example of a range filter (aggrid standard feature):

demo3.png.d25f04bd6dd39f469a3a2232b876317f.png

  • Like 7

Share this post


Link to post
Share on other sites

Great work bernhard! I'm really interested in giving this a spin. Also the Enterprise features like pivots, filters, grouping are really great. Would it be possible to integrate these features by a third party without touching the module?

  • Like 1

Share this post


Link to post
Share on other sites

Sorry for the delay @arjen

On 5/10/2018 at 10:01 AM, arjen said:

Also the Enterprise features like pivots, filters, grouping are really great. Would it be possible to integrate these features by a third party without touching the module?

Don't think there should be any restrictions. My module should not break any functionality that comes with aggrid. Maybe some of my additional tools might need to be adopted to also support enterprise features, I don't know, but the module will be extendible via plugins so you can do whatever you want with it.

Another feature that I've implemented is called Batcher. This makes it easy to create batch processes sent via AJAX and execute custom actions on the server. An action can be as simple as that:

$this->ajax('trash', function($data) {
  foreach($data as $id) {
    $p = pages($id);
    if(!$p->trashable()) continue;
    $this->pages->trash($p);
  }
});

And the GUI:

var Batcher = RockGrid.batcher;
Batcher.items = grid.pluck('id', {selected:true});
Batcher.batchSize = 2;
Batcher.action = function(items) {
  // send ajax request to this grid
  var ajax = grid.ajax({
    action: 'trash',
    data: items,
  }).done(function(params) {
    Batcher.nextBatch();
  });
};
Batcher.confirmStart({
  msg: 'Are you sure you want to delete the selected rows?',
  onYes: function() {
    Batcher.nextBatch();
  },
  onNo: function() {
    $(grid.getWrapperDOM()).find('.rockgridbutton.trash i').removeClass('fa-spin fa-spinner').addClass('fa-trash');
    Batcher.abort();
  }
});
Batcher.onStart = function() {
  $(grid.getWrapperDOM()).find('.rockgridbutton.trash i').removeClass('fa-trash').addClass('fa-spin fa-spinner');
};
Batcher.onEnd = function() {
  $(grid.getWrapperDOM()).find('.rockgridbutton.refresh').click();
  $(grid.getWrapperDOM()).find('.rockgridbutton.trash i').removeClass('fa-spin fa-spinner').addClass('fa-trash');
  setTimeout(function() { Batcher.vex.close(); }, 500);
};

batcher.gif.af5333a0f1fbf2eb49131f0c3612bc60.gif

😎

Edit: The screencast does not really delete mails and it's a lot slower than real-life, because the ->trash() operation is replaced by a sleep(1) 😉

Share this post


Link to post
Share on other sites
15 hours ago, bernhard said:

Sorry for the delay @arjen

On 5/10/2018 at 10:01 AM, arjen said:

No problem, thanks for responding.

15 hours ago, bernhard said:

the module will be extendible via plugins so you can do whatever you want with it

Super sweet. You've created something really powerful.

15 hours ago, bernhard said:

Another feature that I've implemented is called Batcher.

Great feature!

On a particular project we use ListerPro a lot, but working with lots of data (10k+ pages with 30 fields represented in columns) in ListerPro is becoming more and more tedious. Response times are sometimes slowing down. Especially since there are sometimes hundreds of concurrent users. I am thinking to use your DataTables and Rockfinder since it feels a lot snappier than ListerPro.

Share this post


Link to post
Share on other sites
2 hours ago, arjen said:

On a particular project we use ListerPro a lot, but working with lots of data (10k+ pages with 30 fields represented in columns) in ListerPro is becoming more and more tedious. Response times are sometimes slowing down. Especially since there are sometimes hundreds of concurrent users. I am thinking to use your DataTables and Rockfinder since it feels a lot snappier than ListerPro.

Not sure about this on such large numbers. 10k pages per se should be easy. But with hundreds of users..?! Would need a test-run for sure. Maybe caching would be necessary or at least helpful. Are you interested in a closed beta test run? -> pm

  • Like 1

Share this post


Link to post
Share on other sites

Here is a really nice example of a simple plugin. You can develop custom plugins and just place them in /site/assets/RockGrid/plugins or we can share them in the community. Look at that lovely UI for the user and how quickly he can get the information he wants in a very attractive way:

Doubleclick = filter this row with the selected value
Tripleclick = reset filter for this row (but leave all other columns untouched)

filterdemo.thumb.gif.cf9aa8e7dc0a175f7003334b68eb1eaf.gif

document.addEventListener('RockGridItemLoadPlugins', function(e) {
  RockGrid.getGrid(e.target).registerPlugin(function() {
    this.name = 'doubleClickFilter';
  
    this.onLoad = function() {
      var grid = this.grid;
      
      var clicks = 0;
      var timer, timeout = 350; // time between each click

      var doubleClick = function(e) {
        var colId = e.column.colId;
        var filter = grid.api().getFilterInstance(colId);
        filter.setModel({
          type: 'equals',
          filter: e.value,
        });
        grid.api().onFilterChanged();
        grid.api().deselectAll();
      }

      var tripleClick = function(e) {
        var colId = e.column.colId;
        var filter = grid.api().getFilterInstance(colId);
        filter.setModel({});
        grid.api().onFilterChanged();
        grid.api().deselectAll();
      }

      // click timer
      grid.api().addEventListener('cellClicked', function(e) {
        clearTimeout(timer);
        clicks++;
        var evt = e;
        timer = setTimeout(function() {
          if(clicks==2) doubleClick(evt);
          if(clicks==3) tripleClick(evt);
          clicks = 0;
        }, timeout);
      });
    }
  });
});

Not that complicated, right? But huge result 🙂 

PS: Do you see the click on the reload button? Loading > 900 rows of data with RockFinder in a breeze 🙂 

  • Like 4

Share this post


Link to post
Share on other sites

It's getting better and better. Love it,

  • Like 1

Share this post


Link to post
Share on other sites

refreshtimer.gif.2f1034c05e15678224bc3642e1e66fea.gif

  grid.enablePlugin('refreshTimer');
  grid.pluginSettings('refreshTimer', {timeout: 2});

😎

  • Thanks 1

Share this post


Link to post
Share on other sites

When does the public beta come out and we can give it a try?? Waiting for it eager ly.

Gideon

  • Like 1

Share this post


Link to post
Share on other sites
8 hours ago, Gideon So said:

When does the public beta come out and we can give it a try?? Waiting for it eager ly.

Gideon

Should have something available within the next month, but can't guarantee that..

  • Like 3
  • Thanks 1

Share this post


Link to post
Share on other sites

Finally I was able to release RockGrid

I decided to release it as MIT, so everybody can contribute and maybe use it for other great additions to ProcessWire. I think it's a great way of listing data and I can think of several situations where it would make the admin UI a lot better than it is now with our existing tools. For example @adrian s batch child editor could maybe benefit from such a tool? I don't know. Let's see what happens...

The module is still alpha and not perfect... But it was also a lot of work and can't provide anything better than that at the moment. If anybody here can do it better: Please feel free to take over 🙂 

Thanks everybody for all the feedback here in this thread! Special thanks to @MrSnoozles for showing me agGrid and making me replace datatables  🙂 

 

 

  • Like 7
  • Thanks 2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By BitPoet
      MediaLibrary
      Update: MediaLibrary can now be found in the official module list.
      Out of necessity, I've started to implement a simple media library module.
      The basic mechanism is that it adds a MediaLibrary template with file and image fields. Pages of this type can be added anywhere in the page tree.
      The link and image pickers in CKEditor are extended to allow quick selection of library pages from dropdowns. In the link picker this happens in the MediaLibrary tab, where you can also see a preview of the selected image. In the image picker, simply select a library from the dropdown at the top, everything else is handled by standard functionality.
      I've put the code onto github. This module is compatible with ProcessWire 3.
      Steps to usage:
      Download the module's zip from github (switch to the pw3 branche beforehand if you want to test on PW 3.x) and unpack it into site/modules Click "Modules" -> "Refresh" in the admin Click "Install" for MediaLibrary For testing, create a page with the MediaLibrary template under home (give it an expressive title like 'Global Media') and add some images and files Edit a differnt page with a CKEditor field and add a link and an image to see the MediaLibrary features in action (see the screencap for details) Optionally, go into the module settings for MediaLibrary Note: this module is far from being as elaborate as Kongondo's Media Manager (and doesn't plan to be). If you need a feature-rich solution for integrated media management, give it a look.
      Feel free to change the settings for MediaFiles and MediaImages fields, just keep the type as multiple.
      There are some not-so-pretty hacks for creating and inserting the correct markup, which could probably be changed to use standard input fields, though I'm a bit at a loss right now how to get it to work. I've also still got to take a look at error handling before I can call it fit for production. All feedback and pointers are appreciated (that's also why I post this in the development section).

      Edit 09.03.2016 / version 0.0.4: there's now also a "Media" admin page with a shortcut to quickly add a new library.

      Edit 01.05.2016:
      Version 0.0.8:
      - The module now supports nested media libraries (all descendants of eligible media libraries are also selectable in link/image picker).
      - There's a MediaLibrary::getPageMediaLibraries method you can hook after to modify the array of available libraries.
      - You can switch between (default) select dropdowns or radio boxes in the module configuration of MediaLIbrary to choose libraries.
      Edit 10.10.2018:
      Version 0.1.3:
      - Dropped compatibility for ProcessWire legacy versions by adding namespaces
      - Allow deletion of libraries from the Media overview admin page
      - Added an option to hide media libraries from the page tree (optionally also for superusers)
    • By Robin S
      This module corrects a few things that I find awkward about the "Add New Template" workflow in the PW admin. I opened a wishlist topic a while back because it would good to resolve some of these things in the core, but this module is a stopgap for now.
      Originally I was going to share these as a few standalone hooks, but decided to bundle them together in a configurable module instead.
      Add Template Enhancements
      A module for ProcessWire CMS/CMF. Adds some efficiency enhancements when adding or cloning templates via admin.

      Features
      Derive label from name when new template added: if you like to give each of your templates a label then this feature can save some time. The label can be added automatically when templates are added in admin, in admin/API, or not at all. There are options for underscore/hyphen replacement and capitalisation of the label. Edit template after add: when adding only a single template, the template is automatically opened for editing after it is added. Copy field contexts when cloning: this copies the field contexts (a.k.a. overrides such as column width, label and description) from the source template to the new template when using the "Duplicate/clone this template?" feature on the Advanced tab. Copy field contexts when duplicating fields: this copies the field contexts if you select the "Duplicate fields used by another template" option when adding a new template. Usage
      Install the Add Template Enhancements module.
      Configure the module settings according to what suits you.
       
      https://github.com/Toutouwai/AddTemplateEnhancements
      https://modules.processwire.com/modules/add-template-enhancements/
    • By Mike Rockett
      As I mentioned in this issue, I've create a new textformatter for ParsedownExtraPlugin, which adds some oomph to your markdown.
      Repo: Parsedown Extra Plugin
      Unlike the built-in textformatter for Parsedown and Parsedown Extra, this should be used when you want to use Extra with additional configuration/customisation.
      Some examples:
      ### Test {.heading} - A [external link](https://google.com/){.google} with `google` as a class that opens in a new tab if the config property is set. - [Another link](/page){target=_blank} that opens in a new tab even though it isn't external. ```html .html <p>Test</p> ``` There's some config options available to you, such as setting attributes on all/external images and links, setting table and table-cell alignment classes, adjusting footnote classes and IDs, adding <code> attributes to their parent <pre> elements, and changing the <code> class if your syntax highlighter does not use language-*.
      I was thinking about adding the ability to make links open in a new tab by appending a plus to the link syntax, but only external links should be opening in a new tab anyway. Further, this would add extra, unnecessary processing time.
      Please let me know if you bump into any problems. ☺️
    • By Mike Rockett
      TextformatterTypographer (0.4.0 Beta)
      A ProcessWire wrapper for the awesome PHP Typography class, originally authored by KINGdesk LLC and enhanced by Peter Putzer in wp-Typography. Like Smartypants, it supercharges text fields with enhanced typography and typesetting, such as smart quotations, hyphenation in 59 languages, ellipses, copyright-, trade-, and service-marks, math symbols, and more.
      Learn more on my blog
      It's based on the PHP-Typography library found over at wp-Typography, which is more frequently updated and feature rich that its original by KINGdesk LLC.
      The module itself is fully configurable. I haven't done extensive testing, but there is nothing complex about this, and so I only envisage a typographical bug here and there, if any.
      Please do test it out and let me know what you think.
      Also note that I have indicated support for PW 2.8, but I haven't tested there as yet. This was built on PW 3.0.42/62.
    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.50
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy!