bernhard

Preview/Discussion: RockDataTables

Recommended Posts

can you post your $pages->findObjects() call please?

Sorry, missed that you already did that.

Quote

in the DBMS it take 0.3908 second(s) for 18119 pages.

You can try dumping the query that is created by my module and throw that to the dbms and analyse it.

As I wrote in the related thread I'm working on another implementation of RockSqlFinder as I came across some limitations yesterday

  • Like 1

Share this post


Link to post
Share on other sites

Okay,

Not sure how to debug the right query in the module, but

The findIDs() in buildQuery(), in the DBMS take 0.3087 second for 18119 pages.

The query ($query) in findObjects(), in the DBMS take 1.9846 seconds for 18119 pages.

 

And, why we have a difference of ~10 seconds when calling findObjects() or even findMany() from Tracy ?

 

Edit 1:  same average with 96611 pages.

Edit 2 :

I stumbled on this thread :

 

If you are interested, I have the code of two hooks which implement COUNT(), SUM() and DATEDIFF().

Share this post


Link to post
Share on other sites
1 hour ago, flydev said:

And, why we have a difference of ~10 seconds when calling findObjects() or even findMany() from Tracy ?

Sorry, no idea. Only situation where I know that it is slow is when it loads pages because of closures.

Do you have the current version? Is this check available in your module? https://gitlab.com/baumrock/RockSqlFinder/commit/17464b0397ed5f3d62bc86177d0c2395f33b5d9e

Quote

If you are interested, I have the code of two hooks which implement COUNT(), SUM() and DATEDIFF().

Thanks, no need at the moment :)

  • Like 1

Share this post


Link to post
Share on other sites

I finally found my mistake - it was an autoload module.

Also another mistake was the selector. I was using the has_parent keyword on a ~360k pages, growing each night. Selecting a direct parent reduced considerably the time of the aggregation.  It take ~18 seconds to do some calculation on 112 689 pages fetched, but it take 60 seconds to build and show two charts from theses 112k pages.

Still looking to improve it before scratching my head into MySQL stocked procedures.

 

Didn't checked the repo, do you have pushed an update regarding the implementation in RockSqlFinder yet ?

 

On 11/04/2018 at 2:23 PM, bernhard said:

Thanks, no need at the moment :)

okay

Share this post


Link to post
Share on other sites
8 minutes ago, flydev said:

I finally found my mistake - it was an autoload module.

Also another mistake was the selector. I was using the has_parent keyword on a ~360k pages, growing each night. Selecting a direct parent reduced considerably the time of the aggregation.  It take ~18 seconds to do some calculation on 112 689 pages fetched, but it take 60 seconds to build and show two charts from theses 112k pages.

Still looking to improve it before scratching my head into MySQL stocked procedures.

thanks for the headsup :) glad you found it!

 

8 minutes ago, flydev said:

Didn't checked the repo, do you have pushed an update regarding the implementation in RockSqlFinder yet ?

I'm right now working on a complete rewrite of the module. The syntax will change a little bit but be a lot more flexible. I'm working on a recursive version that should make it possible to easily query pages that are referenced by pagefields. This is a huge timesaver when working with mysql because this joins can really be a tedious task. This setup should also make it possible to do easy aggregations via custom SQL statements. That's why I think I will not need your aggregation functions for $pages api :)

Hmm... Thinking about it... Maybe this could be helpful in some situations. Maybe you want to share it in the dev board with all of us?

 

I hope I can push an update this week.

  • Like 2

Share this post


Link to post
Share on other sites
17 minutes ago, bernhard said:

Maybe you want to share it in the dev board with all of us?

I Will make a thread 👍

  • Like 1

Share this post


Link to post
Share on other sites

Hey @bernhard any updates on a release date or progress with RockDataTables?

RockFinder repo at gitlab even mentions, that you renamed it to RockGrid?!

I can't wait to get this module into my hands.

  • Like 2

Share this post


Link to post
Share on other sites

hey @jmartsch, not really. I'm fighting with it on several new projects ;) Some changes turn out to be not as simple as I thought (as always). I'll release a version when I finished my projects and did some more testing.

Yes, it will be renamed to "RockGrid" because I changed the grid library from datatables.net to ag-grid.com

Share this post


Link to post
Share on other sites

I'm making progress! Current state is really, really nice. See these two examples of a feedback software that I've built for a client:

demo1.thumb.png.c7035271b11f957146628e0863f9a1e5.png

  • full multi-language-support
  • all kinds of custom cell stylings (backgrounds, icons, etc)
  • custom filters
  • filter by doubleclick on a cell (really handy)
  • custom buttons-plugin (not part of aggrid):
    • reload data via ajax (very performant thanks to RockFinder)
    • reset filters
    • fullscreen mode (really handy for large grids)
    • excel export as CSV data
  • reload grid automatically when a pw-panel is closed

 

Another example: A list of all ratings for several categories

demo2.thumb.png.69b4d01f6c56d82cca97905f90259213.png

See the bottom line: this is another plugin that is not part of aggrid. You can just show the sum of the column (like the second column) or render custom statistics (like min, max, avg). When you select multiple lines you also get the statistics only for the selected rows :) This is also an example how you can use pinned rows with aggrid (really awesome library!).

 

Example of a range filter (aggrid standard feature):

demo3.png.d25f04bd6dd39f469a3a2232b876317f.png

  • Like 7

Share this post


Link to post
Share on other sites

Great work bernhard! I'm really interested in giving this a spin. Also the Enterprise features like pivots, filters, grouping are really great. Would it be possible to integrate these features by a third party without touching the module?

  • Like 1

Share this post


Link to post
Share on other sites

Sorry for the delay @arjen

On 5/10/2018 at 10:01 AM, arjen said:

Also the Enterprise features like pivots, filters, grouping are really great. Would it be possible to integrate these features by a third party without touching the module?

Don't think there should be any restrictions. My module should not break any functionality that comes with aggrid. Maybe some of my additional tools might need to be adopted to also support enterprise features, I don't know, but the module will be extendible via plugins so you can do whatever you want with it.

Another feature that I've implemented is called Batcher. This makes it easy to create batch processes sent via AJAX and execute custom actions on the server. An action can be as simple as that:

$this->ajax('trash', function($data) {
  foreach($data as $id) {
    $p = pages($id);
    if(!$p->trashable()) continue;
    $this->pages->trash($p);
  }
});

And the GUI:

var Batcher = RockGrid.batcher;
Batcher.items = grid.pluck('id', {selected:true});
Batcher.batchSize = 2;
Batcher.action = function(items) {
  // send ajax request to this grid
  var ajax = grid.ajax({
    action: 'trash',
    data: items,
  }).done(function(params) {
    Batcher.nextBatch();
  });
};
Batcher.confirmStart({
  msg: 'Are you sure you want to delete the selected rows?',
  onYes: function() {
    Batcher.nextBatch();
  },
  onNo: function() {
    $(grid.getWrapperDOM()).find('.rockgridbutton.trash i').removeClass('fa-spin fa-spinner').addClass('fa-trash');
    Batcher.abort();
  }
});
Batcher.onStart = function() {
  $(grid.getWrapperDOM()).find('.rockgridbutton.trash i').removeClass('fa-trash').addClass('fa-spin fa-spinner');
};
Batcher.onEnd = function() {
  $(grid.getWrapperDOM()).find('.rockgridbutton.refresh').click();
  $(grid.getWrapperDOM()).find('.rockgridbutton.trash i').removeClass('fa-spin fa-spinner').addClass('fa-trash');
  setTimeout(function() { Batcher.vex.close(); }, 500);
};

batcher.gif.af5333a0f1fbf2eb49131f0c3612bc60.gif

😎

Edit: The screencast does not really delete mails and it's a lot slower than real-life, because the ->trash() operation is replaced by a sleep(1) 😉

Share this post


Link to post
Share on other sites
15 hours ago, bernhard said:

Sorry for the delay @arjen

On 5/10/2018 at 10:01 AM, arjen said:

No problem, thanks for responding.

15 hours ago, bernhard said:

the module will be extendible via plugins so you can do whatever you want with it

Super sweet. You've created something really powerful.

15 hours ago, bernhard said:

Another feature that I've implemented is called Batcher.

Great feature!

On a particular project we use ListerPro a lot, but working with lots of data (10k+ pages with 30 fields represented in columns) in ListerPro is becoming more and more tedious. Response times are sometimes slowing down. Especially since there are sometimes hundreds of concurrent users. I am thinking to use your DataTables and Rockfinder since it feels a lot snappier than ListerPro.

Share this post


Link to post
Share on other sites
2 hours ago, arjen said:

On a particular project we use ListerPro a lot, but working with lots of data (10k+ pages with 30 fields represented in columns) in ListerPro is becoming more and more tedious. Response times are sometimes slowing down. Especially since there are sometimes hundreds of concurrent users. I am thinking to use your DataTables and Rockfinder since it feels a lot snappier than ListerPro.

Not sure about this on such large numbers. 10k pages per se should be easy. But with hundreds of users..?! Would need a test-run for sure. Maybe caching would be necessary or at least helpful. Are you interested in a closed beta test run? -> pm

  • Like 1

Share this post


Link to post
Share on other sites

Here is a really nice example of a simple plugin. You can develop custom plugins and just place them in /site/assets/RockGrid/plugins or we can share them in the community. Look at that lovely UI for the user and how quickly he can get the information he wants in a very attractive way:

Doubleclick = filter this row with the selected value
Tripleclick = reset filter for this row (but leave all other columns untouched)

filterdemo.thumb.gif.cf9aa8e7dc0a175f7003334b68eb1eaf.gif

document.addEventListener('RockGridItemLoadPlugins', function(e) {
  RockGrid.getGrid(e.target).registerPlugin(function() {
    this.name = 'doubleClickFilter';
  
    this.onLoad = function() {
      var grid = this.grid;
      
      var clicks = 0;
      var timer, timeout = 350; // time between each click

      var doubleClick = function(e) {
        var colId = e.column.colId;
        var filter = grid.api().getFilterInstance(colId);
        filter.setModel({
          type: 'equals',
          filter: e.value,
        });
        grid.api().onFilterChanged();
        grid.api().deselectAll();
      }

      var tripleClick = function(e) {
        var colId = e.column.colId;
        var filter = grid.api().getFilterInstance(colId);
        filter.setModel({});
        grid.api().onFilterChanged();
        grid.api().deselectAll();
      }

      // click timer
      grid.api().addEventListener('cellClicked', function(e) {
        clearTimeout(timer);
        clicks++;
        var evt = e;
        timer = setTimeout(function() {
          if(clicks==2) doubleClick(evt);
          if(clicks==3) tripleClick(evt);
          clicks = 0;
        }, timeout);
      });
    }
  });
});

Not that complicated, right? But huge result 🙂 

PS: Do you see the click on the reload button? Loading > 900 rows of data with RockFinder in a breeze 🙂 

  • Like 4

Share this post


Link to post
Share on other sites

It's getting better and better. Love it,

  • Like 1

Share this post


Link to post
Share on other sites

refreshtimer.gif.2f1034c05e15678224bc3642e1e66fea.gif

  grid.enablePlugin('refreshTimer');
  grid.pluginSettings('refreshTimer', {timeout: 2});

😎

  • Thanks 1

Share this post


Link to post
Share on other sites

When does the public beta come out and we can give it a try?? Waiting for it eager ly.

Gideon

  • Like 1

Share this post


Link to post
Share on other sites
8 hours ago, Gideon So said:

When does the public beta come out and we can give it a try?? Waiting for it eager ly.

Gideon

Should have something available within the next month, but can't guarantee that..

  • Like 3
  • Thanks 1

Share this post


Link to post
Share on other sites

Finally I was able to release RockGrid

I decided to release it as MIT, so everybody can contribute and maybe use it for other great additions to ProcessWire. I think it's a great way of listing data and I can think of several situations where it would make the admin UI a lot better than it is now with our existing tools. For example @adrian s batch child editor could maybe benefit from such a tool? I don't know. Let's see what happens...

The module is still alpha and not perfect... But it was also a lot of work and can't provide anything better than that at the moment. If anybody here can do it better: Please feel free to take over 🙂 

Thanks everybody for all the feedback here in this thread! Special thanks to @MrSnoozles for showing me agGrid and making me replace datatables  🙂 

 

 

  • Like 7
  • Thanks 2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Macrura
      Field Descriptions Extended
      This module enables you to extend field descriptions by dividing short descriptions with a longer text that is revealed in a toggle.
      Modules Directory: http://modules.processwire.com/modules/field-descriptions-extended/
      Github: https://github.com/outflux3/FieldDescriptionsExtended
      Extending your field descriptions using the standard field's description field.
      Once this module is installed, it will automatically search your description field for the presence of 5 dashes (-----).
      Any content above the 5 dashes will be visible and the content below the dashes will be hidden. A 'More...' link will appear at the end of the short description which when clicked will reveal the rest of the description.
      Using Simple Markdown Editor with the description field
      If you have Simple Markdown Editor (InputfieldSimpleMDE) installed, you can enable the field description to have that editor.
      *When using Simple MDE, you can use the button (Insert Horizontal Line) instead of typing 5 dashes. More about SimpleMDE.
      Extending your field descriptions using content from a ProcessWire Page for the field description.
      You may use the content from a ProcessWire page as a field description. This would allow you to easily insert images, links, and use hanna codes.
      To use page content for your field descriptions, please follow these instructions:
      Install Select Fields module (FieldtypeFields) http://modules.processwire.com/modules/fieldtype-fields/ Create a new field using this field type, e.g. field_select. Add the field to any template you will be using for your field descriptions. Setup your help pages (for example under a settings branch) where you will store the field description content,using the template containing the Field Select. Add content to a page and select the field where that content should show. To show a short text before the link to the longer content, separate them with 5 dashes Be sure to update your settings on this page, first enable page content descriptions,then specify the name of the Select Fields field, template to search, and content field. If you create a field description using this method, please note that the description field must be blank for contexts where you want the page content to appear.
      You can freely use template context for field descriptions, but the Page Content method is not context sensitive and will display under all contexts where the description is blank.
      ----
      original post:
      This is a new module, hope to release soon, which allows extended field descriptions, in currently 2 ways.
      The main feature of the module is that you can have a short description and then a 'more...' link which drops down a longer block of text.
      This is achieved by separating the intro/visible text and the rest with 5 dashes.

      Example setup:

      the 2nd way is if you are using AdminThemeUiKit, you can show extended field instructions in a panel. The content of the panel is edited on a regular PW page. This use case would probably not be that common, but if you had a field that required some extended instructions for how to use, this could be useful; Also, since this allows you to target information and instructions down at the field level, it could reduce the amount of documentation needed on a global level, since it is a lot more context targeted.

    • By Robin S
      Breadcrumb Dropdowns
      Adds dropdown menus of page edit links to the breadcrumbs in Page Edit.

      Installation
      Install the Breadcrumb Dropdowns module. The module requires ProcessWire >= v3.0.83 and AdminThemeUikit.
      There is a checkbox option in the module config that determines if the breadcrumb dropdowns will include pages that the user does not have permission to edit.
      Features/details
      The module adds an additional breadcrumb item at the end for the currently edited page. That's because I think it's more intuitive for the dropdown under each breadcrumb item to show the item's sibling pages rather than the item's child pages. In the dropdown menus the current page and the current page's parents are highlighted in a crimson colour to make it easier to quickly locate them in case you want to edit the next or previous sibling page. If the option to include uneditable pages is selected then those pages are indicated by a reduced text opacity and the "not-allowed" cursor is shown on hover. There is a limit of 25 sibling pages per dropdown for performance reasons and to avoid the dropdown becoming unwieldy. Incompatibilities
      This module replaces the AdminThemeUikit::renderBreadcrumbs method so will potentially be incompatible with other modules that hook the same method.
       
      https://modules.processwire.com/modules/breadcrumb-dropdowns/
      https://github.com/Toutouwai/BreadcrumbDropdowns
    • By joshuag
      Hey guys, 
      Thought I would share a quick preview of Designme. A module we (Eduardo @elabx and I) are building for visually laying out your templates/edit screens. 🙂
      This is a really quick, zero polish screen grab. FYI. 
      Video #2 - UPDATE
      This new video shows the following features in Designme:
      Re-arranging fields via Drag & Drop Re-sizing fields via Dragging. Adjusting field settings - with live refresh. Working on "hidden" fields while Designme is active. Creating New fields. Deleting fields. Creating/Deleting Tabs. Dragging fields between tabs. Creating fieldsets. Tagging/Un-tagging fields. Fields without headers expand when hovered (like checkboxes). Live filtering of fields in the sidebar. Ability to adjust (all) Template settings without leaving Designme. Template File Tree Editing Template files source code with ACE Editor. Editing Multiple files with ACE Editor. (New Tabs) Saving files. Techie stuff Fields load their own js/css dependancies. *ready to use on creation (*most fields)  Everything happens via Ajax to ProcessPageEdit (via module + hooks). Designme has a JS api that you can use.  All actions trigger events.  We would love any detailed feedback on what you see so far. If you are interested in testing Designme. Let me know below. 🙂
       
       
      Video #1. 
       
    • By dreerr
      TemplateEnginePug (formally TemplateEngineJade)
       
      This module adds Pug templates to the TemplateEngineFactory. It uses https://github.com/pug-php/pug to render templates.
      doctype html html(lang='en') head meta(http-equiv='content-type', content='text/html; charset=utf-8') title= $page->title link(rel='stylesheet', type='text/css', href=$config->urls->templates . 'styles/main.css') body include header.pug h1= $page->title if $page->editable() p: a(href=$page->editURL) Edit Project on GitHub: github.com/dreerr/TemplateEnginePug
      Project in modules directory: modules.processwire.com/modules/template-engine-pug/
       
      For common problems/features/questions about the Factory, use the TemplateEngineFactory thread.
       
    • By tpr
      ProcessNetteTester
      Run Nette Tester tests within ProcessWire admin.
      (continued from here)

      Features
      AJAX interface for running Nette Tester tests, in bulk or manually display counter, error message and execution time in a table run all tests at once or launch single tests show formatted test error messages and report PHP syntax errors stop on first failed test (optional) hide passed tests (optional) display failed/total instead passed/total (optional) re-run failed tests only (optional) auto scroll (optional) include or exclude tests based on query parameters start/stop all tests with the spacebar reset one test or all tests (ctrl+click) https://modules.processwire.com/modules/process-nette-tester/
      https://github.com/rolandtoth/ProcessNetteTester