Jump to content
ryan

Module: Video embed for YouTube/Vimeo (TextformatterVideoEmbed)

Recommended Posts

Just now, artaylor said:

@PWaddict: Yes it is a textarea with an Inputfield Type of CKEditor

Is the Content Type: Markup/HTML? If you have that too then I'm not sure why it's not properly working for you. Maybe another installed module causing this issue. 

Share this post


Link to post
Share on other sites

Attached a screengrab of the field setup screen.

Not sure if it matters, but when I tried to do the standard install of the module via Module Class Name, I got some weird errors from PW site, so, I installed it manually.

It is listed in the modules list and I can access the settings so I am assuming the manual install went ok. I think I will uninstall then reinstall the module and see if that helps.

screenshot-2017-03-27-20-52-38.png

Share this post


Link to post
Share on other sites

Uninstalled the module then tried to reinstall using the Module Class Name but got the following error:

I will do a manual install again.

screenshot-moduleload-error-2017-03-27-21-07-14.png

Share this post


Link to post
Share on other sites

5 years late but just want to say thanks for this module! I would prefer to use just the CKEditor media button but I had issues installing that.

Share this post


Link to post
Share on other sites

seems to have stopped working on a fresh module install on a new site, not had an issue before now with hthis great module. PW v3.0.36, no errors in my logs, just link showing up no video

Share this post


Link to post
Share on other sites
On 2017-5-22 at 10:31 AM, benbyf said:

seems to have stopped working on a fresh module install on a new site, not had an issue before now with hthis great module. PW v3.0.36, no errors in my logs, just link showing up no video

Remove the link and it should kick in again. Needs to just be plain text. 

  • Like 1

Share this post


Link to post
Share on other sites

... not sure thats a fix. do you mean dont use the CKEditor or within a CKeditor field delete the link and paste in again, as i tried that and did not work :(

Share this post


Link to post
Share on other sites

Yes delete the link from the ckeditor field. If it is an <a href to the YouTube video it will not embed. 

Share this post


Link to post
Share on other sites

Dummy question here:

If I wanted the plugin to add a specific player parameter to all youtube shortlinks (e.g. enablejsapi=1) where would be the best place to add this?
I changed line 170 to:

"&format=json&maxwidth={$this->maxWidth}&maxheight={$this->maxHeight}&enablejsapi=1&html5=1";

but since the oembed?url gets rewritten by youtube I'm not sure this is working. Any pointers?

Cheers guys!

Share this post


Link to post
Share on other sites
30 minutes ago, phil_s said:

Dummy question here:

If I wanted the plugin to add a specific player parameter to all youtube shortlinks (e.g. enablejsapi=1) where would be the best place to add this?
I changed line 170 to:


"&format=json&maxwidth={$this->maxWidth}&maxheight={$this->maxHeight}&enablejsapi=1&html5=1";

but since the oembed?url gets rewritten by youtube I'm not sure this is working. Any pointers?

Cheers guys!

Use the Global Options for Embedded YouTube/Vimeo Videos module to add player parameters.

Share this post


Link to post
Share on other sites

What's the current method for getting this to work with CKEditor?
I can't turn off HTML Purifier, or ACF.

 

Share this post


Link to post
Share on other sites
1 hour ago, renobird said:

What's the current method for getting this to work with CKEditor?
I can't turn off HTML Purifier, or ACF.

This module is a textformatter, so it doesn't write anything to the CKEditor field. As long as you can insert a link URL into your field as text without interference from HTML Purifier then there shouldn't be any problem.

Share this post


Link to post
Share on other sites

Thanks Robin,

It works fine with a textarea that isn't using CKEditor, and since it appears that the <iframe> tags are being stripped out; I figured it was a CKEditor issue.
 

Share this post


Link to post
Share on other sites
2 minutes ago, renobird said:

since it appears that the <iframe> tags

There shouldn't be any iframe tags involved - you simply insert the URL to the video (not an embed snippet or anything like that) in a new paragraph in your CKEditor field.

Share this post


Link to post
Share on other sites

The textformatter adds the iframe, that's how the embed works. At least it used to, I'll check the code again.

Share this post


Link to post
Share on other sites

I might be wrong, but my understanding is that the ACF/Purifier settings for a CKEditor field only affect content that goes through the CKEditor inputfield and is then saved to the database.

A textformatter on the other hand never saves its changes to the database and it isn't involved with the inputfield - it just makes changes on-the-fly as the content is output to the front-end.

Another thought: if you have multiple textformatters applied, check to see if the order they are applied makes a difference.

  • Like 2

Share this post


Link to post
Share on other sites

Yeah, that's right. At least that's my understanding as well. I just can't figure out why it won't work with CKEditor, even when it's the only textFormatter. I thought perhaps there was some other interaction with CKEditor that I was missing. Maybe that's not the issue at all. I'm stumped. I'll try a fresh install and work my way backwards. 

Share this post


Link to post
Share on other sites

@renobird the url must be written in its own line, only surrounded by <p>paragraph tags</p>. Have you checked this too?

  • Like 1

Share this post


Link to post
Share on other sites

What @horst said.

Also I got the same issue two days ago while I was trying to insert Facebook video in CKEditor. I needed to add this line to the Extra Allowed Content field to support iframe with HTML Purifier On: iframe[src,title,width,height,allowfullscreen,frameborder]

 

EAC.thumb.png.6fb42c681db8e5d20f23e08e7f1787cc.png

  • Like 3

Share this post


Link to post
Share on other sites
6 hours ago, flydev said:

Also I got the same issue two days ago while I was trying to insert Facebook video in CKEditor. I needed to add this line to the Extra Allowed Content field to support iframe with HTML Purifier On: iframe[src,title,width,height,allowfullscreen,frameborder]

Not actually the same issue - this module doesn't insert iframe (or any other code) into the RTE field. It's a textformatter, so it converts the youtube "view" URL into an iframe embedded URL on page load (frontend) only.

Share this post


Link to post
Share on other sites

Definitely on it's own line. Surrounding <p> tags are there. Everything checks out, and yet — *crickets*

I appreciate you all confirming it's not CKEditor related. I'll explore other options.

Share this post


Link to post
Share on other sites

Just wanted to report back in case I can save anyone else an hour or so.

After bashing my head against this I finally tracked it down to domain restrictions on some of the Vimeo videos.
In my test env I was using Youtube and Vimeo links from my personal account (no embed restrictions).
In production we were using Vimeo links from a colleagues account — they all had domain restrictions set.

Removed the restrictions, and waddya know, it works just fine.

 

  • Like 5

Share this post


Link to post
Share on other sites

Hi all. This has been driving me nuts: I've used this module previously and it worked perfectly. I've got it on 2 sites, but music-related. One works normally; I use the textformatter on the body text and videos display fine. The other only works if it's a Vimeo video; YouTube URLs slow the page loading then only displays the URL. I've tried a number of tests and different URLs and I can't figure this out. Both sites are not new and I'm pretty sure that it used to work where now it doesn't.

Here are two samples (they are past gigs, so I can play around with them without messing up the live sites):

Works: https://waveneyvalleyfolkcollective.co.uk/events/kirsty-merryn-jack-harris/

Doesn't Work: http://www.burstoncrown.com/events/sunday-sessions/falling-from-trees/

Any suggestions?

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By bernhard
      --- Please use RockFinder3 ---
    • By MoritzLost
      Cacheable Placeholders
      This module allows you to have pieces of dynamic content inside cached output. This aims to solve the common problem of having a mostly cacheable site, but with pieces of dynamic output here and there.  Consider this simple example, where you want to output a custom greeting to the current user:
      <h1>Good morning, <?= ucfirst($user->name) ?></h1> This snippet means you can't use the template cache (at least for logged-in users), because each user has a different name. Even if 99% of your output is static, you can only cache the pieces that you know won't include this personal greeting. A more common example would be CSRF tokens for HTML forms - those need to be unique by definition, so you can't cache the form wholesale.
      This module solves this problem by introducing cacheable placeholders - small placeholder tokens that get replaced during every request. The replacement is done inside a Page::render hook so it runs during every request, even if the response is served from the template cache. So you can use something like this:
      <h1>Good morning, {{{greeting}}}</h1> Replacement tokens are defined with a callback function that produces the appropriate output and added to the module through a simple hook:
      // site/ready.php wire()->addHookAfter('CachePlaceholders::getTokens', function (HookEvent $e) { $tokens = $e->return; $tokens['greeting'] = [ 'callback' => function (array $tokenData) { return ucfirst(wire('user')->name); } ]; $e->return = $tokens; }); Tokens can also include parameters that are parsed and passed to the callback function. There are more fully annotated examples and step-by-step instructions in the README on Github!
      Features
      A simple and fast token parser that calls the appropriate callback and runs automatically. Tokens may include multiple named or positional parameters, as well as multi-value parameters. A manual mode that allows you to replace tokens in custom pieces of cached content (useful if you're using the $cache API). Some built-in tokens for common use-cases: CSRF-Tokens, replacing values from superglobals and producing random hexadecimal strings. The token format is completely customizable, all delimiters can be changed to avoid collisions with existing tag parsers or template languages. Links
      Github Repository & documentation Module directory (pending approval) If you are interested in learning more, the README is very extensive, with more usage examples, code samples and usage instructions!
    • By Craig
      I've been using Fathom Analytics for a while now and on a growing number of sites, so thought it was about time there was a PW module for it.
      WayFathomAnalytics
      WayFathomAnalytics is a group of modules which will allow you to view your Fathom Analytics dashboard in the PW admin panel and (optionally) automatically add and configure the tracking code on front-end pages.
      Links
      GitHub Readme & documentation Download Zip Modules directory Module settings screenshot What is Fathom Analytics?
      Fathom Analytics is a simple, privacy-focused website analytics tool for bloggers and businesses.

      Stop scrolling through pages of reports and collecting gobs of personal data about your visitors, both of which you probably don't need. Fathom is a simple and private website analytics platform that lets you focus on what's important: your business.
      Privacy focused Fast-loading dashboards, all data is on a single screen Easy to get what you need, no training required Unlimited email reports Private or public dashboard sharing Cookie notices not required (it doesn't use cookies or collect personal data) Displays: top content, top referrers, top goals and more
    • By daniels
      This is a lightweight alternative to other newsletter & newsletter-subscription modules.
      You can find the Module in the Modules directory and on Github
      It can subscribe, update, unsubscribe & delete a user in a list in Mailchimp with MailChimp API 3.0. It does not provide any forms or validation, so you can feel free to use your own. To protect your users, it does not save any user data in logs or sends them to an admin.
      This module fits your needs if you...
      ...use Mailchimp as your newsletter / email-automation tool ...want to let users subscribe to your newsletter on your website ...want to use your own form, validation and messages (with or without the wire forms) ...don't want any personal user data saved in any way in your ProcessWire environment (cf. EU data regulation terms) ...like to subscribe, update, unsubscribe or delete users to/from different lists ...like the Mailchimp UI for creating / sending / reviewing email campaigns *I have only tested it with PHP 7.x so far, so use on owners risk
      EDIT:
      Since 0.0.4, instructions and changelog can be found in the README only. You can find it here  🙂
      If you have questions or like to contribute, just post a reply or create an issue or pr on github, thanks!
    • By MoritzLost
      Sorry for the convoluted title. I have a problem with Process modules that define a custom page using the page key through getModuleInfo (as demonstrated in this excellent tutorial by @bernhard). Those pages are created automatically when the module is installed. The problem is that the title of the page only gets set in the current language. That's not a problem if the current language (language of the superuser who is installing the module) is the default language; if it isn't, the Process page is missing a title in the default language. This has the very awkward effect that a user using the backend in the default language (or any other language) will see an empty entry in the setup menu:

      This screenshot comes from my Cache Control module which includes a Process page. Now I realize the description sounds obscure, but for us it's a common setup: We a multiple bilingual sites where the default language is German and the second language is English. While the clients use the CMS in German, as a developer I prefer the English interface, so whenever I install a Process module I get this problem.
      As a module author, is there a way to handle this situation? I guess it would be possible to use post-installation hooks or create the pages manually, but I very much prefer the declarative approach. The page title is already translatable (through the __ function), but of course at the time of installation there is no translation, and as far as I'm aware it's not possible to ship translations with a module so they are used automatically. Could this situation be handled better in the core? I would prefer if the module installation process would always set the title of the Process page in the default language, instead of the language of the current user.
×
×
  • Create New...