Jump to content

review theme


webhoes
 Share

Recommended Posts

Hello, I have been working on my first pw site the last view days. Normally I work with Wordpress.

I never really had to make a theme myself so this was a nice challange. I took some parts from another theme and added some scripts I found online.

The waves on the frontpage are based on repeating field. A text area, background color, wave color and yes/no for the waves.

The contact form is made of PHP as I could not get a javaScript solution working.

Please share some input to make it better... and please be nice as it is my first attempt at PW..

link is: pw.webhoes.nl

Sanne

  • Like 2
Link to comment
Share on other sites

Hi Sanne, nicely done. At first glance, I spotted two small issues: the carousel arrows unfortunately don't work, and the "LEES MEER" buttons on the portfolio page aren't functional (I'm using Firefox here). That said, I like the soft slide-into-place effect on navigating between pages, and the styling is pleasing and harmonic.

  • Like 1
Link to comment
Share on other sites

Hello BitPoet, thanks.

I meant to get rid of the arrows as I don't want a slider. Just removed them.

Is the div of the waves too high? I use firefox too and here it works.
The images of the portfolio page should also be clickable. Do they work with you?

Sanne

Link to comment
Share on other sites

Hello @webhoes,

on your project detail pages, the hero image zooms into the content below while scrolling. You should add a background color to the content below to avoid this. ;)

Also, you seem to have some console errors (for example [[ ++site_url]]). Maybe you are using a template engine, which produces those.

Regards, Andreas

Link to comment
Share on other sites

Hello AndZyk,

I noticed that on the project details. The background is set to #121212 but it still seems partly transparant for some reason. I have not jet found the part to disable that.

Those are modx chunks. I used some parts of a modx template.

If this template ever goes live, I will populate them with variables from the page.

Link to comment
Share on other sites

This CSS rule should be enough in your case, but maybe you want to be more specific:

.zoom-out-header-content {
    background-color: white;
}

Also I wouldn't provide a link to the admin on the front end, but this is just my opinion and maybe your are using this only for development. ;)

Link to comment
Share on other sites

  • 2 months later...

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

×
×
  • Create New...