matjazp

Auto Smush

Recommended Posts

On 19/01/2017 at 0:42 PM, matjazp said:

Sorry for troubles. Please upgrade to 1.0.6 if that fixes it (just uploaded to github).

That worked. Thanks matjazp

I have a site with about 1951 images to be uploaded and downloaded to reShmush.it server

I realise this can be CPU intensive but am running some tests.

I always have an error at around 2% of upload

Quote

Optimizing image 48 out of 1951 - 2% complete An error occured, please try again

 

Each image is well below 5MB. I wondered if there was a limit to the amount of actual images which can be processed at any one time?

 

Share this post


Link to post
Share on other sites

Hi, Peter, sorry for late response, it was a busy weekend. Hm, that's unexpected error, it should only pop up if ajax call fail, but since 48 of images got processed ... Could you check /site/assets/logs/autosmush.txt and /site/assets/autosmush/progress.json if there is any clue? Check php error log. Also check the value of max_execution_time in php.ini and apache Timeout directive, maybe the script is timing out (I set it to 1 hour). Also please edit file /site/modules/AutoSmush/AutoSmush.js and change pollTime var from 100 to 500. I just tried with 70 images without problem. Bulk mode in the current state is not very good at processing large amount of images - 1951 is not large at all, but I never tested more than 100 images. Bulk mode needs complete rewrite, but since it worked good enough for small sites I just left it as is...

 

Share this post


Link to post
Share on other sites

Not a problem. Thanks for getting back to me.

 

I don't see anything obvious but not entirely sure what to look for.

progress.json only has 1 line:

{"percentComplete":"1","counter":"Optimizing image 32 out of 2039 - 1% complete","percentNew":"0","error":null,"file":"phoot-security.0x100.jpg","basedir":"1079","url":"https:\/\/www.domain.co.uk\/site\/assets\/files\/1079\/phoot-security.0x100.jpg"}

Error log displays a list of files and their reduction and then there's one in error in particular

2017-03-22 12:15:00	Error optimizing /var/www/vhosts/domain.co.uk/httpdocs/site/assets/files/1072/085---dc3420.0x100.jpg, 404

BTW I'm using the online service for all of these. Perhaps I should try install a local optimization tool too?

 

Share this post


Link to post
Share on other sites

That 404 is response from resmush.it web service, it happens sometimes. But the optimisation process should continue, regardless of the error - at least that's how its intended to be... As recommended, I would try setting pollTime from 100 to 500 in AutoSmush.js Installing local optimizers would save you sending/fetching the file to/from web service.

Share this post


Link to post
Share on other sites

Thanks for the info.

Forgive my ignorance but when you say 'local optimizers' are these installed on my VPS or on a local machine?

Share this post


Link to post
Share on other sites
8 hours ago, Peter Knight said:

Forgive my ignorance but when you say 'local optimizers' are these installed on my VPS or on a local machine?

I can't know that. Check the "Advanced options for local tools", the module shoud show you if (and what) optimizers are available on your machine.

Share this post


Link to post
Share on other sites
14 hours ago, matjazp said:

I can't know that. Check the "Advanced options for local tools", the module shoud show you if (and what) optimizers are available on your machine.

Sorry - I've managed to confuse you.

I wondered if 'local' meant the optimizers *should* be installed on a server or a local machine.

I'm pretty sure they're server based but I normally understand 'local' to mean the desktop / laptop on front of me.

Anyway, I'm sure optimizers are installed on the host server. No need to revert and thanks again for the help. 

Share this post


Link to post
Share on other sites
2 hours ago, Peter Knight said:

I wondered if 'local' meant the optimizers *should* be installed on a server or a local machine.

Oh, I never thought of that! Yes, local means on a computer (server), where PW is installed. Hmm, now I see how confusing can it be. What wording do you propose? 

Share this post


Link to post
Share on other sites
On 23/03/2017 at 9:15 PM, matjazp said:

Oh, I never thought of that! Yes, local means on a computer (server), where PW is installed. Hmm, now I see how confusing can it be. What wording do you propose? 

Maybe one of the following?

  • Use local optimization tools (on website server)
  • Use your web servers optimization tools
  • Use optimization on website server

 

Share this post


Link to post
Share on other sites

@matjazp The module's css is causing style issue on the entire admin at inputfield label headers. This happens only on localhost.

This line causing the issue:

.InputfieldForm label.InputfieldHeader {
    padding-top: .4em;
}

Localhost screenshot

locahost.thumb.jpg.351273ab46e6269fb21425ed0d397f24.jpg

Server screenshot

server.thumb.jpg.115d4eb4162f16e307c64ebad9676626.jpg

Share this post


Link to post
Share on other sites
6 hours ago, PWaddict said:

.InputfieldForm label.InputfieldHeader { padding-top: .4em; }

You can comment out the rule and off you go. It has nothing to do with localhost or server, you're probably running different version of AS. I removed padding in v1.1.0.

Share this post


Link to post
Share on other sites
27 minutes ago, matjazp said:

You can comment out the rule and off you go. It has nothing to do with localhost or server, you're probably running different version of AS. I removed padding in v1.1.0.

No I'm using the 1.1.0 version on both. You haven't actually removed the padding. You have it like this:

/*
.InputfieldForm label.InputfieldHeader {
    padding-top: .4em;
}

.AdminThemeUikit .InputfieldForm label.InputfieldHeader {
    padding-top: 20px;
}
*/

I don't understand why on localhost it reads that. Is that ok if you remove it completely?

EDIT: It was a cache issue. Localhost was reading the previous version's css. I opened the AutoSmush.css link to refreshed it and problem fixed.

Share this post


Link to post
Share on other sites

@matjazp - I am thinking about starting to use this, but was wondering your thoughts about maybe integrating https://github.com/spatie/image-optimizer instead or as well as https://github.com/psliwa/image-optimizer

It uses a similar collection of tools for optimizing, but the main difference is that it also includes SVGO which of course adds support for "compressing" SVGs.

I honestly haven't looked into the two libraries much more than that though, so there might be very valid reasons to stay with the one you have.

  • Like 1

Share this post


Link to post
Share on other sites

Thanks for considering using AS, I'm sure some bugs might pop up :-) Will check spatie's image-optimizer and see what can be done. 

  • Like 1

Share this post


Link to post
Share on other sites

Hm, I can't even upload SVG image, the spinner is running, no js error... Strange, another image field and upload is working. But there are no crop/variations buttons, this is how it should be?

Share this post


Link to post
Share on other sites
39 minutes ago, matjazp said:

Hm, I can't even upload SVG image, the spinner is running, no js error... Strange, another image field and upload is working. But there are no crop/variations buttons, this is how it should be?

I am not sure why you had issues uploading an SVG in one field. As for why there is no crop/variations - these really aren't that relevant to the a vector file. You could kind of crop by using a clipping mask, but an actual crop is a pretty complex thing that would require a powerful vector editor to achieve because it involves completely changing the paths that make up the Illustration.

Share this post


Link to post
Share on other sites

I won't invest time in svg upload issue. Thanks for the info on crop/variations. Missing those two buttons made me fix a bug in AS. Have some issues testing svgo on windows since there is no svgo for windows, the best alternative is svgop executable, but it's almost 40MB.

Share this post


Link to post
Share on other sites
4 hours ago, matjazp said:

I won't invest time in svg upload issue. Thanks for the info on crop/variations. Missing those two buttons made me fix a bug in AS. Have some issues testing svgo on windows since there is no svgo for windows, the best alternative is svgop executable, but it's almost 40MB.

Don't worry too much about this - I just thought if it was easy, it would be a nice addition to have SVG support.

Share this post


Link to post
Share on other sites

Please grab the latest version (1.1.1) and test. reSmush.it has no support for svg, so you must use web server tools, aka sudo npm install -g svgo. I tested here on windows and included svgo.exe binary that add 8 MB to the download size.

  • Like 1

Share this post


Link to post
Share on other sites

Sorry for taking so long to get back to you @matjazp - I just tested your svgo implementation and it's awesome!

The only catch I have is with svgo itself. Sometimes it can break svgs - elements can get moved, etc. I am wondering if you have any thoughts about building in an "Accept Compressed Version" ? Maybe another alternative would be a "Restore Original Version" button that would removed the optimized version and replace it with the backed up one?

The other thing I noticed is that if you are running my CustomUploadNames module the backed version keeps the original filename - would you mind changing it to use the new name instead please?

Share this post


Link to post
Share on other sites

Will think about undo option, but likely won't be soon, December is a busy month. I never used CustomUploadnames so have to test. I guess we are both hooking to the same method?

Share this post


Link to post
Share on other sites
23 minutes ago, matjazp said:

Will think about undo option, but likely won't be soon, December is a busy month. I never used CustomUploadnames so have to test. I guess we are both hooking to the same method?

Thanks for considering the undo/review option. As for CustomUploadNames, I have adjusted the hook priority in that so you don't need to consider it now in AutoSmush.

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By horst
      Wire Mail SMTP

      An extension to the new WireMail base class that uses SMTP-transport

      This module integrates EmailMessage, SMTP and SASL php-libraries from Manuel Lemos into ProcessWire. I use this continously evolved libraries for about 10 years now and there was never a reason or occasion not to do so. I use it nearly every day in my office for automated composing and sending personalized messages with attachments, requests for Disposition Notifications, etc. Also I have used it for sending personalized Bulkmails many times.

      The WireMailSmtp module extends the new email-related WireMail base class introduced in ProcessWire 2.4.1 (while this writing, the dev-branch only).
       
      Here are Ryans announcement.



      Current Version 0.3.0
      get it from the Modules Directory Install and Configure

      Download the module into your site/modules/ directory and install it.

      In the config page you fill in settings for the SMTP server and optionaly the (default) sender, like email address, name and signature.
      You can test the smtp settings directly there. If it says "SUCCESS! SMTP settings appear to work correctly." you are ready to start using it in templates, modules or bootstrap scripts.


      Usage Examples
      The simplest way to use it:
      $numSent = wireMail($to, $from, $subject, $textBody); $numSent = wireMail($to, '', $subject, $textBody); // or with a default sender emailaddress on config page This will send a plain text message to each recipient.
       
      You may also use the object oriented style:
      $mail = wireMail(); // calling an empty wireMail() returns a wireMail object $mail->to($toEmail, $toName); $mail->from = $yourEmailaddress; // if you don't have set a default sender in config // or if you want to override that $mail->subject($subject); $mail->body($textBody); $numSent = $mail->send(); Or chained, like everywhere in ProcessWire:
      $mail = wireMail(); $numSent = $mail->to($toEmail)->subject($subject)->body($textBody)->send(); Additionaly to the basics there are more options available with WireMailSmtp. The main difference compared to the WireMail BaseClass is the sendSingle option. With it you can set only one To-Recipient but additional CC-Recipients.
      $mail = wireMail(); $mail->sendSingle(true)->to($toEmail, $toName)->cc(array('person1@example.com', 'person2@example.com', 'person3@example.com')); $numSent = $mail->subject($subject)->body($textBody)->send(); The same as function call with options array:
      $options = array( 'sendSingle' => true, 'cc' => array('person1@example.com', 'person2@example.com', 'person3@example.com') ); $numSent = wireMail($to, '', $subject, $textBody, $options); There are methods to your disposal to check if you have the right WireMail-Class and if the SMTP-settings are working:
      $mail = wireMail(); if($mail->className != 'WireMailSmtp') { // Uups, wrong WireMail-Class: do something to inform the user and quit echo "<p>Couldn't get the right WireMail-Module (WireMailSmtp). found: {$mail->className}</p>"; return; } if(!$mail->testConnection()) { // Connection not working: echo "<p>Couldn't connect to the SMTP server. Please check the {$mail->className} modules config settings!</p>"; return; } Following are a ...


      List of all options and features


      testConnection () - returns true on success, false on failures


      sendSingle ( true | false ) - default is false

      sendBulk ( true | false ) - default is false, Set this to true if you have lots of recipients (50+)


      to ($recipients) - one emailaddress or array with multiple emailaddresses

      cc ($recipients) - only available with mode sendSingle, one emailaddress or array with multiple emailaddresses

      bcc ($recipients) - one emailaddress or array with multiple emailaddresses

       
      from = 'person@example.com' - emailaddress, can be set in module config (called Sender Emailaddress) but it can be overwritten here

      fromName = 'Name Surname' - optional, can be set in module config (called Sender Name) but it can be overwritten here


      priority (3) - 1 = Highest | 2 = High | 3 = Normal | 4 = Low | 5 = Lowest

      dispositionNotification () or notification () - request a Disposition Notification


      subject ($subject) - subject of the message

      body ($textBody) - use this one alone to create and send plainText emailmessages

      bodyHTML ($htmlBody) - use this to create a Multipart Alternative Emailmessage (containing a HTML-Part and a Plaintext-Part as fallback)

      addSignature ( true | false ) - the default-behave is selectable in config screen, this can be overridden here
      (only available if a signature is defined in the config screen)

      attachment ($filename, $alternativeBasename = "") - add attachment file, optionally alternative basename


      send () - send the message(s) and return number of successful sent messages


      getResult () - returns a dump (array) with all recipients (to, cc, bcc) and settings you have selected with the message, the message subject and body, and lists of successfull addresses and failed addresses,


      logActivity ($logmessage) - you may log success if you want

      logError ($logmessage) - you may log warnings, too. - Errors are logged automaticaly
       
       
      useSentLog (true | false) - intended for usage with e.g. third party newsletter modules - tells the send() method to make usage of the sentLog-methods - the following three sentLog methods are hookable, e.g. if you don't want log into files you may provide your own storage, or add additional functionality here

      sentLogReset ()  - starts a new LogSession - Best usage would be interactively once when setting up a new Newsletter

      sentLogGet ()  - is called automaticly within the send() method - returns an array containing all previously used emailaddresses

      sentLogAdd ($emailaddress)  - is called automaticly within the send() method
       
      Changelog: https://github.com/horst-n/WireMailSmtp/blob/master/CHANGELOG.md
       
    • By Robin S
      An experimental module for adding images to a field via pasting one or more URLs.
      Add Image URLs
      Allows images to be added to an images field by pasting URLs.

      Usage
      Install the Add Image URLs module.
      A "Paste URLs" button will be added to all image fields. Use the button to show a textarea where image URLs may be pasted, one per line. Images are added when the page is saved.
       
      https://github.com/Toutouwai/AddImageUrls
    • By netcarver
      This module provides a very simple interface to a set of named counters. You simply call a single function, next('name'), to pull the next value out of a counter - or to set it up if it does not yet exist. Next() takes a few extra parameters to allow you to increment by values other than 1 or to start at a certain number.
      This provides some similar functionality to the built-in page naming feature of PW, and to this module recently posted by Stikki but I think it offers a little more flexibility than either. Having said that, I do like the simplicity of Stikki's new auto-increment module.
      Module Availability
      Here is my module on Github.
      Here it is in the module repository.
      Example Usage
      Here's how this module can be used to title and name a new page by adding a couple of simple hooks to site/ready.php. This example applies to new pages using a template called 'invoice' that can be quick-added to the page tree. In order to get the following to work, you must edit the template that will be the parent of the 'invoice' template and setup the template for children to "invoice" and set the "Name Format for Children" field to something other than the default blank value (I use  title  as my value.)
      <?php /** * Function to recognise our special template. */ function isInvoiceTemplate($template) { return ($template == 'invoice'); } /** * Pre-load the page title for invoice pages with a unique value * which includes a counter component. */ $pages->addHookBefore("Pages::setupNew", function($event) { $page = $event->arguments(0); $is_invoice = isInvoiceTemplate($page->template); $no_inv_num = $page->title == ''; if ($is_invoice && $no_inv_num) { $counter_name = 'WR-' . date('Y'); $number = $this->modules->get('DatabaseCounters')->next($counter_name, 10, 5000); $page->title = $counter_name . '-' . sprintf("%06u", $number); } }); /** * Prevent ProcessPageEdit from forcing an edit of the name if we got here * through a quickAdd from ProcessPageAdd. We can do this because we * preset the title field in the Pages::setupNew hook. */ $pages->addHookAfter("ProcessPageEdit::loadPage", function($event) { $page = $event->return; $is_invoice = isInvoiceTemplate($page->template); $is_temp = $page->hasStatus(Page::statusTemp); if ($is_invoice && $is_temp) { $page->removeStatus(Page::statusTemp); $event->return = $page; } }); Note, the above code + module is one direct solution to the problem posted here by RyanJ.


      Version History
      1.0.0 The initial release.
    • By flydev
      PulsewayPush
      Send "push" from ProcessWire to Pulseway.
       
      Description
      PulsewayPush simply send a push to a Pulseway instance. If you are using this module, you probably installed Pulseway on your mobile device: you will receive notification on your mobile.
      To get more information about Pulseway, please visit their website.
      Note
      They have a free plan which include 10 notifications (push) each day.
       
      Usage
      Install the PulsewayPush module.
      Then call the module where you like in your module/template code :
      <?php $modules->get("PulsewayPush")->push("The title", "The notification message.", "elevated"); ?>  
      Hookable function
      ___push() ___notify() (the two function do the same thing)
       
      Download
      Github:  https://github.com/flydev-fr/PulsewayPush Modules Directory: https://modules.processwire.com/modules/pulseway-push/  
      Examples of use case
      I needed for our work a system which send notification to mobile device in case of a client request immediate support. Pulseway was choosen because it is already used to monitor our infrastructure.
      An idea, you could use the free plan to monitor your blog or website regarding the number of failed logins attempts (hooking Login/Register?), the automated tool then block the attacker's IP with firewall rules and send you a notification.
       

       
      - - -
      2017-11-22: added the module to the modules directory
       
    • By cosmicsafari
      Hi all,
      Just wondering if its possible to just add some basic output to my modules config page.
      I was wanting to output a bulleted list of some information which I will be pulling from a third party.
      Retrieving the data is fine i'm just not sure how to output it to the config page?
      From what I can see in the link below, it only seems like you can append form items to the page.
      https://processwire.com/blog/posts/new-module-configuration-options/