Jump to content
horst

Croppable Image 3

Recommended Posts

15 hours ago, PWaddict said:

@horst I fixed the cache problem on cropping by replacing the 145 line on ProcessCroppableImage3.module with this:


'imageUrl' => $imageUrl . "?nc=" . $img->mtime,

 

I added the timestamp to the url. So I wasn't able to reproduce this issue, but cannot see any harm by adding the timestamp to the url.

If you think this should be added to the core Variations Page, please make an issue at Github.

  • Like 1

Share this post


Link to post
Share on other sites
1 hour ago, tpr said:

@horst Could you add this JS fix too?

 

 

Using this js fix or not when I press "Accept Crop" and the modal closes the icon-size thumb disappears. I'm getting this error on console: Failed to load resource: the server responded with a status of 404 () testing.-thumbnailn.jpg. This issue happens only after you saved the page.

It should load the file as testing.-thumbnail.0x48n.jpg. The timestamp also must be used on that too in order to get always the last modified thumb and not the very first cached one.

Share this post


Link to post
Share on other sites
1 hour ago, PWaddict said:

It should load the file as testing.-thumbnail.0x48n.jpg

No. After you make a crop and close the modal (Accept), no 0x48 image is generated (perhaps the module should do this?). That's why I load the original thumb instead (this is fast because it's cached by the browser). On next crops I toggle the "?v=1" "?v=2" params, in my tests it was enough to bypass the browser cache.

It's hard to tell what goes wrong for you until I can duplicate the issue. Could you share your settings and workflow exactly? (PM is ok too)

  • Like 1

Share this post


Link to post
Share on other sites
56 minutes ago, tpr said:

No. After you make a crop and close the modal (Accept), no 0x48 image is generated (perhaps the module should do this?). That's why I load the original thumb instead (this is fast because it's cached by the browser). On next crops I toggle the "?v=1" "?v=2" params, in my tests it was enough to bypass the browser cache.

It's hard to tell what goes wrong for you until I can duplicate the issue. Could you share your settings and workflow exactly? (PM is ok too)

I'm currently testing it on localhost. It doesn't load the original thumb. It loads an image that doesn't exists.

Original thumb
testing.-thumbnail.jpg

Currently loads this non available image
testing.-thumbnailn.jpg

You have to modify the js code to remove the cropping values too. I'm using cropping = north. That's why the "n".

Share this post


Link to post
Share on other sites

@tpr if this is right, (I haven't tested it), we would need something that works with all possible variation names. On weekend I can setup a test system, (also online), and check all combinations. (and give you access to it if you like).

Share this post


Link to post
Share on other sites

Yes, crop orientation is the culprit (added via $config->imageSizerOptions array, at least that's how I could see it).

I've made the fixes here, please try:

https://github.com/rolandtoth/CroppableImage3

This should be a generic fix, I pass the image url from the crop review modal to the js. Additionally, only the current preview btn image is refreshed and not all (unlike before).

  • Like 2

Share this post


Link to post
Share on other sites
46 minutes ago, tpr said:

Yes, crop orientation is the culprit (added via $config->imageSizerOptions array, at least that's how I could see it).

I've made the fixes here, please try:

https://github.com/rolandtoth/CroppableImage3

This should be a generic fix, I pass the image url from the crop review modal to the js. Additionally, only the current preview btn image is refreshed and not all (unlike before).

Works great. One small fix from me. After saving the page or revisiting it I'm seeing a previous cached icon-size thumb. This happening even on localhost. So, I fixed it by replacing the 155 line on InputfieldCroppableImage3.module with this:

$out .= $warning ? '' : " <img src='{$pagefile->getCrop($suffix)->height(48)->url}?nc={$pagefile->mtime}' alt='' />";  // added a small indicator thumb to each crop-button

 

  • Like 2

Share this post


Link to post
Share on other sites

@horst @tpr After closing the modal the hover tooltip appears and it feels like a glitch cause it also half-cover the button preview.

I fixed it by replacing the 34 line on InputfieldCroppableImage3.js with this:

items: 'a:hover'

Thank you very much guys for your work :)

  • Like 1

Share this post


Link to post
Share on other sites

Yes, please do. will merge it later today and do a more indepth test on weekend.

Thanks you both. :)

Share this post


Link to post
Share on other sites

I've made a few CSS changes, now preview buttons look the same in all 3 image grid modes and I've fixed some other glitches too. The CSS file was a bit overcomplicated, I could eliminate large blocks so I hope I haven't broken anything :) 

I also checked the preview images with more than one crop setting (multiple buttons) and it's working fine here. All is in the PR.

  • Like 4

Share this post


Link to post
Share on other sites

Hi, I have a problem with the automatic cropping of pictures which are in other orientations. The automatic correction of pw works like a charm and the manual cropping works also fine. But the automatic cropping gives me the other orientation in which the picture was uploaded. Is there any fix for this?

Share this post


Link to post
Share on other sites
On 29.5.2017 at 3:06 PM, noodles said:

Anyone else experiencing this issue with the UiKit backend? :-( Any fixes?

 

Just in time with the new AdminThemeUiKit and RenoSkin, there is a fixed version of CroppableImage3 pushed to the repo today.

Many thanks for his help goes to @tpr !! ^-^

 

screen_cai3_uikit.png.711b59c9bd51986ebcd0a0317ac86aa5.png

  • Like 3
  • Thanks 1

Share this post


Link to post
Share on other sites
On 12.9.2017 at 5:26 PM, hheyne said:

Hi, I have a problem with the automatic cropping of pictures which are in other orientations. The automatic correction of pw works like a charm and the manual cropping works also fine. But the automatic cropping gives me the other orientation in which the picture was uploaded. Is there any fix for this?

@hheyne the orientation problem is core related. Whereas it is no problem in all core related api image handling, it is one in CAI3. But there is no simple fix known atm. Maybe one should hook into upload and save those images rotated (with quality 100 and sharpening 'none') as original replacement?! At least as workaround until there is found a system wide solution for the orientation problem.

Share this post


Link to post
Share on other sites

Hi Horst, I saw from a screenshot you posted earlier that you found a way to remove the PW Crop button (next to the Variations button).

(My users get confused by the cropping the module requires and they need to do -  and the additional generic PW cropping button.)

How did you hide that generic PW crop button? Did I miss a setting somewhere?

Share this post


Link to post
Share on other sites
38 minutes ago, ceberlin said:

Hi Horst, I saw from a screenshot you posted earlier that you found a way to remove the PW Crop button (next to the Variations button).

(My users get confused by the cropping the module requires and they need to do -  and the additional generic PW cropping button.)

How did you hide that generic PW crop button? Did I miss a setting somewhere?

Install the Admin Custom Files module. On site/templates/AdminCustomFiles folder create a css file named ProcessPageEdit.css and add the following code:

.InputfieldImageButtonCrop {
	display: none !important;
}

Then on the Admin Custom Files module settings at the "Activate for process" section select ProcessPageEdit, (Page Edit).

  • Like 2
  • Thanks 1

Share this post


Link to post
Share on other sites
21 hours ago, ceberlin said:

Hi Horst, I saw from a screenshot you posted earlier that you found a way to remove the PW Crop button (next to the Variations button).

(My users get confused by the cropping the module requires and they need to do -  and the additional generic PW cropping button.)

How did you hide that generic PW crop button? Did I miss a setting somewhere?

I used this line, (uncommented), to hide them. But maybe this will have side-efects if you use it together with core imagefields in your pages.

Better to use it the way @PWaddict said!

  • Thanks 1

Share this post


Link to post
Share on other sites

Thanks for this great module! I am finding responsive image solutions and then I luckily come here.

I have encountered an issue after I install the module. I tried to change the inputfield type of an existing image field to croppable image3. The croppable image3 specific crop setting is not there after switching. So, in the edit, it is just look the same as the normal image field. Sorry if it has been reported before as I did not read all replies one by one.

Share this post


Link to post
Share on other sites

I know this behave. You need to save it 2 - 3 times during the switch process. I believe this has to do with pw core, not only that module.

  • Thanks 1

Share this post


Link to post
Share on other sites

This is the first time I encounter this issue. Thanks for the tip for fixing it.

Share this post


Link to post
Share on other sites

Hi there. I have encounter another issue that what ever I change the sharpen and quality during cropping, the sharpen and quality are always showing soft and 90 respectively after confirm the crop. The resulting images are the same too, so it is simply not a display issue.

Share this post


Link to post
Share on other sites

Bump. I confirm the same issue in a fresh installed latest PW3. I want to debug but TracyDebugger is not loading in this module.

Share this post


Link to post
Share on other sites

please can you describe a bit precise:

wich version are you using

what are you doing exactly (how do you do it)

what is the desired output / behave

and what is the real output / behave

Share this post


Link to post
Share on other sites

The module is installed by module installer using module name. The module version is 1.1.10. PW version 3.0.83.

Step1: Change the seting and hit "Crop And Go".

step1.jpg.242c70b00358733e6971f93513b3a555.jpg

Step2: Jump to the confirmation. The quality and sharpening remain unchanged. (Should be changed to 75 and none as above here)

step2.jpg.21170f339552b6fe410a0cb68aafead0.jpg

Step3: Repeat above steps with default setting(soft, 90).

Step4: Check the image cropped by changed setting and default setting. They have the same file size.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By joshua
      This module is (yet another) way for implementing a cookie management solution.
      Of course there are several other possibilities:
      - https://processwire.com/talk/topic/22920-klaro-cookie-consent-manager/
      - https://github.com/webmanufaktur/CookieManagementBanner
      - https://github.com/johannesdachsel/cookiemonster
      - https://www.oiljs.org/
      - ... and so on ...
      In this module you can configure which kind of cookie categories you want to manage:

      You can also enable the support for respecting the Do-Not-Track (DNT) header to don't annoy users, who already decided for all their browsing experience.
      Currently there are four possible cookie groups:
      - Necessary (always enabled)
      - Statistics
      - Marketing
      - External Media
      All groups can be renamed, so feel free to use other cookie group names. I just haven't found a way to implement a "repeater like" field as configurable module field ...
      When you want to load specific scripts ( like Google Analytics, Google Maps, ...) only after the user's content to this specific category of cookies, just use the following script syntax:
      <script type="optin" data-type="text/javascript" data-category="statistics" data-src="/path/to/your/statistic/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing" data-src="/path/to/your/mareketing/script.js"></script> <script type="optin" data-type="text/javascript" data-category="external_media" data-src="/path/to/your/external-media/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing">console.log("Inline scripts are also working!");</script> The type has to be "optin" to get recognized by PrivacyWire, the data-attributes are giving hints, how the script shall be loaded, if the data-category is within the cookie consents of the user. These scripts are loaded asynchronously after the user made the decision.
      If you want to give the users the possibility to change their consent, you can use the following Textformatter:
      [[privacywire-choose-cookies]] It's planned to add also other Textformatters to opt-out of specific cookie groups or delete the whole consent cookie.
      You can also add a custom link to output the banner again with a link / button with following class:
      <a href="#" class="privacywire-show-options">Show Cookie Options</a> <button class="privacywire-show-options">Show Cookie Options</button> This module is still in development, but we already use it on several production websites.
      You find it here: PrivacyWire Git Repo
      Download as .zip
      I would love to hear your feedback 🙂
      CHANGELOG
      0.0.5 Multi-language support included completely (also in TextFormatter). Added possibility to async load other assets (e.g. <img type="optin" data-category="marketing" data-src="https://via.placeholder.com/300x300">) 0.0.4 Added possibility to add an imprint link to the banner 0.0.3 Multi-language support for module config (still in development) 0.0.2 First release 0.0.1 Early development
    • By MoritzLost
      This is a new module that provides a simple solution to clearing all your cache layers at once, and an extensible interface to perform various cache-related actions.
      The simple motivation behind this module was that I was tired of manually clearing caches in several places after deploying a change on a live site. The basic purpose of this module is a simple Clear all caches link in the Setup menu which clears out all caches, no matter where they hide. You can customize what exactly the module does through it's configuration menu:
      Expire or delete all cache entries in the database, or selectively clear caches by namespace ($cache API) Clear the the template render cache. Clear out specific folders inside your site's cache directory (/site/assets/cache) Refresh version strings for static assets to bust client-side browser caches (this requires some setup, see the full documentation for details). This is the basic function of the module. However, you can also add different cache management action through the API and execute them through the module's interface. For this advanced usage, the module provides:
      An interface to see all available cache actions and execute them. A system log and logging output on the module page to see verify what the module is doing. A CacheControlTools class with utility functions to clear out different caches. An API to add cache actions, execute them programmatically and even modify the default action. Permission management, allowing you granular control over which user roles can execute which actions. The complete documentation can be found in the module's README.
      Beta release
      Note that I consider this a Beta release. Since the module is relatively aggressive in deleting some caches, I would advise you to install in on a test environment before using it on a live site.
      Let me know if you're getting any errors, have trouble using the module or if you have suggestions for improvement!
      In particular, can someone let me know if this module causes any problems with the ProCache module? I don't own or use it, so I can't check. As far as I can tell, ProCache uses a folder inside the cache directory to cache static pages, so my module should be able to clear the ProCache site cache as well, I'd appreciate it if someone can test that for me.
      Future plans
      If there is some interest in this, I plan to expand this to a more general cache management solution. I particular, I would like to add additional cache actions. Some ideas that came to mind:
      Warming up the template render cache for publicly accessible pages. Removing all active user sessions. Let me know if you have more suggestions!
      Links
      https://github.com/MoritzLost/ProcessCacheControl ProcessCacheControl in the Module directory

    • By David Karich
      Admin Page Tree Multiple Sorting
      ClassName: ProcessPageListMultipleSorting
      Extend the ordinary sort of children of a template in the admin page tree with multiple properties. For each template, you can define your own rule. Write each template (template-name) in a row, followed by a colon and then the additional field names for sorting.
      Example: All children of the template "blog" to be sorted in descending order according to the date of creation, then descending by modification date, and then by title. Type:
      blog: -created, -modified, title  Installation
      Copy the files for this module to /site/modules/ProcessPageListMultipleSorting/ In admin: Modules > Check for new modules. Install Module "Admin Page Tree Multible Sorting". Alternative in ProcessWire 2.4+
      Login to ProcessWire backend and go to Modules Click tab "New" and enter Module Class Name: "ProcessPageListMultipleSorting" Click "Download and Install"   Compatibility   I have currently tested the module only under PW 2.6+, but think that it works on older versions too. Maybe someone can give a feedback.     Download   PW-Repo: http://modules.processwire.com/modules/process-page-list-multiple-sorting/ GitHub: https://github.com/FlipZoomMedia/Processwire-ProcessPageListMultipleSorting     I hope someone can use the module. Have fun and best regards, David
    • By dimitrios
      Hello,
      this module can publish content of a Processwire page on a Facebook page, triggered by saving the Processwire page.
      To set it up, configure the module with a Facebook app ID, secret and a Page ID. Following is additional configuration on Facebook for developers:
      Minimum Required Facebook App configuration:
      on Settings -> Basics, provide the App Domains, provide the Site URL, on Settings -> Advanced, set the API version (has been tested up to v3.3), add Product: Facebook Login, on Facebook Login -> Settings, set Client OAuth Login: Yes, set Web OAuth Login: Yes, set Enforce HTTPS: Yes, add "https://www.example.com/processwire/page/" to field Valid OAuth Redirect URIs. This module is configurable as follows:
      Templates: posts can take place only for pages with the defined templates. On/Off switch: specify a checkbox field that will not allow the post if checked. Specify a message and/or an image for the post.
      Usage
      edit the desired PW page and save; it will post right after the initial Facebook log in and permission granting. After that, an access token is kept.
       
      Download
      PW module directory: http://modules.processwire.com/modules/auto-fb-post/ Github: https://github.com/kastrind/AutoFbPost   Note: Facebook SDK for PHP is utilized.


×
×
  • Create New...