Jump to content
horst

Croppable Image 3

Recommended Posts

I don't understand. Please can you clarify, maybe with a short explanation, what you want to do?

Share this post


Link to post
Share on other sites

Yes of course.

When the module is cropping an image, a variation image is created in /assets/files/id by CroppableImage3Helpers::renderImage method. I want to hook to the method like this to have treatments on the newly created image. Right now it is not hookable. My use case is to upload the image to AWS S3 if I want to make a stateless webserver. I have made the same request to processwire-request for your information.

I think there can be more use cases. One of them always on my mind is generating a small placeholder image for lazy loading.

Share this post


Link to post
Share on other sites

I think you don't need to hook into this module. You need to hook into Pageimage, doing the following:

  • check if the requested variation is available on your AWS S3 remote storage,
  • and if yes, just link to it,
  • and if no, create a new one, upload it and finally link to it.

This is independent from the different ImageRenderingEngines and extra modules.

EDIT:

Have you seen this:

 

Share this post


Link to post
Share on other sites

Thanks for your suggestion.

I have tried what you have suggested before. The problem of this approach is that checking remote asset availability needs an extra round trip and that increases the page loading time a lot. If there are many images in a page, every PageImage call would have to check if the remote image is available or not. This is not feasible. Please correct me if I am wrong.

I think of a workaround for handling this module. As page editor will save the page, most likely, after adding new crop, I can hook to page save to sync with AWS S3, although the module does not require hitting save to make changes.

Share this post


Link to post
Share on other sites

What is the primary benefit for hosting images in the S3 cloud?

Or the other way round: do you need to save diskspace on your local server?

Share this post


Link to post
Share on other sites

For webapp and e-commerce shops, high availability is critical. To achieve this, one of the approaches is using multiple stateless web servers running in parallel, by keeping all assets and database away from the web servers. In this way, we can add or remove as many web server as we need. Assets can be kept safe and synchronized across all web servers.

I use AWS's Elastic Beanstalk to achieve this infrastructure. The ec2 servers controlled by Elastic Beanstalk will be terminated and rebuilt from time to time, so stateless servers are needed to use this kind of service or infrastructure.

  • Like 2

Share this post


Link to post
Share on other sites
48 minutes ago, horst said:

Have you seen this:

Yes. I have tried this module. It is working great with normal file, but using this would lose the image inputfiled editor, and the feature of Croppable Image 3, which I am using in my every project.😭

Share this post


Link to post
Share on other sites

I've never dealt with AWS, and although I'm sure you've searched around, I found some forum threads dealing with similar issues.

https://processwire.com/blog/posts/amazon-aws-now-powering-processwire.com-sites/

^ nothing specific about image-cropping (or images in general), but maybe @ryan has built something which would help you find a solution?

(don't want to pollute this thread, just thinking maybe you'll find some hints or code-snippets...)

Share this post


Link to post
Share on other sites

Thanks @dragan. I don't want to off topic much too. I am actually forking the module you mentioned to make it a more robust one. I would share the module once it is completed. It will be working silently and seamlessly with other modules. As Croppable Image 3 is my must use module, I just seek any chance that I can make the integration better.😅(trying to relate Croppable Image 3 more)

Share this post


Link to post
Share on other sites

Hhm, so you will have one or multiple webservers with different states of variations, but only the AWS S3 cloud is always containing everything.

What's about your own idea, hooking into $page->save():

  • check if imagefield(s) exist in that edited page
  • if yes, compare all image and variation timestamps and upload those from within the last x minutes.

This way, you are completly free to use what ever image tools you like.

  • Like 1

Share this post


Link to post
Share on other sites

Hi Horst

Possible bug...

When I'm in the popup window which displays the crop preview, there's a sharpening dropdown. If I select None as the sharpening value, the next screen (the Save screen) lists the sharpening as Soft.

It also does this when I set the sharpening to Strong. I haven't checked the others (Medium, Hard etc)

ProcessWire: 3.0.119
CroppableImage3: Latest
 

Share this post


Link to post
Share on other sites

@horst How can I add a current timestamp at the end of the suffix everytime a crop is saved? With @adrian's module ProcessCustomUploadNames it renames all image variations so I'm wondering if it's possible to only rename the variations with the suffix we're having in Crop Settings:

So instead of:

my_image.jpg
my_image.-suffix.jpg

We should have something like this:

my_image.jpg
my_image.-suffix-1543078585.jpg

Share this post


Link to post
Share on other sites

Replacing the 221 line of ProcessCroppableImage3.module with this:

$basename = basename($img->basename, '.' . $img->ext) . '.-' . strtolower($suffix) . '-' . $img->mtime . '.' . $img->ext;

and the 224 line of FieldtypeCroppableImage3.module with this:

$basename = basename($img->basename, '.' . $img->ext) . ".-$suffix" . '-' . $img->mtime . "." . $img->ext;

it adds the current timestamp everytime the cropped has changed but the problem is that variations with previous timestamps are not deleted. @horst can you please help?

Share this post


Link to post
Share on other sites
On 11/22/2018 at 6:08 PM, Peter Knight said:

Hi Horst

Possible bug...

When I'm in the popup window which displays the crop preview, there's a sharpening dropdown. If I select None as the sharpening value, the next screen (the Save screen) lists the sharpening as Soft.

It also does this when I set the sharpening to Strong. I haven't checked the others (Medium, Hard etc)

ProcessWire: 3.0.119
CroppableImage3: Latest
 

@Peter Knight, please can you try the following fix manually on your side?

In the file site/modules/CroppableImage3/ProcessCroppableImage3/ProcessCroppableImage3.module on the lines 234 & 235 you must remove the wrapping isset(...) on each first checked param per line!

This

233            // get quality & sharpening from post, sanitize and validate it
234            $quality = isset($this->input->post->quality) && is_numeric($this->input->post->quality) && 0<intval($this->input->post->quality) && 101>intval($this->input->post->quality) ? intval($this->input->post->quality) : $options['quality'];
235            $sharpening = isset($this->input->post->sharpening) && ImageSizer::sharpeningValueStr($this->input->post->sharpening)==$this->input->post->sharpening ? $this->input->post->sharpening : $options['sharpening'];

should become this:

233            // get quality & sharpening from post, sanitize and validate it
234            $quality = $this->input->post->quality && is_numeric($this->input->post->quality) && 0 < intval($this->input->post->quality) && 101 > intval($this->input->post->quality) ? intval($this->input->post->quality) : $options['quality'];
235            $sharpening = $this->input->post->sharpening && ImageSizer::sharpeningValueStr($this->input->post->sharpening)==$this->input->post->sharpening ? $this->input->post->sharpening : $options['sharpening'];

 

If it fixes it on your side too, I will release a new version of the module.

  • Like 1

Share this post


Link to post
Share on other sites
5 hours ago, PWaddict said:

t adds the current timestamp everytime the cropped has changed but the problem is that variations with previous timestamps are not deleted. @horst can you please help?

Sorry @PWaddict, I only can support standard-conform variation names. But I'm wondering why you need to hack the code.

I don't know what the custom upload names module does, but if it does something like striping complete variation names including suffixes, I have no option to help.

Share this post


Link to post
Share on other sites
1 hour ago, horst said:

Sorry @PWaddict, I only can support standard-conform variation names. But I'm wondering why you need to hack the code.

I don't know what the custom upload names module does, but if it does something like striping complete variation names including suffixes, I have no option to help.

The reason I want to add timestamps in the cropped variations is because I'm also using them as og:image and Facebook will not refresh the image if I changed the crop unless the filename or page url are renamed. So, adding timestamps inside filename is the perfect solution for this.

@adrian's module renames all image variations (normal & cropped ones) and It doesn't affect CroppableImage3's suffixes.

Share this post


Link to post
Share on other sites
1 hour ago, PWaddict said:

@adrian's module renames all image variations (normal & cropped ones) and It doesn't affect CroppableImage3's suffixes.

Couldn't CustumUploadNames be modified to handle this need?

Share this post


Link to post
Share on other sites
11 minutes ago, adrian said:

Couldn't CustumUploadNames be modified to handle this need?

I don't know. I tried to modified CroppableImage3 because it seems easier since it only renames the cropped variations.

Share this post


Link to post
Share on other sites

Croppableimage does not use own suffixes. It uses pw cores default image variation suffixes. 

Can you not simply add the timestamp via the options array?

Or what is the part that I do not understand?

Maybe you can give me a variation name as example, show what custom upload names do with it, and what cai3 does. 

Also please tell me when the modules affect the variation names, in which order. 

Share this post


Link to post
Share on other sites
8 hours ago, horst said:

@Peter Knight, please can you try the following fix manually on your side?

In the file site/modules/CroppableImage3/ProcessCroppableImage3/ProcessCroppableImage3.module on the lines 234 & 235 you must remove the wrapping isset(...) on each first checked param per line!

 

Thanks @horst
that worked. 

When I set sharpening to none, it was reflected on the final save window.

I'm still getting a slight pixelation on the source jpg but it's probably non Module related. It's hardly noticeable but would be keen to hear if you think it could be.

 

  • Like 1

Share this post


Link to post
Share on other sites

@Peter Knight, thanks for testing. 

With php 5.x versions it works using isset(). With php 7.x versions it doesn't work anymore. 

About the pixelation, it also may have to do with the scaling factor. Also, if possible, you may compare gd and imagick engines. 

Share this post


Link to post
Share on other sites
18 hours ago, horst said:

Can you not simply add the timestamp via the options array?

Can you show me an example how can I do that? On Crop Settings I have "thumbnail,1200,600" so the main variation image is like myimage.-thumbnail.jpg. How can I rename it to myimage.-thumbnail-1543078585.jpg with the options array?

Share this post


Link to post
Share on other sites

Using the options array it creates another variation file with the manual suffix I mention below. It doesn't rename the main variation image.

$og_image->getCrop('thumbnail', "width=1200, suffix=test")->httpUrl;

 

Share this post


Link to post
Share on other sites

@PWaddict

I may seem a little impatient now, but I still don't understand what you want after all your posts. Please just write down 2 or three variation names where I can see what is and what should be. Otherwise I cannot deal with it any further. (I have three deadlines this week!)

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Robin S
      Another little admin helper module...
      Template Field Widths
      Adds a "Field widths" field to Edit Template that allows you to quickly set the widths of inputfields in the template.

      Why?
      When setting up a new template or trying out different field layouts I find it a bit slow and tedious to have to open each field individually in a modal just to set the width. This module speeds up the process.
      Installation
      Install the Template Field Widths module.
      Config options
      You can set the default presentation of the "Field widths" field to collapsed or open. Field widths entered into the Template Field Widths inputfield are only applied if the Edit Template form is submitted with the Template Field Widths inputfield in an opened state. "Collapsed" is the recommended setting if you think you might also use core inputs for setting field widths in a template context. You can choose Name or Label as the primary identifier shown for the field. The unchosen alternative will become the title attribute shown on hover. You can choose to show the original field width next to the template context field width.  
      https://github.com/Toutouwai/TemplateFieldWidths
      https://modules.processwire.com/modules/template-field-widths/
    • By adrian
      Tracy Debugger for ProcessWire
      The ultimate “swiss army knife” debugging and development tool for the ProcessWire CMF/CMS

       
      Integrates and extends Nette's Tracy debugging tool and adds 35+ custom tools designed for effective ProcessWire debugging and lightning fast development
      The most comprehensive set of instructions and examples is available at: https://adrianbj.github.io/TracyDebugger
      Modules Directory: http://modules.processwire.com/modules/tracy-debugger/
      Github: https://github.com/adrianbj/TracyDebugger
      A big thanks to @tpr for introducing me to Tracy and for the idea for this module and for significant feedback, testing, and feature suggestions.
    • By adrian
      This module allows you to automatically rename file (including image) uploads according to a configurable format
      This module lets you define as many rules as you need to determine how uploaded files will be named and you can have different rules for different pages, templates, fields, and file extensions, or one rule for all uploads. Renaming works for files uploaded via the admin interface and also via the API, including images added from remote URLs.   Github: https://github.com/adrianbj/CustomUploadNames
      Modules Directory: http://modules.processwire.com/modules/process-custom-upload-names/
      Renaming Rules
      The module config allows you to set an unlimited number of Rename Rules. You can define rules to specific fields, templates, pages, and file extensions. If a rule option is left blank, the rule with be applied to all fields/templates/pages/extensions. Leave Filename Format blank to prevent renaming for a specific field/template/page combo, overriding a more general rule. Rules are processed in order, so put more specific rules before more general ones. You can drag to change the order of rules as needed. The following variables can be used in the filename format: $page, $template, $field, and $file. For some of these (eg. $field->description), if they haven't been filled out and saved prior to uploading the image, renaming won't occur on upload, but will happen on page save (could be an issue if image has already been inserted into RTE/HTML field before page save). Some examples: $page->title mysite-{$template->name}-images $field->label $file->description {$page->name}-{$file->filesize}-kb prefix-[Y-m-d_H-i-s]-suffix (anything inside square brackets is is considered to be a PHP date format for the current date/time) randstring[n] (where n is the number of characters you want in the string) ### (custom number mask, eg. 001 if more than one image with same name on a page. This is an enhanced version of the automatic addition of numbers if required) If 'Rename on Save' is checked files will be renamed again each time a page is saved (admin or front-end via API). WARNING: this setting will break any direct links to the old filename, which is particularly relevant for images inserted into RTE/HTML fields. The Filename Format can be defined using plain text and PW $page variable, for example: mysite-{$page->path} You can preserve the uploaded filename for certain rules. This will allow you to set a general renaming rule for your entire site, but then add a rule for a specific page/template/field that does not rename the uploaded file. Just simply build the rule, but leave the Filename Format field empty. You can specify an optional character limit (to nearest whole word) for the length of the filename - useful if you are using $page->path, $path->name etc and have very long page names - eg. news articles, publication titles etc. NOTE - if you are using ProcessWire's webp features, be sure to use the useSrcExt because if you have jpg and png files on the same page and your rename rules result in the same name, you need to maintain the src extension so they are kept as separate files.
      $config->webpOptions = array(     'useSrcExt' => false, // Use source file extension in webp filename? (file.jpg.webp rather than file.webp) ); Acknowledgments
      The module config settings make use of code from Pete's EmailToPage module and the renaming function is based on this code from Ryan: http://processwire.com/talk/topic/3299-ability-to-define-convention-for-image-and-file-upload-names/?p=32623 (also see this post for his thoughts on file renaming and why it is the lazy way out - worth a read before deciding to use this module). 
       
       
      NOTE:
      This should not be needed on most sites, but I work with lots of sites that host PDFs and photos/vectors that are available for download and I have always renamed the files on upload because clients will often upload files with horrible meaningless filenames like:
      Final ReportV6 web version for John Feb 23.PDF

×
×
  • Create New...