Jump to content
horst

Croppable Image 3

Recommended Posts

I don't understand. Please can you clarify, maybe with a short explanation, what you want to do?

Share this post


Link to post
Share on other sites

Yes of course.

When the module is cropping an image, a variation image is created in /assets/files/id by CroppableImage3Helpers::renderImage method. I want to hook to the method like this to have treatments on the newly created image. Right now it is not hookable. My use case is to upload the image to AWS S3 if I want to make a stateless webserver. I have made the same request to processwire-request for your information.

I think there can be more use cases. One of them always on my mind is generating a small placeholder image for lazy loading.

Share this post


Link to post
Share on other sites

I think you don't need to hook into this module. You need to hook into Pageimage, doing the following:

  • check if the requested variation is available on your AWS S3 remote storage,
  • and if yes, just link to it,
  • and if no, create a new one, upload it and finally link to it.

This is independent from the different ImageRenderingEngines and extra modules.

EDIT:

Have you seen this:

 

Share this post


Link to post
Share on other sites

Thanks for your suggestion.

I have tried what you have suggested before. The problem of this approach is that checking remote asset availability needs an extra round trip and that increases the page loading time a lot. If there are many images in a page, every PageImage call would have to check if the remote image is available or not. This is not feasible. Please correct me if I am wrong.

I think of a workaround for handling this module. As page editor will save the page, most likely, after adding new crop, I can hook to page save to sync with AWS S3, although the module does not require hitting save to make changes.

Share this post


Link to post
Share on other sites

What is the primary benefit for hosting images in the S3 cloud?

Or the other way round: do you need to save diskspace on your local server?

Share this post


Link to post
Share on other sites

For webapp and e-commerce shops, high availability is critical. To achieve this, one of the approaches is using multiple stateless web servers running in parallel, by keeping all assets and database away from the web servers. In this way, we can add or remove as many web server as we need. Assets can be kept safe and synchronized across all web servers.

I use AWS's Elastic Beanstalk to achieve this infrastructure. The ec2 servers controlled by Elastic Beanstalk will be terminated and rebuilt from time to time, so stateless servers are needed to use this kind of service or infrastructure.

  • Like 2

Share this post


Link to post
Share on other sites
48 minutes ago, horst said:

Have you seen this:

Yes. I have tried this module. It is working great with normal file, but using this would lose the image inputfiled editor, and the feature of Croppable Image 3, which I am using in my every project.😭

Share this post


Link to post
Share on other sites

I've never dealt with AWS, and although I'm sure you've searched around, I found some forum threads dealing with similar issues.

https://processwire.com/blog/posts/amazon-aws-now-powering-processwire.com-sites/

^ nothing specific about image-cropping (or images in general), but maybe @ryan has built something which would help you find a solution?

(don't want to pollute this thread, just thinking maybe you'll find some hints or code-snippets...)

Share this post


Link to post
Share on other sites

Thanks @dragan. I don't want to off topic much too. I am actually forking the module you mentioned to make it a more robust one. I would share the module once it is completed. It will be working silently and seamlessly with other modules. As Croppable Image 3 is my must use module, I just seek any chance that I can make the integration better.😅(trying to relate Croppable Image 3 more)

Share this post


Link to post
Share on other sites

Hhm, so you will have one or multiple webservers with different states of variations, but only the AWS S3 cloud is always containing everything.

What's about your own idea, hooking into $page->save():

  • check if imagefield(s) exist in that edited page
  • if yes, compare all image and variation timestamps and upload those from within the last x minutes.

This way, you are completly free to use what ever image tools you like.

  • Like 1

Share this post


Link to post
Share on other sites

Hi Horst

Possible bug...

When I'm in the popup window which displays the crop preview, there's a sharpening dropdown. If I select None as the sharpening value, the next screen (the Save screen) lists the sharpening as Soft.

It also does this when I set the sharpening to Strong. I haven't checked the others (Medium, Hard etc)

ProcessWire: 3.0.119
CroppableImage3: Latest
 

Share this post


Link to post
Share on other sites

@horst How can I add a current timestamp at the end of the suffix everytime a crop is saved? With @adrian's module ProcessCustomUploadNames it renames all image variations so I'm wondering if it's possible to only rename the variations with the suffix we're having in Crop Settings:

So instead of:

my_image.jpg
my_image.-suffix.jpg

We should have something like this:

my_image.jpg
my_image.-suffix-1543078585.jpg

Share this post


Link to post
Share on other sites

Replacing the 221 line of ProcessCroppableImage3.module with this:

$basename = basename($img->basename, '.' . $img->ext) . '.-' . strtolower($suffix) . '-' . $img->mtime . '.' . $img->ext;

and the 224 line of FieldtypeCroppableImage3.module with this:

$basename = basename($img->basename, '.' . $img->ext) . ".-$suffix" . '-' . $img->mtime . "." . $img->ext;

it adds the current timestamp everytime the cropped has changed but the problem is that variations with previous timestamps are not deleted. @horst can you please help?

Share this post


Link to post
Share on other sites
On 11/22/2018 at 6:08 PM, Peter Knight said:

Hi Horst

Possible bug...

When I'm in the popup window which displays the crop preview, there's a sharpening dropdown. If I select None as the sharpening value, the next screen (the Save screen) lists the sharpening as Soft.

It also does this when I set the sharpening to Strong. I haven't checked the others (Medium, Hard etc)

ProcessWire: 3.0.119
CroppableImage3: Latest
 

@Peter Knight, please can you try the following fix manually on your side?

In the file site/modules/CroppableImage3/ProcessCroppableImage3/ProcessCroppableImage3.module on the lines 234 & 235 you must remove the wrapping isset(...) on each first checked param per line!

This

233            // get quality & sharpening from post, sanitize and validate it
234            $quality = isset($this->input->post->quality) && is_numeric($this->input->post->quality) && 0<intval($this->input->post->quality) && 101>intval($this->input->post->quality) ? intval($this->input->post->quality) : $options['quality'];
235            $sharpening = isset($this->input->post->sharpening) && ImageSizer::sharpeningValueStr($this->input->post->sharpening)==$this->input->post->sharpening ? $this->input->post->sharpening : $options['sharpening'];

should become this:

233            // get quality & sharpening from post, sanitize and validate it
234            $quality = $this->input->post->quality && is_numeric($this->input->post->quality) && 0 < intval($this->input->post->quality) && 101 > intval($this->input->post->quality) ? intval($this->input->post->quality) : $options['quality'];
235            $sharpening = $this->input->post->sharpening && ImageSizer::sharpeningValueStr($this->input->post->sharpening)==$this->input->post->sharpening ? $this->input->post->sharpening : $options['sharpening'];

 

If it fixes it on your side too, I will release a new version of the module.

  • Like 1

Share this post


Link to post
Share on other sites
5 hours ago, PWaddict said:

t adds the current timestamp everytime the cropped has changed but the problem is that variations with previous timestamps are not deleted. @horst can you please help?

Sorry @PWaddict, I only can support standard-conform variation names. But I'm wondering why you need to hack the code.

I don't know what the custom upload names module does, but if it does something like striping complete variation names including suffixes, I have no option to help.

Share this post


Link to post
Share on other sites
1 hour ago, horst said:

Sorry @PWaddict, I only can support standard-conform variation names. But I'm wondering why you need to hack the code.

I don't know what the custom upload names module does, but if it does something like striping complete variation names including suffixes, I have no option to help.

The reason I want to add timestamps in the cropped variations is because I'm also using them as og:image and Facebook will not refresh the image if I changed the crop unless the filename or page url are renamed. So, adding timestamps inside filename is the perfect solution for this.

@adrian's module renames all image variations (normal & cropped ones) and It doesn't affect CroppableImage3's suffixes.

Share this post


Link to post
Share on other sites
1 hour ago, PWaddict said:

@adrian's module renames all image variations (normal & cropped ones) and It doesn't affect CroppableImage3's suffixes.

Couldn't CustumUploadNames be modified to handle this need?

Share this post


Link to post
Share on other sites
11 minutes ago, adrian said:

Couldn't CustumUploadNames be modified to handle this need?

I don't know. I tried to modified CroppableImage3 because it seems easier since it only renames the cropped variations.

Share this post


Link to post
Share on other sites

Croppableimage does not use own suffixes. It uses pw cores default image variation suffixes. 

Can you not simply add the timestamp via the options array?

Or what is the part that I do not understand?

Maybe you can give me a variation name as example, show what custom upload names do with it, and what cai3 does. 

Also please tell me when the modules affect the variation names, in which order. 

Share this post


Link to post
Share on other sites
8 hours ago, horst said:

@Peter Knight, please can you try the following fix manually on your side?

In the file site/modules/CroppableImage3/ProcessCroppableImage3/ProcessCroppableImage3.module on the lines 234 & 235 you must remove the wrapping isset(...) on each first checked param per line!

 

Thanks @horst
that worked. 

When I set sharpening to none, it was reflected on the final save window.

I'm still getting a slight pixelation on the source jpg but it's probably non Module related. It's hardly noticeable but would be keen to hear if you think it could be.

 

  • Like 1

Share this post


Link to post
Share on other sites

@Peter Knight, thanks for testing. 

With php 5.x versions it works using isset(). With php 7.x versions it doesn't work anymore. 

About the pixelation, it also may have to do with the scaling factor. Also, if possible, you may compare gd and imagick engines. 

Share this post


Link to post
Share on other sites
18 hours ago, horst said:

Can you not simply add the timestamp via the options array?

Can you show me an example how can I do that? On Crop Settings I have "thumbnail,1200,600" so the main variation image is like myimage.-thumbnail.jpg. How can I rename it to myimage.-thumbnail-1543078585.jpg with the options array?

Share this post


Link to post
Share on other sites

Using the options array it creates another variation file with the manual suffix I mention below. It doesn't rename the main variation image.

$og_image->getCrop('thumbnail', "width=1200, suffix=test")->httpUrl;

 

Share this post


Link to post
Share on other sites

@PWaddict

I may seem a little impatient now, but I still don't understand what you want after all your posts. Please just write down 2 or three variation names where I can see what is and what should be. Otherwise I cannot deal with it any further. (I have three deadlines this week!)

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By MoritzLost
      This is a new module that provides a simple solution to clearing all your cache layers at once, and an extensible interface to perform various cache-related actions.
      The simple motivation behind this module was that I was tired of manually clearing caches in several places after deploying a change on a live site. The basic purpose of this module is a simple Clear all caches link in the Setup menu which clears out all caches, no matter where they hide. You can customize what exactly the module does through it's configuration menu:
      Expire or delete all cache entries in the database, or selectively clear caches by namespace ($cache API) Clear the the template render cache. Clear out specific folders inside your site's cache directory (/site/assets/cache) Refresh version strings for static assets to bust client-side browser caches (this requires some setup, see the full documentation for details). This is the basic function of the module. However, you can also add different cache management action through the API and execute them through the module's interface. For this advanced usage, the module provides:
      An interface to see all available cache actions and execute them. A system log and logging output on the module page to see verify what the module is doing. A CacheControlTools class with utility functions to clear out different caches. An API to add cache actions, execute them programmatically and even modify the default action. Permission management, allowing you granular control over which user roles can execute which actions. The complete documentation can be found in the module's README.
      Beta release
      Note that I consider this a Beta release. Since the module is relatively aggressive in deleting some caches, I would advise you to install in on a test environment before using it on a live site.
      Let me know if you're getting any errors, have trouble using the module or if you have suggestions for improvement!
      In particular, can someone let me know if this module causes any problems with the ProCache module? I don't own or use it, so I can't check. As far as I can tell, ProCache uses a folder inside the cache directory to cache static pages, so my module should be able to clear the ProCache site cache as well, I'd appreciate it if someone can test that for me.
      Future plans
      If there is some interest in this, I plan to expand this to a more general cache management solution. I particular, I would like to add additional cache actions. Some ideas that came to mind:
      Warming up the template render cache for publicly accessible pages. Removing all active user sessions. Let me know if you have more suggestions!
      Links
      https://github.com/MoritzLost/ProcessCacheControl ProcessCacheControl in the Module directory

    • By joshua
      This module is (yet another) way for implementing a cookie management solution.
      Of course there are several other possibilities:
      - https://processwire.com/talk/topic/22920-klaro-cookie-consent-manager/
      - https://github.com/webmanufaktur/CookieManagementBanner
      - https://github.com/johannesdachsel/cookiemonster
      - https://www.oiljs.org/
      - ... and so on ...
      In this module you can configure which kind of cookie categories you want to manage:

      You can also enable the support for respecting the Do-Not-Track (DNT) header to don't annoy users, who already decided for all their browsing experience.
      Currently there are four possible cookie groups:
      - Necessary (always enabled)
      - Statistics
      - Marketing
      - External Media
      All groups can be renamed, so feel free to use other cookie group names. I just haven't found a way to implement a "repeater like" field as configurable module field ...
      When you want to load specific scripts ( like Google Analytics, Google Maps, ...) only after the user's content to this specific category of cookies, just use the following script syntax:
      <script type="optin" data-type="text/javascript" data-category="statistics" data-src="/path/to/your/statistic/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing" data-src="/path/to/your/mareketing/script.js"></script> <script type="optin" data-type="text/javascript" data-category="external_media" data-src="/path/to/your/external-media/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing">console.log("Inline scripts are also working!");</script> The type has to be "optin" to get recognized by PrivacyWire, the data-attributes are giving hints, how the script shall be loaded, if the data-category is within the cookie consents of the user. These scripts are loaded asynchronously after the user made the decision.
      If you want to give the users the possibility to change their consent, you can use the following Textformatter:
      [[privacywire-choose-cookies]] It's planned to add also other Textformatters to opt-out of specific cookie groups or delete the whole consent cookie.
      You can also add a custom link to output the banner again with a link / button with following class:
      <a href="#" class="privacywire-show-options">Show Cookie Options</a> <button class="privacywire-show-options">Show Cookie Options</button> This module is still in development, but we already use it on several production websites.
      You find it here: https://github.com/blaueQuelle/privacywire/tree/master
      Download: https://github.com/blaueQuelle/privacywire/archive/master.zip
      I would love to hear your feedback 🙂
      Edit: Updated URLs to master tree of git repo
       
    • By David Karich
      Admin Page Tree Multiple Sorting
      ClassName: ProcessPageListMultipleSorting
      Extend the ordinary sort of children of a template in the admin page tree with multiple properties. For each template, you can define your own rule. Write each template (template-name) in a row, followed by a colon and then the additional field names for sorting.
      Example: All children of the template "blog" to be sorted in descending order according to the date of creation, then descending by modification date, and then by title. Type:
      blog: -created, -modified, title  Installation
      Copy the files for this module to /site/modules/ProcessPageListMultipleSorting/ In admin: Modules > Check for new modules. Install Module "Admin Page Tree Multible Sorting". Alternative in ProcessWire 2.4+
      Login to ProcessWire backend and go to Modules Click tab "New" and enter Module Class Name: "ProcessPageListMultipleSorting" Click "Download and Install"   Compatibility   I have currently tested the module only under PW 2.6+, but think that it works on older versions too. Maybe someone can give a feedback.     Download   PW-Repo: http://modules.processwire.com/modules/process-page-list-multiple-sorting/ GitHub: https://github.com/FlipZoomMedia/Processwire-ProcessPageListMultipleSorting     I hope someone can use the module. Have fun and best regards, David
    • By dimitrios
      Hello,
      this module can publish content of a Processwire page on a Facebook page, triggered by saving the Processwire page.
      To set it up, configure the module with a Facebook app ID, secret and a Page ID. Following is additional configuration on Facebook for developers:
      Minimum Required Facebook App configuration:
      on Settings -> Basics, provide the App Domains, provide the Site URL, on Settings -> Advanced, set the API version (has been tested up to v3.3), add Product: Facebook Login, on Facebook Login -> Settings, set Client OAuth Login: Yes, set Web OAuth Login: Yes, set Enforce HTTPS: Yes, add "https://www.example.com/processwire/page/" to field Valid OAuth Redirect URIs. This module is configurable as follows:
      Templates: posts can take place only for pages with the defined templates. On/Off switch: specify a checkbox field that will not allow the post if checked. Specify a message and/or an image for the post.
      Usage
      edit the desired PW page and save; it will post right after the initial Facebook log in and permission granting. After that, an access token is kept.
       
      Download
      PW module directory: http://modules.processwire.com/modules/auto-fb-post/ Github: https://github.com/kastrind/AutoFbPost   Note: Facebook SDK for PHP is utilized.


×
×
  • Create New...