tpr

AdminOnSteroids

Recommended Posts

Great thanks for this. Efficiency boost a lot!

I have tried a bit to solve the jump and search value removal after selecting. I have changed aos.js(around line 1411) to below. It seems working good for single instance.

var selectScrollTop,searchText;

// this selecting save the scroll position and search value
$(document).on('select2:selecting', '.asmSelect', function (event) {
    selectScrollTop = $(".select2-results__options").scrollTop();
    searchText = $(".select2-search__field").val();

});

$(document).on('select2:select', '.asmSelect', function (event) {
    var $asmSelect = $(this),
        src = event.target || event.srcElement;

    if (src.tagName === 'SELECT') {

        // var inputSelector = '.select2-search__field',
        //     searchTermAttr = 'data-select2-search-term',
        //     searchTerm = $(inputSelector).val();

        // save search term in parent's data attr
        // $asmSelect.parent().attr(searchTermAttr, searchTerm);

        // change and rebuild + reopen
        $asmSelect.val(null).trigger('change.select2');
        $asmSelect.select2('destroy');

        if ($asmSelect.parent().find('[data-asm-placeholder]').length) {
            select2Config.placeholder = $asmSelect.parent().find('[data-asm-placeholder]').attr('data-asm-placeholder');
        }

        $asmSelect.select2(select2Config);
        $asmSelect.select2('open');
        // the below 2 lines are added to restore the scroll position and search result
        $(".select2-search__field").val(searchText).trigger('keyup').trigger('input');
        $(".select2-results__options").scrollTop(selectScrollTop);
        // restore previous search term
        // $(inputSelector).val($asmSelect.parent().attr(searchTermAttr));
        // $(inputSelector).trigger('keyup').select();
    }
});

Edit: I overlooked. You have already made the search term restoration but you have commented them. Any considerations for this?

  • Like 3

Share this post


Link to post
Share on other sites

That's because I wasn't sure that search term restoration is beneficial after trying it. When it's restored, you have to delete it to search for something else. For me this caused more typing because it's very rare that I will add consecutive items starting with the same string. But feel free to prove the opposite, perhaps it's just my own scenario. 

Share this post


Link to post
Share on other sites

It really depends. User like me use prefix on field name would benefit from keeping the search term. The reason why I prefix fields is to distinguish what inputfield the field are using. For page reference field for product I name it page_product, so I can quickly spot the field when I search "product" or "page". I also believe many developers here like you do not use prefix a lot too. It seems like no perfect solution here unless everyone name and use fields in the same way. The best way might be that the keeping search term and scroll position could be toggle on/off. Anyway, they are relatively minor, the search function is already a great efficiency boost for me and also saves me from future client's complaints.:lol:

  • Like 2

Share this post


Link to post
Share on other sites
13 minutes ago, Karl_T said:

The best way might be that the keeping search term and scroll position could be toggle on/off.

I can make them configurable. As for the scroll position I will try your fix and also try something else. 

  • Like 2
  • Thanks 1

Share this post


Link to post
Share on other sites
13 hours ago, tpr said:

and also try something else

Ok, that thing wasn't that successful so @Karl_T's workaround was kept to keep the scroll position, thanks! Works quite well now, that was the missing piece to the cake :)

I haven't made keeping the scroll position optional but did that for the searched term.

  • Like 4

Share this post


Link to post
Share on other sites

Minor update: instead of higlighting the searched term now the cursor is moved to the end of the text in the asmSelect search box. Re-download aos.min.js if you have already updated the module to 1.7.8 as version number haven't changed.

  • Like 1

Share this post


Link to post
Share on other sites

The searchable AsmSelect feature is cool!

Just wanted to add: ajax-loaded inputfields (via inputfield visibility setting or repeater item setting) trigger a "reloaded" event on the inputfield to signal when the field is loaded. So you could use this instead of the requestAnimationFrame trick if you want. See InputfieldAsmSelect.js for an example of how this event can be used.

$(document).on('reloaded', '.InputfieldAsmSelect, .InputfieldPage', function() {
  console.log('The AsmSelect inputfield was ajax-loaded');
});

 

  • Like 2

Share this post


Link to post
Share on other sites

Thanks but this case this signals that the field is ready, but select2.js needs asmSelect to be ready too. I used a 700ms setTimeout to fix (using the reloaded event) but that was less reliable and much slower too. In fact it may work now that I modified my stuff a lot but I think requestanimationframe works just fine, no need to swap out. 

  • Like 3

Share this post


Link to post
Share on other sites

Just wanted to say how great all these new ASM tweaks are - thanks @tpr and @Karl_T

  • Like 5

Share this post


Link to post
Share on other sites

Looks like a bug in the new ASM tweaks.

It's fine if at least one item is selected:

image.png.eb4164a57de5aa6fc4b4b061937b9ceb.png

 

But. if you remove the selection in the first ASM, then the field is broken:

image.png.298e5804fd7ef55f1fdaf085d1597fee.png

Here is the js error:

Uncaught TypeError: Cannot read property 'length' of null
    at HTMLSelectElement.<anonymous> (aos.min.js?ts=1.7.8_2018030213:1)
    at Function.each (JqueryCore.js?v=1519661844:2)
    at init.each (JqueryCore.js?v=1519661844:2)
    at HTMLDocument.<anonymous> (aos.min.js?ts=1.7.8_2018030213:1)
    at l (JqueryCore.js?v=1519661844:2)
    at Object.fireWith [as resolveWith] (JqueryCore.js?v=1519661844:2)
    at Function.ready (JqueryCore.js?v=1519661844:2)
    at HTMLDocument.A (JqueryCore.js?v=1519661844:2)

 

  • Like 2

Share this post


Link to post
Share on other sites

Thanks, but fortunately this one was totally unrelated. It was the case changer in AOS, in the MarkupSEO module the "Inputfield_titleSmart" named field triggered the case changer beause a selector was written like "[id^="Inputfield_title"]. I've also fixed a CSS positioning issue for the case changer. Check 1.7.9 for the fix.

(offtopic)

I got a js error if I remove all the selectors in the MarkupSEO settings, like you did in your second screenshot, on a regular page edit screen:

Uncaught Error: Syntax error, unrecognized expression: ,input[name=seo_title]

In MarkupSEO.php it seems this line assumes there's at least one field selected:

$('{$titleFieldsSelectors},input[name=seo_title]').keyup(function(){

This fixes it:

$('{$titleFieldsSelectors}').add('input[name=seo_title]').keyup(function(){

Could you check this? I'll add the fix to the MarkupSEO github if you (or someone) could confirm this.

  • Like 1

Share this post


Link to post
Share on other sites

Weird - I am not seeing that error in the SEO module after upgrading AOS. I am going to be doing some major enhancements to the SEO module shortly so I'll investigate more as I go along.

Thanks for the case changer fix though!

  • Like 1

Share this post


Link to post
Share on other sites
6 hours ago, adrian said:

in the SEO module

I meant a regular page edit screen, eg editing the Home page. 

6 hours ago, adrian said:

am going to be doing some major enhancements to the SEO module

Sounds great, looking forward to it! 

  • Like 2

Share this post


Link to post
Share on other sites

One question regarding the ASM tweaks - I would like there to be an option to lose focus on the search box after choosing an option. At the moment you need to hit ESC or click off to see the selection. I understand that if you are making lots of selections the current behavior is more efficient, but I think some site editors might be confused. Or maybe I am overthinking it? Any thoughts?

  • Like 1

Share this post


Link to post
Share on other sites

I'll make optional to keep the list open. 

  • Like 2

Share this post


Link to post
Share on other sites

Just made it optional in v1.8.0.

Also the built-in asmSelect placeholder is now kept when asmSearchbox is enabled, eg. the fieldselector on editing a template now retains the placeholder value after adding a field.

  • Like 3

Share this post


Link to post
Share on other sites

I just got a notice whenever I go to the module section:

Quote

Notice: Trying to get property of non-object in /project/site/assets/cache/FileCompiler/site/modules/AdminOnSteroids/AdminOnSteroids.module on line 2605
 

  • PW 3.0.85
  • Updated AOS half an hour ago.
  • Cleared site/assets/cache
  • Refreshed modules + did "clear compiled files"

The notices (the appear twice) remain...

Share this post


Link to post
Share on other sites

Thanks, interestingly I don't get any notices but I see where can it fail. Could you try disabling line 2605 with this?

if (!empty($configData['IUC_enabledTemplates']) && $editedPage->template && !in_array($editedPage->template->name

 

Share this post


Link to post
Share on other sites

@tpr, I noticed that the positioning of the button dropdown is a bit off for the Save button at the bottom of Page Edit (AOS feature "Show save dropdown on hover instead on click"). The one at the top is okay. Seems that both the Default and Uikit themes are affected.

Top button (all good):

2018-03-09_161857.png.b466fc3e994560304d3d57ab49d45549.png

Bottom button (position is off):

2018-03-09_161921.png.12cf60497df558b30184196c239c0f9e.png

Share this post


Link to post
Share on other sites

@Robin S Thanks, I'll have a look.

Input masks

continued from here

I've managed to make it work on multilanguage installs, however, PW doesn't load the non-default field's value automatically (on the field config page). It's only a matter of a few extra lines but I feel this is a bug, or perhaps I'm doing things wrong.

// $this->addHookAfter("Field(type=FieldtypeText|FieldtypeTextLanguage)::getConfigInputfields", $this, "addInputMaskConfigField");

$f = $this->wire('modules')->get("InputfieldTextarea");
$f->attr('name', "inputMask");
$f->label = $this->_("Input Mask");
$f->useLanguages = true;

// setting value here, but this doesn't set for non-default languages
$f->value = $field->inputMask;

// need to iterate on languages and set each separately
if ($this->wire('languages')) {
    foreach ($this->wire('languages') as $lang) {
        if ($lang->isDefault()) continue;
        $f->{'value' . $lang->id} = $field->{'inputMask' . $lang->id};
    }
}

See the comments in the snippet, am I missing something?

File size

Another issue is that Cleave comes with many javascript files for phone masks, one for each country, that's about 3.4 Mb altogether. This would increase AOS size a lot (about 2.5 times as now), which I don't like a lot.

Any idea how to overcome this? Should I load them via cdn? I've found bootcdn.cn only where they are available but I know nothing about that site.

Or perhaps make it somehow available through $config->inputMaskAddons or something, and devs should take care of that if needed?

  • Like 1

Share this post


Link to post
Share on other sites

Hey @tpr - just wondering if you'd had any more thoughts on my idea for a check/unceck all option for multi-checkbox fields? I am going to need some sort of solution for one of my current projects. I can hack something together if need be, but I know you'll do a better job ;)

If you don't have time, or desire for this, just let me know - thanks!

Share this post


Link to post
Share on other sites

Version 1.8.1 adds Input mask feature and the misaligned bottom save button dropdowns should also be fixed.

As for the phone country library for input masks (Cleave.js) I've added the all-in-one library which weighs about 250 Kb.
It's not loaded automatically so you'll need to check it in the module settings page if you need it.

  • Like 2

Share this post


Link to post
Share on other sites
Just now, adrian said:

just wondering if you'd had any more thoughts on my idea for a check/unceck all option for multi-checkbox fields?

Not really, only an addition to yours, that is, showing the "Check all" only on hover. But this of course would be unavailable on mobile which is not that bad imho.

  • Like 1

Share this post


Link to post
Share on other sites
2 minutes ago, tpr said:

Not really, only an addition to yours, that is, showing the "Check all" only on hover. But this of course would be unavailable on mobile which is not that bad imho.

Ok, maybe I was too subtle - by "thoughts", I meant "timeframe for implementing" :)

Honestly not being pushy, just wondering if you are interested in doing shortly, or whether I do need to set up something else. This project has lots of fields with lots of checkboxes and having them all checked will be quite a common need, so it's pretty important for the editor's experience / efficiency. 

  • Like 1

Share this post


Link to post
Share on other sites

Upgrade time! :)

  • Like 2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By OLSA
      Hello for all,
      ConfigurationForm fieldtype module is one my experiment from 2016.
      Main target to build this module was to store multiple setup and configuration values in just 1 field and avoid to use 1 db table to store just single "number of items on page", or another db table to store "layout type" etc. Thanks to JSON formatted storage this module can help you to reduce number of PW native fields in project, save DB space, and reduce number of queries at front-end.
      Install and setup:
      Download (at the bottom ), unzip and install like any other PW module (site/modules/...). Create some filed using this type of field (ConfigurationForm Fieldtype) Go to field setup Input tab and drag some subfields to container area (demo). Set "Name" and other params for subfields Save and place field to templates ("Action tab") How to use it:
      In my case, I use it to store setup and configurations values, but also for contact details, small content blocks... (eg. "widgets").
      Basic usage example:
      ConfigForm fieldtype "setup" has subfields:
      "limit", type select, option values: 5, 10, 15, 20
      "sort", type select, option values: "-date", "date",  "-sort", "sort"
      // get page children (items) $limit = isset($page->setup->limit) ? $page->setup->limit : 10; $sort = isset($page->setup->sort) ? $page->setup->sort : '-sort'; $items = $page->children("limit=$limit, sort=$sort");  
      Screenshots:


       
      Notes:
      Provide option to search inside subfields Provide multilanguage inputs for text and textarea field types Provide option for different field layout per-template basis Do not place/use field type "Button" or "File input" because it won't works. Please read README file for more details and examples Module use JSON format to store values. Text and textarea field types are multilanguage compatible, but please note that main target for this module was to store setup values and small content blocks and save DB space. Search part inside JSON is still a relatively new in MySQL (>=5.77) and that's on you how and for what to use this module.
      Thanks:
      Initial point for this fieldtype was jQuery plugin FormBuiled and thanks to Kevin Chappel for this plugin.
      In field type "link" I use javascript part from @marcostoll module and thanks to him for that part.
      Download:
      FieldtypeConfigForm.zip
      Edit: 14. August 2018. please delete/uninstall previously downloaded zip
      Regards.
         
    • By bernhard
      @Sergio asked about the pdf creation process in the showcase thread about my 360° feedback/survey tool and so I went ahead and set my little pdf helper module to public.
      Description from PW Weekly:
       
      Modules Directory: https://modules.processwire.com/modules/rock-pdf/
      Download & Docs: https://gitlab.com/baumrock/RockPdf
       
      You can combine it easily with RockReplacer: 
      See also a little showcase of the RockPdf module in this thread:
       
    • By bernhard
      WHY?
      This module was built to fill the gap between simple $pages->find() operations and complex SQL queries.
      The problem with $pages->find() is that it loads all pages into memory and that can be a problem when querying multiple thousands of pages. Even $pages->findMany() loads all pages into memory and therefore is a lot slower than regular SQL.
      The problem with SQL on the other hand is, that the queries are quite complex to build. All fields are separate tables, some repeatable fields use multiple rows for their content that belong to only one single page, you always need to check for the page status (which is not necessary on regular find() operations and therefore nobody is used to that).
      In short: It is far too much work to efficiently and easily get an array of data based on PW pages and fields and I need that a lot for my RockGrid module to build all kinds of tabular data.

      Basic Usage

       
      Docs & Download
      https://modules.processwire.com/modules/rock-finder/
      https://gitlab.com/baumrock/RockFinder/tree/master
       
      Changelog
      180810, v1.0.5, basic support for options fields 180528, v1.0.4, add custom select statement option 180516, change sql query method, bump version to 1.0.0 180515, multilang bugfix 180513, beta release <180513, preview/discussion took place here: https://processwire.com/talk/topic/18983-rocksqlfinder-highly-efficient-and-flexible-sql-finder-module/
    • By Thomas Diroll
      Hi guys I'm relatively new to PW and just finished developing a page for a client. I was able to include all necessary functionality using the core fieldtypes but now I it seems that I need to extend them with a custom one. What I need is a simple button, that copies the absolute url (frontend not PW-backend) of the page which is currently edited to the clipboard. As this feature is only needed inside a specific template, I tend to use a custom fieldtype which provides this feature. I've been looking inside the core modules code (eg. FieldtypeCheckbox.module) but I don't really get the structure of it and how its rendered to the admin page. I also didn't find a lot of tutorials covering custom fieldtypes.
      Maybe some of you could give me some tips on how to write a basic custom fieldtype that renders a button which copies the value of
      page->httpUrl() to the clipboard using JS. Thanks!
    • By bernhard
      Some of you might have followed the development of this module here: https://processwire.com/talk/topic/15524-previewdiscussion-rockdatatables/ . It is the successor of "RockDataTables" and requires RockFinder to get the data for the grid easily and efficiently. It uses the open source part of agGrid for grid rendering.
       
      WHY?
      ProcessWire is awesome for creating all kinds of custom backend applications, but where it is not so awesome in my opinion is when it comes to listing this data. Of course we have the built in page lister and we have ListerPro, but none of that solutions is capable of properly displaying large amounts of data, for example lists of revenues, aggregations, quick and easy sorts by the user, instant filter and those kind of features. RockGrid to the rescue 😉 
       
      Features/Highlights:
      100k+ rows Instant (client side) filter, search, sort (different sort based on data type, eg "lower/greater than" for numbers, "contains" for strings) extendable via plugins (available plugins at the moment: fullscreen, csv export, reload, batch-processing of data, column sum/statistics, row selection) all the agGrid features (cell renderers, cell styling, pagination, column grouping etc) vanilla javascript, backend and frontend support (though not all plugins are working on the frontend yet and I don't plan to support it as long as I don't need it myself)  
      Limitations:
      While there is an option to retrieve data via AJAX the actual processing of the grid (displaying, filtering, sorting) is done on the client side, meaning that you can get into troubles when handling really large datasets of several thousands of rows. agGrid should be one of the most performant grid options in the world (see the official example page with a 100k row example) and does a lot to prevent problems (such as virtual row rendering), but you should always have this limitation in mind as this is a major difference to the available lister options that do not have this limitation.
      Currently it only supports AdminThemeUikit and I don't plan to support any other admin theme.
       
      Download: https://gitlab.com/baumrock/RockGrid
      Installation: https://gitlab.com/baumrock/RockGrid/wikis/Installation
      Quikckstart: https://gitlab.com/baumrock/RockGrid/wikis/quickstart
      Further instructions: https://gitlab.com/baumrock/RockGrid/wikis/quickstart#further-instructions
       
      Module status: alpha, License: MIT
      Note that every installation and uninstallation sends an anonymous google analytics event to my google analytics account. If you don't want that feel free to remove the appropriate lines of code before installation/uninstallation.
       
      Contribute:
      You can contribute to the development of this and other modules or just say thank you by
      testing, reporting issues and making PRs at gitlab liking this post buying me a drink: paypal.me/baumrock/5 liking my facebook page: facebook.com/baumrock hiring me for pw work: baumrock.com  
      Support: Please note that this module might not be as easy and plug&play as many other modules. It needs a good understanding of agGrid (and JavaScript in general) and it likely needs some looks into the code to get all the options. Please understand that I can not provide free support for every request here in the forum. I try to answer all questions that might also help others or that might improve the module but for individual requests I offer paid support for 60€ per hour.
       
      Changelog
      180730 support subdir installations 180711 bugfix (naming issue) 180630 alpha realease  
      Use Cases / Examples:
      Colored grid cells, Icons, Links etc. The Grid also has a "batcher" feature built in that helps communicating with the server via AJAX and managing resource intensive tasks in batches:

      Filters, PW panel links and instant reload on panel close:

      You can combine the grid with a chart library like I did with the (outdated) RockDataTables module: