tpr

AdminOnSteroids

Recommended Posts

4 hours ago, houseofdeadleg said:

Error: Using $this when not in object context

I cannot reproduce, sorry. Any further information on this?

Share this post


Link to post
Share on other sites

The custom CKE toolbars per role feature starts to get shape (continued from here).

I decided not to use roles but selectors instead for more flexibility (restrict by user role, name, email, etc).
There is also a field "filter" to restrict customizations to certain fields.

The biggest issue was figuring out how one could enter these infos in the admin. A full-fledged click-and-play UI was out of scope so the good old textarea-based solution seemed the best option. Even so it's not the simple key=value situation that I've used in the module a few times. I was about to use JSON but that's hard to write and error-prone so finally I made it with INI format, using parse_ini_string in the code. That worked so well that I will use it in the future for sure.

aos-custom-cke-toolbar.png.a6b93f9f932e989fb0ad915330340cce.png

I need to add a way to specify toolbar items to add/remove instead setting them directly, and it'll be ready for consumption :)

  • Like 2

Share this post


Link to post
Share on other sites
2 minutes ago, tpr said:

so finally I made it with INI format, using parse_ini_string in the code

Nice approach indeed!

  • Thanks 1

Share this post


Link to post
Share on other sites

v1.5.8 is uploaded so you can try the new "CKEditor customization" feature where you can set CKEditor toolbar buttons and other properties.

I think it's a pretty powerful feature with only a few lines of code, thanks to PW and using INI fomat in the configuration textarea.

For details, see the bottom of CKEaddons in the docs.

Plus I've reorganized the module assets including the compile/minify process, hopefully without any issues.

  • Like 3

Share this post


Link to post
Share on other sites
3 hours ago, tpr said:

I think it's a pretty powerful feature with only a few lines of code, thanks to PW and using INI fomat in the configuration textarea.

Nice one. How about using InputfieldAceExtended for the configuration textarea if it is installed?

if($this->modules->isInstalled('InputfieldAceExtended')) {
	$f = $this->modules->get('InputfieldAceExtended');
	$f->mode = 'ini';
	$f->modes = array('ini');
	$f->theme = 'twilight';
} else {
	$f = $this->modules->get('InputfieldTextarea');
}
$f->attr('name', 'CKEaddons_toolbar');
//...

2017-09-24_002320.png.b949cedf565a5519a2e69b77c4a4ed76.png

  • Like 2

Share this post


Link to post
Share on other sites

Not a bad idea, but how about highlight.js?

Share this post


Link to post
Share on other sites
5 hours ago, tpr said:

how about highlight.js

+1 so that we do not have to deal with dependencies

Share this post


Link to post
Share on other sites

Unfortunately highlight.js doesn't support textarea so I had to use CodeMirror. I'll be available in the next release.

Share this post


Link to post
Share on other sites
13 minutes ago, tpr said:

Unfortunately highlight.js doesn't support textarea so I had to use CodeMirror. I'll be available in the next release.

Cool.

But I do think it makes sense for utilities like CodeMirror or Ace to exist as separate inputfield modules so that they can be used elsewhere in Page Edit, other modules, etc, rather that duplicated within every module that uses them.

3 hours ago, szabesz said:

+1 so that we do not have to deal with dependencies

Things like this are not really dependencies (a plain textarea works fine without them) but more a progressive enhancement.

  • Like 3

Share this post


Link to post
Share on other sites

Makes sense but eg. for me who doesn't have Ace it's a drawback. Now I've modified the code to use Ace if it's installed, otherwise use CodeMirror.

Btw, with Ace the textarea height is only 3 rows here, how you managed it to make higher?

Update: solved it this way, but is there a way to autosize the Ace editor?

Spoiler

        if($this->wire('modules')->isInstalled('InputfieldAceExtended')) {
        	$f = $this->wire('modules')->get('InputfieldAceExtended');
        	$f->mode = 'ini';
        	$f->modes = array('ini');
        	$f->theme = 'twilight';
            $f->rows = 12;
        } else {
        	$f = $this->wire('modules')->get('InputfieldTextarea');
            $f->rows = 5;
        }

 

 

Share this post


Link to post
Share on other sites

Sorry to intervene with another topic but AOS stops Lister Pro from being able to list its own custom configured columns. With AOS enabled, its own "ListerTweaks" settings are enforced. It took me some time to figure out what is going on. @Rudy ran into the very same issue two weeks ago, and reported it in the Lister Pro forum as a "bug". These enforced "ListerTweaks" should be handled more gracefully I think. Fist of all, there should be an option to turn them off, letting Lister Pro do all this instead. Second, when it is turned on, there should be a notification for superusers above the listers in question as a reminder that AOS is "in effect".

What do you guys think?

Edited by szabesz
typo
  • Like 2

Share this post


Link to post
Share on other sites

I've worked on the "CKEditor customizations" feature and finally decided not to restrict on CKEditor field only. It was refactored to a new submodule called "FieldOverrides".

This way it is possible to set a bunch of field properties to override the defaults, in user, field or page contexts. Basically this is an extended version of the built-in field template overrides feature but for almost all field properties.

Some examples of what is possible:

aos-fieldoverrides.thumb.png.d737c6670fc83f0b49057ddcb289ca10.png

As you can see the syntax has changed a lot and there are some new keys too.

Syntax higlight works with InputfieldAceExtended and CodeMirror too, and in both cases the field auto-grows. CodeMirror uses files from the existing CKE plugins directory so the module's overall filesize hasn't grow much.

@szabesz I don't have ListerPro so it's hard to check things. You say that If you turn ListerTweaks off it's still active?

  • Like 4

Share this post


Link to post
Share on other sites
57 minutes ago, tpr said:

This way it is possible to set a bunch of field properties to override the defaults, in user, field or page contexts. Basically this is an extended version of the built-in field template overrides feature but for almost all field properties.

Awesome! I can see this being really powerful, and a nice alternative to working with hooks.

What do you think about adding an option for using a file to define these settings? For anything but the briefest snippets I much prefer working in my IDE (version control, etc). It could be a checkbox to activate the file-based option, or just check if "field-overrides.ini" exists in /site/modules/AdminOnSteroids/.  

  • Like 2

Share this post


Link to post
Share on other sites

Good idea, will implement it somehow.

  • Like 1

Share this post


Link to post
Share on other sites
13 minutes ago, Robin S said:

Awesome! I can see this being really powerful, and a nice alternative to working with hooks.

Okay, big flip-flop ahead... :D

...thinking some more, maybe this isn't such a good thing to add into AOS. It introduces another "language" to learn for doing something that is already possible with hooks. And @abdus has recently posted a tutorial for how to add other field settings into the template overrides that allows the admin GUI to be used. And I can see these ini-style settings being difficult to debug.

Don't know, I'm really in two minds about it. Be good to hear what others think.

  • Like 1

Share this post


Link to post
Share on other sites

I knew about @abdus article and considered going that way too. However I don't know how could I provide a UI for those hooks in one place like aos does how. Setting page/user conditionals would be another problem (from UI pov).

I don't think ini is a language/form a pw dev couldn't get in a few minutes so this doesn't seem to be an issue imo. aos already has a few non-conform field syntax, mainly key-value pairs, perhaps I'll convert them to similar ini-like fields later.

Lack of logging or such is an issue though. My best idea is to add notifications for superusers that some field properties are overridden by the module, on the page edit screen. I do not want to modify the original field edit page, that would lead to more confusions I think, and it wasn't easy in case of user/page conditions in effect.

As for the file-based settings I think I will prepend it to the admin contents if exists.

My biggest concern is that this submodule is too powerful, but it's for devs who should know what they are doing. And they can leave out this daily dose if they don't like it :)

Share this post


Link to post
Share on other sites
7 hours ago, Robin S said:

Be good to hear what others think.

Actually, I intentionally do not use any role based features of AOS and the reason for this is that I do not want my admin setups to depend on the module. All should still be usable and "the same" when AOS is disabled/uninstalled. For the same reason, I do not use it for loading "admin CSS and JS" either, for example, but there are other features too I do not use just because of this.

  • Like 1

Share this post


Link to post
Share on other sites
8 hours ago, tpr said:

@szabesz I don't have ListerPro so it's hard to check things. You say that If you turn ListerTweaks off it's still active?

Hm, I forgot how to turn it off so I could not do it. Now I see that clicking on the box turns stuff on and off. I will do some further testing on the weekend when I have the time.

Share this post


Link to post
Share on other sites
8 hours ago, Robin S said:

Don't know, I'm really in two minds about it. Be good to hear what others think.

Same here. I think I'll stick to hooks..

Another thing: with AOS turned on I have problems with cke fields. The header is sticky and if you have lots of buttons the textarea will get inaccessible (first screenshot is AOS off and it works):

Screenshot_20170928-092230.png

Screenshot_20170928-091301.png

Share this post


Link to post
Share on other sites

@tpr, I guess the question is "Why use ini format in the AOS config when you can just as easily use a hook?" The hook equivalent of the first two items in your screenshot is:

$wire->addHookBefore('Field::getInputfield', function(HookEvent $event) {
    $field = $event->object;
    $page = $event->arguments(0);

    // Add word counter for the "title" field for non-superusers
    if($field->name == 'title' && !$this->user->isSuperuser()) {
        $field->showCount = 2;
    }

    // Set year range for a date field, if template is "news"
    if($field->name == 'date_created' && $page->template == 'news') {
        $field->yearRange = '-3:+3';
    }
    
});

Comparing the hook option to the AOS config option my thoughts are:

  1. Once the hook function is in place and the $field and $page variables defined, the code for each field override is not significantly longer.
  2. It's plain PHP, so we're already familiar with the format.
  3. It's easier to read the conditionals.
  4. It's file-based.
  5. It's easy to dump/log within the hook.
  6. It saves any additional complexity being needed in AOS.
  • Like 2

Share this post


Link to post
Share on other sites

@bernhard I'll disable the position sticky for mobile screens.

@Robin S 

I see your points, but not everyone is capable of writing hooks. In fact the whole AOS wouldn't be needed because one could add their hooks/tweaks manually too. So yes, it's an abstraction but imo it makes things easier, maybe not for those who are familiar with hooks. In fact even for me it's easier to edit such an ini file (whether in admin or in a file) than writing hooks.

Perhaps I could use a PHP array instead ini when used from a file, and add a log key (command) to make logging easier but I guess this wouldn't help for those who prefer hooks instead.

Btw, "$page->template == 'news'" in your example is not valid, because in the admin the edited page is needed to be checked (template would return "admin" there always).

 

  • Thanks 1

Share this post


Link to post
Share on other sites
2 hours ago, tpr said:

I see your points, but not everyone is capable of writing hooks.

You're probably right. It won't hurt to add the feature and users can make up their own mind what they find easiest to use.

2 hours ago, tpr said:

Btw, "$page->template == 'news'" in your example is not valid, because in the admin the edited page is needed to be checked (template would return "admin" there always).

The $page argument for that method actually is the page being edited.

  • Like 1

Share this post


Link to post
Share on other sites

Hey @tpr - any chance you could add the "Show pagelist actions on full row hover" tweak to the sidepanel tree - the one that shows when you click this icon 59cfc586b33e2_ScreenShot2017-09-30at9_25_29AM.png.3ee83aecfd84e991210de11fd21116af.png in the breadcrumbs. 

I am starting to get into the habit of using that panel as a way to access the tree and I am really missing the full row hover.

On another note - what are your thoughts on supporting the new UiKit theme now? It is starting to look more usable (although I must admit I still don't see any real advantages over an AOS tweaked default theme), but it would be a nice option to have going forward. No pressure by the way - I know it's going to become painful keeping up with three different themes. It will be interesting to see what happens - will UiKit takeover as default - will the others stop getting core upgrades? Comes back to my desire for one theme which is easily skinnable, rather than different structures!

  • Like 4

Share this post


Link to post
Share on other sites

Took some time why it's not working there but finally found it - the CSS rule is active only above 960px screen width and the panel width usually below this. I'll fix this in the next release. Probably if you zoom the page out you'll see too.

I've checked the new UIkit theme and it's not bad. From AOS pov I saw only the language switcher that is misplaced but surely there are others too. I'll wait until more users will start to use it and if there will be too many AOS-related complains I'll start to fix them. I would be also happy if there would be only one theme to support.

  • Like 3

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Soma
      LogMaintenance
      A simple ProcessWire module to give some maintenance control over log files. I found myself often having lots of log files for different things that can grow more or less quickly to a size where they can be difficult to maintain. The built in Logger of PW does a good job of giving you the possibility to delete or prune logs. But it has to be done manually and sometimes a log grows into millions of lines, which makes it often impossible to even prune it as it's too large.
      LogMaintenance uses LazyCron to run the maintenance task and there's several settings you can setup on a global or per log basis.
      Archive: will create zip files for each log file in logs/archive/ folder and add the log each time the maintenance is run to a subfolder containing the datetime.
      Lines: keeps logs to a certain number of lines 
      Days: keeps the log to a certain number of days
      Bytes: keeps the log to a certain amount of bytes
      Each setting is checked from top down, the first setting to contain something is used. So if you check the "Archive" option, all other settings are ignored and logs are archived everytime the LazyCron is executed. If you want to keep your logs to a certain amount of bytes just leave all other settings to 0 or blank.
      Per Log Settings
      There's a textarea that you can use to setup a config for a specific log file one per line. All the logs you define here ignore the global settings above. The syntax for the settings is:
      logname:[archive]:[lines]:[days]:[bytes] 
      errors:1:0:0:0 // would archive the errors log messages:0:10000:0:0 // will prune the errors log to 10000 lines  
      The module can be found on github for you to check out. It's still fresh and I'm currently testing.
      https://github.com/somatonic/LogMaintenance
    • By teppo
      Fieldtype Page IDs is a third party Fieldtype that, simply put, stores Page references as integers (Page IDs).
      This fieldtype was built as a quick and dirty workaround for Page Reference fields' inability handle self-references due to circular reference issues. A project I've been working on for a while now includes a combination of RepeaterMatrix content blocks and tagging/categorization system that would've resulted in a lot of duplicate pages (and plenty of unnecessary manual work for content editors) had I used built-in Page Reference fields, and thus a new Fieldtype felt like the most sensible approach.
      Fieldtype Page IDs was designed to be loosely compatible with Page References in order to make conversions between the two feasible, but it is quite limited feature wise:
      largely due to the fact that stored values are actually just integers with no connection to Pages whatsoever some advanced selectors and related features are not supported, and page values can't be directly accessed configuration settings are limited to the bare essentials (selector string and Inputfield class) only a handful of Inputfields (AsmSelect, Checkboxes, Text) are (currently) supported Anyway, in case you need to store Page IDs (and Page IDs only) and are happy with the limitations mentioned above, feel free to give this Fieldtype a try. It has been working fine for me in one particular project, but hasn't been tested that much, so please tread carefully – and let me know if you run into any issues.
      GitHub repository: https://github.com/teppokoivula/FieldtypePageIDs
      Modules directory: https://modules.processwire.com/modules/fieldtype-page-ids/
    • By daniels
      This is a lightweight alternative to other newsletter & newsletter-subscription modules.
      You can find the Module in the Modules directory and on Github
      It can subscribe, update, unsubscribe & delete a user in a list in Mailchimp with MailChimp API 3.0. It does not provide any forms or validation, so you can feel free to use your own. To protect your users, it does not save any user data in logs or sends them to an admin.
      This module fits your needs if you...
      ...use Mailchimp as your newsletter / email-automation tool ...want to let users subscribe to your newsletter on your website ...want to use your own form, validation and messages (with or without the wire forms) ...don't want any personal user data saved in any way in your ProcessWire environment (cf. EU data regulation terms) ...like to subscribe, update, unsubscribe or delete users to/from different lists ...like the Mailchimp UI for creating / sending / reviewing email campaigns *I have only tested it with PHP 7.x so far, so use on owners risk
      EDIT:
      I've updated the module to 0.0.4. I removed the instructions from this forum, so I don't have to maintain it on multiple places. Just checkout the readme on github 🙂
      If you have questions or like to contribute, just post a reply or create an issue or pr on github. 
    • By bernhard
      WHY?
      This module was built to fill the gap between simple $pages->find() operations and complex SQL queries.
      The problem with $pages->find() is that it loads all pages into memory and that can be a problem when querying multiple thousands of pages. Even $pages->findMany() loads all pages into memory and therefore is a lot slower than regular SQL.
      The problem with SQL on the other hand is, that the queries are quite complex to build. All fields are separate tables, some repeatable fields use multiple rows for their content that belong to only one single page, you always need to check for the page status (which is not necessary on regular find() operations and therefore nobody is used to that).
      In short: It is far too much work to efficiently and easily get an array of data based on PW pages and fields and I need that a lot for my RockGrid module to build all kinds of tabular data.

      Basic Usage

       
      Docs & Download
      https://modules.processwire.com/modules/rock-finder/
      https://gitlab.com/baumrock/RockFinder/tree/master
       
      Changelog
      180528, v1.0.4 add custom select statement option 180516 change sql query method, bump version to 1.0.0 180515 multilang bugfix 180513 beta release <180513 preview/discussion took place here: https://processwire.com/talk/topic/18983-rocksqlfinder-highly-efficient-and-flexible-sql-finder-module/
    • By blynx
      Hej,
      A module which helps including Photoswipe and brings some modules for rendering gallery markup. Feedback highly appreciated
      (Also pull requests are appreciated 😉 - have a new Job now and don't work a lot with ProcessWire anymore, yet, feel free to contact me here or on GitHub, Im'm still "online"!)

      Modules directory: http://modules.processwire.com/modules/markup-processwire-photoswipe
      .zip download: https://github.com/blynx/MarkupProcesswirePhotoswipe/archive/master.zip
      You can add a photoswipe enabled thumbnail gallery / lightbox to your site like this. Just pass an image field to the renderGallery method:
      <?php $pwpswp = $modules->get('Pwpswp'); echo $pwpswp->renderGallery($page->nicePictures); Options are provided like so:
      <?php $galleryOptions = [ 'imageResizerOptions' => [ 'size' => '500x500' 'quality' => 70, 'upscaling' => false, 'cropping' => false ], 'loresResizerOptions' => [ 'size' => '500x500' 'quality' => 20, 'upscaling' => false, 'cropping' => false ], 'pswpOptions' => (object) [ 'shareEl' => false, 'indexIndicatorSep' => ' von ', 'closeOnScroll' => false ] ]; echo $pswp->renderGallery($page->images, $galleryOptions); More info about all that is in the readme: https://github.com/blynx/MarkupProcesswirePhotoswipe
      What do you think? Any ideas, bugs, critique, requests?
      cheers
      Steffen