tpr

AdminOnSteroids

Recommended Posts

Thanks @Robin S, I merged your codes into my aos work copy. Seems to work fine at first look but need to test a bit more to make sure there are no side effects. Bernhard's repeater profile also seems to be OK with your fixes, though it was also OK with mines.

  • Like 2

Share this post


Link to post
Share on other sites
On 6/10/2017 at 1:35 AM, Robin S said:

@tpr, I've been having a look at the images-in-repeater issue for non-superusers (I discovered this one a while back but forgot to report it here, sorry :().

-----

Edit: I did report it over in the Github repo.

Edit 2: looking at some PM history it looks like a solution (same intent but different implementation to that proposed below) was found but never merged into the repo?

-----

As you found, the $this->editedPage property is the source of the issue. Seeing as the things this property is used for within the module either don't work within repeaters (e.g. field edit links) or aren't needed for repeater pages (e.g. breadcrumb features) I think $this->editedPage should never be set to a repeater page. But it's much easier to exclude repeater pages in ready() because in init() it is not yet known which class a page is an instance of. So could $this->editedPage be set in ready() instead?

This is what I did in my testing and it seems to work okay:


public function init()
{
    // removed code that sets $this->edited page
    
    // populate self::$configData
    self::$configData = $this->modules->getModuleConfigData($this);
    
    // ...
    
    // a bit further down we need to change $configData[$subModule] to self::$configData[$subModule]

public function ready()
{
    // set $this->editedPage
    // excluded repeater pages, minor refactoring
    $this->editedPage = false;
    $editedPageId = $this->sanitizer->int($this->config->input->get->id);
    $editedPage = $this->pages->get($editedPageId);
    if( $editedPage->id && !($editedPage instanceof RepeaterPage) ) $this->editedPage = $editedPage;

    self::$configData = $this->modifyConfigData(
        $this->modules->getModuleConfigData($this),
        $this->editedPage
    );
    
    // ...

 

Hi,

many thanks for the code,
this works like a charm, saved the day/week :)

Share this post


Link to post
Share on other sites
On 6/9/2017 at 4:50 AM, tpr said:

It's the same issue as of @bernhard's, could you try the fix I posted on June 2?

This solution did not worked,
I tried the solution from @Robin S and worked,
many thanks.

Share this post


Link to post
Share on other sites

AOS is at 1.4.7, containing Robin S's fixes and his IconsFilter module. I've spent much more time on the icons filter because I wanted it to be compatible with the current markup and with this PR too.

  • Like 5

Share this post


Link to post
Share on other sites

@tpr, these CSS overrides for wide screens are causing a misalignment of the WireTabs in the default admin theme:

2017-06-13_153043.png.1e153d2d871fb9f1ac02a63730b92095.png

I'm not sure what the "PrevNextTabs" feature is that requires the override, but if the overrides need to stay could you change to:

margin-bottom:calc(-2.6em - 1px);

 

Share this post


Link to post
Share on other sites
1 hour ago, Robin S said:

I'm not sure what the "PrevNextTabs" feature is that requires the override

It's another module. I'll check it, thanks.

Share this post


Link to post
Share on other sites
15 hours ago, Robin S said:

if the overrides need to stay could you change to:


margin-bottom:calc(-2.6em - 1px);

 

I couldn't see this issue but it was also OK here after applying the fix so I committed the update.

  • Like 1

Share this post


Link to post
Share on other sites

@tpr, AOS is adding the 'edit template' icon/link to the password inputfield. A bug?

2017-06-15_131757.png.bf34595c3901a4147c45d2ee9f7940bf.png

  • Like 1

Share this post


Link to post
Share on other sites

Certainly, the workaround selector fails here, I'll update soon.

  • Like 1

Share this post


Link to post
Share on other sites

Hello @tpr I have a problem with Pro Fields: Table in conjunction with AdminOnSteroids. If I use the Table Cells Selection Plugin or the Lightwire skin, the editing of the fields does not work as expected. I attached a screen-capture (with audio) to show the problem. I can export the fields if you want to recreate this.

pro-fields-table-adminonsteroids.mp4

  • Like 1

Share this post


Link to post
Share on other sites
On 6/12/2017 at 11:38 PM, Robin S said:

I'm not sure what the "PrevNextTabs" feature is that requires the override, but if the overrides need to stay could you change to:

if there is anything i can change or fix in the PrevNextTabs module, let me know

Share this post


Link to post
Share on other sites
5 hours ago, jmartsch said:

I attached a screen-capture (with audio) to show the problem. I can export the fields if you want to recreate this.

Thanks, it was very informative!

I could locate the TCS issue, the plugin had return false but false wasn't needed. Please try the attached js file.

As for the Lightwire bug, the floating ckeditor toolbar was always an issue, the current solution is a workaround I've added earlier. Now that PW's default ckeditor skin looks nicer since the last ckeditor upgrade, I'm thinking of removing the skin entirely, what do you think?

tablecellsselection.js

Share this post


Link to post
Share on other sites
21 hours ago, tpr said:

Thanks, it was very informative!

I could locate the TCS issue, the plugin had return false but false wasn't needed. Please try the attached js file.

As for the Lightwire bug, the floating ckeditor toolbar was always an issue, the current solution is a workaround I've added earlier. Now that PW's default ckeditor skin looks nicer since the last ckeditor upgrade, I'm thinking of removing the skin entirely, what do you think?

tablecellsselection.js

@tpr With the new tablecellselection.js it works :)

In my eyes, the Lightwire skin looks nicer than the default skin. Especially the design of the dropdowns and the icons. Can´t you update the default skin so it uses your styles? Maybe even publish it on the ckeditor.com site. The changes are subtle but noticable.

Share this post


Link to post
Share on other sites

Icon replacements could work, I'll try. Btw its not my own skin but nico's, I'm just borrowing it :)

Share this post


Link to post
Share on other sites

With the recent CKEditor update to 4.7 the Table Cells Selection plugin can be entirely removed, will do it in the next update.

  • Like 1

Share this post


Link to post
Share on other sites

Hi @tpr, I've been working on a module that adds an icon to file items in a File field and checking to make sure it plays nicely with the "noFilenameTruncate" option in AOS. So I've been looking closely at the layout and have a suggestion for fine-tuning the noFilenameTruncate styles.

Here is the default appearance of a File field, without AOS noFilenameTruncate activated:

2017-06-30_130147.png.2fd26c7763281b51b9f4706567a2ef45.png

And here is the appearance when noFilenameTruncate is activated:

2017-06-30_130106.png.86015298ef1a5b88412553a0a0379aec.png

And what I'd like to suggest is...

  • Reduce the padding of the header to compensate for the extra line-height you added.
  • The float:left you added to the file icon shifts it up a bit from the default, so compensate for that with a some extra top offset.
  • Put the delete icon back over on the right by positioning it absolutely. It's better over there if you have several files to delete because you don't have to go hunting for it.

The result...

2017-06-30_133954.png.1b992a35cbf16e9f01bc0e4c6a98e879.png

And the modified SCSS for that:

html.noFilenameTruncate {
  p.InputfieldFileInfo.InputfieldItemHeader {
    padding: 6px 34px 6px 25px; 
    position: relative;
  }
  i.fa-file-image-o,
  .InputfieldFileInfo i {
    left: -21px !important;
    top: 3px;
    float: left;
  }
  a.InputfieldFileName {
    line-height: 1.33;
    margin-left: -22px;
    word-wrap: break-word;
  }
  label.InputfieldFileDelete {
    position: absolute; 
    top: 8px; 
    right: 8px;
  }
}

What do you think? 

  • Like 1

Share this post


Link to post
Share on other sites

@tpr, there is an issue with the "edit field" helper link shown in Page Edit for fieldsets. Instead of linking to the the settings of the fieldset itself it links to the settings of the first child field of the fieldset.

2017-07-02_221228.png.a403a6c77071b9d83b5cbf902689549b.png

Share this post


Link to post
Share on other sites

Thanks, will investigate them later.

Share this post


Link to post
Share on other sites

Thanks for this wonderful module. When SVG is used in image field, the download button is not appearing. I hope it can be there.:rolleyes: 

Share this post


Link to post
Share on other sites

All 3 issues above should be fixed in v149, thanks!

  • Like 2

Share this post


Link to post
Share on other sites

Two small additions in v150:

  • Misc: add new page: uncheck `Active?` for non-default language names (thanks to Tomka)
  • Misc: hide the `Add new` dropdown button from above the main pagelist

Unchecking the active state for the non-default language variant of a page can be handy if only a few pages need to be multi-language, so you don't have to go to the Settings tab to uncheck them all every time adding a new page. Also works with templates with parent-child relationships set (when the first step of the addnew process is invisible).

Hiding the Add new dropdown doesn't take the available bookmarks into account, just hides the button entirely (CSS only btw). I never really needed this feature and I agree that it's rather confusing. The main pagelist looks a bit empty without this button though :)

  • Like 3

Share this post


Link to post
Share on other sites

hi tpr,

seems that the move up/down icons overlap the delete icon making it impossible to click on it. do you need more information to reproduce this? aos 1.5.0 and pw 3.0.68

597b36b4c0633_2017-07-2815_02_11-EditPage_Runtastic360v2_dev.thumb.png.6650e64d2d603b9622619b36a7dcca47.png

  • Like 2

Share this post


Link to post
Share on other sites

Thanks, it's a bug, will be fixed soon.

  • Like 2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By BitPoet
      MediaLibrary
      Update: MediaLibrary can now be found in the official module list.
      Out of necessity, I've started to implement a simple media library module.
      The basic mechanism is that it adds a MediaLibrary template with file and image fields. Pages of this type can be added anywhere in the page tree.
      The link and image pickers in CKEditor are extended to allow quick selection of library pages from dropdowns. In the link picker this happens in the MediaLibrary tab, where you can also see a preview of the selected image. In the image picker, simply select a library from the dropdown at the top, everything else is handled by standard functionality.
      I've put the code onto github. This module is compatible with ProcessWire 3.
      Steps to usage:
      Download the module's zip from github (switch to the pw3 branche beforehand if you want to test on PW 3.x) and unpack it into site/modules Click "Modules" -> "Refresh" in the admin Click "Install" for MediaLibrary For testing, create a page with the MediaLibrary template under home (give it an expressive title like 'Global Media') and add some images and files Edit a differnt page with a CKEditor field and add a link and an image to see the MediaLibrary features in action (see the screencap for details) Optionally, go into the module settings for MediaLibrary Note: this module is far from being as elaborate as Kongondo's Media Manager (and doesn't plan to be). If you need a feature-rich solution for integrated media management, give it a look.
      Feel free to change the settings for MediaFiles and MediaImages fields, just keep the type as multiple.
      There are some not-so-pretty hacks for creating and inserting the correct markup, which could probably be changed to use standard input fields, though I'm a bit at a loss right now how to get it to work. I've also still got to take a look at error handling before I can call it fit for production. All feedback and pointers are appreciated (that's also why I post this in the development section).

      Edit 09.03.2016 / version 0.0.4: there's now also a "Media" admin page with a shortcut to quickly add a new library.

      Edit 01.05.2016:
      Version 0.0.8:
      - The module now supports nested media libraries (all descendants of eligible media libraries are also selectable in link/image picker).
      - There's a MediaLibrary::getPageMediaLibraries method you can hook after to modify the array of available libraries.
      - You can switch between (default) select dropdowns or radio boxes in the module configuration of MediaLIbrary to choose libraries.
      Edit 10.10.2018:
      Version 0.1.3:
      - Dropped compatibility for ProcessWire legacy versions by adding namespaces
      - Allow deletion of libraries from the Media overview admin page
      - Added an option to hide media libraries from the page tree (optionally also for superusers)
    • By Robin S
      This module corrects a few things that I find awkward about the "Add New Template" workflow in the PW admin. I opened a wishlist topic a while back because it would good to resolve some of these things in the core, but this module is a stopgap for now.
      Originally I was going to share these as a few standalone hooks, but decided to bundle them together in a configurable module instead.
      Add Template Enhancements
      A module for ProcessWire CMS/CMF. Adds some efficiency enhancements when adding or cloning templates via admin.

      Features
      Derive label from name when new template added: if you like to give each of your templates a label then this feature can save some time. The label can be added automatically when templates are added in admin, in admin/API, or not at all. There are options for underscore/hyphen replacement and capitalisation of the label. Edit template after add: when adding only a single template, the template is automatically opened for editing after it is added. Copy field contexts when cloning: this copies the field contexts (a.k.a. overrides such as column width, label and description) from the source template to the new template when using the "Duplicate/clone this template?" feature on the Advanced tab. Copy field contexts when duplicating fields: this copies the field contexts if you select the "Duplicate fields used by another template" option when adding a new template. Usage
      Install the Add Template Enhancements module.
      Configure the module settings according to what suits you.
       
      https://github.com/Toutouwai/AddTemplateEnhancements
      https://modules.processwire.com/modules/add-template-enhancements/
    • By Mike Rockett
      As I mentioned in this issue, I've create a new textformatter for ParsedownExtraPlugin, which adds some oomph to your markdown.
      Repo: Parsedown Extra Plugin
      Unlike the built-in textformatter for Parsedown and Parsedown Extra, this should be used when you want to use Extra with additional configuration/customisation.
      Some examples:
      ### Test {.heading} - A [external link](https://google.com/){.google} with `google` as a class that opens in a new tab if the config property is set. - [Another link](/page){target=_blank} that opens in a new tab even though it isn't external. ```html .html <p>Test</p> ``` There's some config options available to you, such as setting attributes on all/external images and links, setting table and table-cell alignment classes, adjusting footnote classes and IDs, adding <code> attributes to their parent <pre> elements, and changing the <code> class if your syntax highlighter does not use language-*.
      I was thinking about adding the ability to make links open in a new tab by appending a plus to the link syntax, but only external links should be opening in a new tab anyway. Further, this would add extra, unnecessary processing time.
      Please let me know if you bump into any problems. ☺️
    • By Mike Rockett
      TextformatterTypographer (0.4.0 Beta)
      A ProcessWire wrapper for the awesome PHP Typography class, originally authored by KINGdesk LLC and enhanced by Peter Putzer in wp-Typography. Like Smartypants, it supercharges text fields with enhanced typography and typesetting, such as smart quotations, hyphenation in 59 languages, ellipses, copyright-, trade-, and service-marks, math symbols, and more.
      Learn more on my blog
      It's based on the PHP-Typography library found over at wp-Typography, which is more frequently updated and feature rich that its original by KINGdesk LLC.
      The module itself is fully configurable. I haven't done extensive testing, but there is nothing complex about this, and so I only envisage a typographical bug here and there, if any.
      Please do test it out and let me know what you think.
      Also note that I have indicated support for PW 2.8, but I haven't tested there as yet. This was built on PW 3.0.42/62.
    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.50
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy!