tpr

AdminOnSteroids

Recommended Posts

tpr    2,212

Hi @theo,

please try this and see if you can manage to make it work.

What would be handy here having an ajax button to check whether these assets exist.

AdminOnSteroids.module

Share this post


Link to post
Share on other sites
theo    7
13 hours ago, tpr said:

Hi @theo,

please try this and see if you can manage to make it work.

What would be handy here having an ajax button to check whether these assets exist.

AdminOnSteroids.module

Thank you Roland.

But I can't make it work.

I show you what I did to test it. There are 6 "echos" marked like (0) ... (5). Code snippet is from about line 989 of the module.

        echo $root.' (0)<br>';
        echo $rootPath.' (1)<br>';

        // remove install subdirectory
        $rootPath = rtrim($rootPath, $root);
        echo $rootPath.' (2)<br>';

        $rootUrl = $this->config->urls->httpRoot;
        $rootUrl = rtrim($rootUrl, $root);

        $templatesUrlRelative = $this->config->urls->templates;
        
        echo $rootUrl.' (3) <br>';
        echo $templatesUrlRelative.' (4)<br>';

        // do not add JS to page on login page
        if ($this->page->id != 23) {

            // custom CKEaddons config js and css

            $ckeCSS = $this->getAssetPath('CKEStyle', 'admin/cke.css', $templatesUrlRelative, $configData, $root);
            $ckeJS = $this->getAssetPath('CKEScript', 'admin/cke.js', $templatesUrlRelative, $configData, $root);
            $ckeTemplates = $this->getAssetPath('CKEtemplates', 'admin/templates.js', $templatesUrlRelative,
                $configData, $root);
                
            echo $rootPath . $ckeJS.' (5)<br>';

This outputs:

/~theo/pw3061/ (0)
/home/theo/public_html/pw3061 (1)
/home/theo/public_html (2)
http://localhos (3)
/~theo/pw3061/site/templates/ (4)
/home/theo/public_html/~theo/pw3061/site/templates/admin/cke.js (5)

Where settings are:

Assets Root Path: /home/theo/public_html/pw3061/

CKEditor custom configuration script: /site/templates/admin/cke.js

 

Thank you.

Share this post


Link to post
Share on other sites
tpr    2,212

I'm thinking of removing the default paths and load only files that the user has written something into the inputs, and also remove the file_exists() limitation. So it would be entirely the user's responsibility to add an asset that is surely available (to avoid 404s).

Share this post


Link to post
Share on other sites
theo    7
3 minutes ago, tpr said:

I'm thinking of removing the default paths and load only files that the user has written something into the inputs, and also remove the file_exists() limitation. So it would be entirely the user's responsibility to add an asset that is surely available (to avoid 404s).

I don't know PW well enough, but isn't there a setting anywhere to get or set (in my case:)

rootURL: http://localhost/~theo/pw3061/

rootPath: /home/theo/public_html/pw3061/

It think this would be handy in many situations. I'm usually setting such values in init.php, but it should probably go to config.php as a PW standard variable.

Or does sth. like this already exist?

 

Share this post


Link to post
Share on other sites
tpr    2,212

AFAIK you can overwrite some paths/urls but I wouldn't use it if not necessary (to avoid breaking things).

I'll implement the idea I wrote above, that would simplify things a lot (although autoloading assets will be gone).

Share this post


Link to post
Share on other sites
theo    7
1 hour ago, tpr said:

I'll implement the idea I wrote above, that would simplify things a lot (although autoloading assets will be gone).

OK, thank you.

Share this post


Link to post
Share on other sites
tpr    2,212

Here are the updates. You can use absolute (fully qualified) or relative paths (relative to site root).

aos-assetpaths.gif.86282f210bcb85034d5dbbda9825827a.gif

 

aos-assetpaths.zip

  • Like 1

Share this post


Link to post
Share on other sites
jmartsch    118
On 14.5.2017 at 10:16 PM, tpr said:

Btw there are a few filterboxes: a "general" one for datatables, one for the Language Translator and one for File fields, are you covering them all?

Yes, i try to support all filterboxes. Sadly right now I am busy with some projects. Hope I find the time to finish this soon.

  • Like 1

Share this post


Link to post
Share on other sites
ceberlin    229

The last update made Notices appear at some of our websites (not on all):


Notice: Undefined index: CKEStyle in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: CKEScript in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: CKEtemplates in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: AdminStyle in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: AdminScript in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Share this post


Link to post
Share on other sites
tpr    2,212

Thanks, please re-download (only .module file was changed).

  • Like 1

Share this post


Link to post
Share on other sites
tpr    2,212

A new pagelist action "Refresh" will be added in the next update. This refreshes the displayed page data in the page list + reloads children too. Can be useful if you renamed or deleted pages in another browser tab and would like to save a page reload :) 

aos-refresh-action.gif

  • Like 1

Share this post


Link to post
Share on other sites
bernhard    1,289

hi @tpr

i just found a bug when using latest version of AOS (just did the update from 1.4.1 to 1.4.6). it also existed in the later version.

i have a repeater including an image field and an "editor" role with edit-access for the home-template (and all children). the problem is that the image in the repeater field gets uploaded and after reaching 100% disappears. i did some debugging and i found out the following:

  • aos uninstalled: works
  • aos installed: does not work (either enabled or disabled)
  • upload as superuser works at all setups
  • ajax error after fileupload: {"error":false,"message":"The requested process does not exist"}
  • when i try to edit the repeater item directly ( /admin/page/edit/?id=1024&InputfieldFileAjax=1 ) in the admin i get this error:
    59317c4d1da3b_2017-06-0216_54_51-ProgramManager.png.416cf1bd70f1a500fee7a57143be2282.png
 
i hope i was clear enough with my informations so that you can fix this as easy as possible :) if you need more information just let me know!
 
PS: regular image fields outside repeaters work as expected

Share this post


Link to post
Share on other sites
tpr    2,212

I have a site with similar editor role and could not reproduce the issue. You could try uncommenting things above these lines in init() and ready() functions and see where it fails:

if (!$this->enabled) {
	return;
}

Only lines above these will be run if you have disabled AOS in its settings page.

By any chance have you added new permission from these pre-defined ones? I had a site where "page-edit-created" caused similar issues if I remember right.

new-roles.thumb.png.b234308988efc9e5a206df516892f856.png

Share this post


Link to post
Share on other sites
tpr    2,212

Thanks! Could you try replacing the line 408 with this, and check if it fixes the issue and doesn't break other things? I clicked around in the admin and everything seems to be fine (in another PW).

Update: there was an issue with the previous fix, pls try this (lines 408-414):

        $editedPageId = $this->input->get->id ? $this->sanitizer->int($this->input->get->id) : false;

        if ($editedPageId && is_numeric($editedPageId) && $this->pages->find('id=' . $editedPageId . ',check_access=0')->count()) {
            $this->editedPage = $this->pages->find('id=' . $editedPageId . ',check_access=0')->first();
        } else {
            $this->editedPage = null;
        }

 

Share this post


Link to post
Share on other sites
Robin S    2,487

Hi @tpr, I spotted an issue with the position of the InputfieldPageListSelect restore icon when the inputfield's width is not the last/only inputfield in a row:

2017-06-08_121232.png.61e391db43d0b800e7bc14c5aa272f7c.png

I fixed it with this:

html.aos .InputfieldPageListSelect { position:relative; }
.aos_pagelist_unselect.restore { right:0; transform:none; -webkit-transform:none; }

 

  • Like 1

Share this post


Link to post
Share on other sites
tpr    2,212

Thanks, this part was always buggy but I think I've found a better way, namely floating clear btn and pagelist to the left, and setting pagelist width using calc(). It's OK here in Firefox and Chrome, even with long page titles, could you try?

unselect-placement.thumb.png.ac12031b3f4377807a29250df6877dcd.png

AdminOnSteroids.css

  • Like 1

Share this post


Link to post
Share on other sites
Robin S    2,487
1 hour ago, tpr said:

It's OK here in Firefox and Chrome, even with long page titles, could you try?

Works great, thanks!

  • Like 1

Share this post


Link to post
Share on other sites
vmo    2

Hi,
I having a problem with image field inside a repeater field and with extra image fields and user profiles and the AdminOnSteroids.

With the superuser profile there is no problem, but the user has other profile then superuser the image in the repeater field does not show the image after upload and do not save the image and the extra image fields does not show correctly  (each language in a row) and the internal link selector does not work and does not show any error.

After a week trying to understand why the non superuser users where not able to upload the images and creating new fields to verify if the originals ones where with some kind of problem I come to the conclusion that the problem where not the fields on them selfs but with some module that was causing this behavior.

After trying to disable the module a tweak the AdminOnSteroids configurations the only thing that work for me was to uninstall the module and the users can upload the image the the extra image fields show correctly.

Its is a great module and I hope you can resolve this issue.

Thank you

Share this post


Link to post
Share on other sites
tpr    2,212
3 hours ago, vmo said:

having a problem with image field inside a repeater

It's the same issue as of @bernhard's, could you try the fix I posted on June 2?

  • Like 1

Share this post


Link to post
Share on other sites
bernhard    1,289

sorry for my late reply! your fix didn't work for me. curious if it helps vmo...

Share this post


Link to post
Share on other sites
Robin S    2,487

@tpr, I've been having a look at the images-in-repeater issue for non-superusers (I discovered this one a while back but forgot to report it here, sorry :().

-----

Edit: I did report it over in the Github repo.

Edit 2: looking at some PM history it looks like a solution (same intent but different implementation to that proposed below) was found but never merged into the repo?

-----

As you found, the $this->editedPage property is the source of the issue. Seeing as the things this property is used for within the module either don't work within repeaters (e.g. field edit links) or aren't needed for repeater pages (e.g. breadcrumb features) I think $this->editedPage should never be set to a repeater page. But it's much easier to exclude repeater pages in ready() because in init() it is not yet known which class a page is an instance of. So could $this->editedPage be set in ready() instead?

This is what I did in my testing and it seems to work okay:

public function init()
{
    // removed code that sets $this->edited page
    
    // populate self::$configData
    self::$configData = $this->modules->getModuleConfigData($this);
    
    // ...
    
    // a bit further down we need to change $configData[$subModule] to self::$configData[$subModule]
public function ready()
{
    // set $this->editedPage
    // excluded repeater pages, minor refactoring
    $this->editedPage = false;
    $editedPageId = $this->sanitizer->int($this->config->input->get->id);
    $editedPage = $this->pages->get($editedPageId);
    if( $editedPage->id && !($editedPage instanceof RepeaterPage) ) $this->editedPage = $editedPage;

    self::$configData = $this->modifyConfigData(
        $this->modules->getModuleConfigData($this),
        $this->editedPage
    );
    
    // ...

 

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By bernhard
      hi everybody,
      this is a preview of a module that i'm working on for quite a long time. I needed it for an intranet office management application that i'm still working on. It makes it very easy to create very customized Datatables using the awesome jquery datatables plugin (www.datatables.net)
       
      EARLY ALPHA release!
      It's very likely that there will lots of changes to this module that may cause breaking your implementations.
       
      Module source
      sorry, removed as it changes too frequently; closed alpha - contact me if you think you can contribute
       
       
      Remarks:
      The module is intended to be used on the backend. Loading styles is at the moment only done via adding files to the $config->styles/scripts arrays. Also the communicaton to javascript is done via the $config->js() method that is built into the admin and would have to be implemented manually on frontend use. But it would not be difficult of course
      Installation:
      Nothing special here, just download + install
       
      edit: removed some parts, because i made a complete rewrite of the module! (see last posting in the thread)
       
      Customization example:
      in the screencast you see an example that i'm using in a process module. i put the table inside an InputfieldMarkup just to have the same look&feel all around the admin. you see that you could also use this module to create tables quickly and easily using @kongondo s runtime markup module.
      complete PHP code:
      $this->headline('Kundenliste'); $form = $modules->get('InputfieldForm'); // init datatables module $dt2 = $modules->get('RockDataTables2'); // setup columns // name $col = new dtCol(); $col->name = 'name'; $col->title = 'Name'; $col->data = function($page) { return $page->title; }; $dt2->cols->add($col); // type $col = new dtCol(); $col->name = 'type'; $col->data = function($page) { return $page->rockcontact_type->title; }; $dt2->cols->add($col); // modified $col = new dtCol(); $col->name = 'modified'; $col->data = function($page) { $obj = new stdClass(); $obj->timestamp = $page->modified; $obj->display = date('d.m.Y', $page->modified); return $obj; }; $dt2->cols->add($col); // setup table $dt2->id = 'dt_kundenliste'; $dt2->js('/site/modules/ProcessRockProjects/dt_kundenliste.js'); $f = $modules->get('InputfieldMarkup'); $f->value = $dt2->render(); $form->add($f); // ################################## // ajax request -> return data // non-ajax -> render form + table // ################################## if($config->ajax) { echo $dt2->getJSON($pages->find('template=rockcontact, sort=random, limit=10000')); die(); } else $out .= $form->render(); return $out; what is interesting here is this part:
      // modified $col = new dtCol(); $col->name = 'modified'; $col->data = function($page) { $obj = new stdClass(); $obj->timestamp = $page->modified; $obj->display = date('d.m.Y', $page->modified); return $obj; }; $dt2->cols->add($col); datatables support orthogonal data (https://datatables.net/extensions/buttons/examples/html5/outputFormat-orthogonal.html). a date column is a good example, because you need to DISPLAY a formatted date (like 10.02.2017) but you need to be able to SORT this column by a different value (timestamp). its very easy to accomplish this by providing both values in your json. Btw: You could also just transfer the timestamp and do the formatting on the client-side via javascript. Next Example will show ho this would work. Both cases can be necessary, it's just an example here.
      [...] removed
      Why i created this module:
      of course i know @Soma s module but i needed a lot more features and the newer datatables version. also i like to define all the columns as objects and have everything on one place. lister & markupadmindatatable: nice for basic tables but lacks of features to modify the appearance of the cell values (like rendering icons, background colors and so on) datatables provides a great frontend API for filtering, showing/hiding columns, getting data, modifying it... it also plays well together with frontend charts like google chart api in this case:
       
      todo / roadmap:
      all kinds of column filters (like seen in the example above that shows an older and bloated version of this module) support for ajax filters and pagination (currently all filtering and sorting is done on the client side. i tried it with up to 50.000 rows and got reasonable results. initial loading took around 10sec. but of course this heavily depends on the complexity of your table and your data.  
       
       
    • By Robin S
      PageListTrash
      Allows non-superusers to trash pages directly from Page List (if they have page-delete permission for that page).
      Not much to say really - the module adds a "Trash" option to the extra actions for pages in Page List. It looks and works just like the Trash action available to superusers.

      https://github.com/Toutouwai/PageListTrash/
       
      Up to you whether you think non-superusers should be trusted with simpler trashing. For most cases I like the default behaviour where editors have to jump through some more hoops - I want them to think carefully about what they are doing. But if an editor needs to trash several pages then this module might reduce frustration.
      @tpr, by now you can probably predict what I'm going to say...
      ...something to merge into AdminOnSteroids?
    • By horst
      Wire Mail SMTP

      An extension to the new WireMail base class that uses SMTP-transport

      This module integrates EmailMessage, SMTP and SASL php-libraries from Manuel Lemos into ProcessWire. I use this continously evolved libraries for about 10 years now and there was never a reason or occasion not to do so. I use it nearly every day in my office for automated composing and sending personalized messages with attachments, requests for Disposition Notifications, etc. Also I have used it for sending personalized Bulkmails many times.

      The WireMailSmtp module extends the new email-related WireMail base class introduced in ProcessWire 2.4.1 (while this writing, the dev-branch only).
       
      Here are Ryans announcement.



      Current Version 0.2.5
      get it from the Modules Directory Install and Configure

      Download the module into your site/modules/ directory and install it.

      In the config page you fill in settings for the SMTP server and optionaly the (default) sender, like email address, name and signature.
      You can test the smtp settings directly there. If it says "SUCCESS! SMTP settings appear to work correctly." you are ready to start using it in templates, modules or bootstrap scripts.


      Usage Examples
      The simplest way to use it:
      $numSent = wireMail($to, $from, $subject, $textBody); $numSent = wireMail($to, '', $subject, $textBody); // or with a default sender emailaddress on config page This will send a plain text message to each recipient.
       
      You may also use the object oriented style:
      $mail = wireMail(); // calling an empty wireMail() returns a wireMail object $mail->to($toEmail, $toName); $mail->from = $yourEmailaddress; // if you don't have set a default sender in config // or if you want to override that $mail->subject($subject); $mail->body($textBody); $numSent = $mail->send(); Or chained, like everywhere in ProcessWire:
      $mail = wireMail(); $numSent = $mail->to($toEmail)->subject($subject)->body($textBody)->send(); Additionaly to the basics there are more options available with WireMailSmtp. The main difference compared to the WireMail BaseClass is the sendSingle option. With it you can set only one To-Recipient but additional CC-Recipients.
      $mail = wireMail(); $mail->sendSingle(true)->to($toEmail, $toName)->cc(array('person1@example.com', 'person2@example.com', 'person3@example.com')); $numSent = $mail->subject($subject)->body($textBody)->send(); The same as function call with options array:
      $options = array( 'sendSingle' => true, 'cc' => array('person1@example.com', 'person2@example.com', 'person3@example.com') ); $numSent = wireMail($to, '', $subject, $textBody, $options); There are methods to your disposal to check if you have the right WireMail-Class and if the SMTP-settings are working:
      $mail = wireMail(); if($mail->className != 'WireMailSmtp') { // Uups, wrong WireMail-Class: do something to inform the user and quit echo "<p>Couldn't get the right WireMail-Module (WireMailSmtp). found: {$mail->className}</p>"; return; } if(!$mail->testConnection()) { // Connection not working: echo "<p>Couldn't connect to the SMTP server. Please check the {$mail->className} modules config settings!</p>"; return; } Following are a ...


      List of all options and features


      testConnection () - returns true on success, false on failures


      sendSingle ( true | false ) - default is false

      sendBulk ( true | false ) - default is false, Set this to true if you have lots of recipients (50+)


      to ($recipients) - one emailaddress or array with multiple emailaddresses

      cc ($recipients) - only available with mode sendSingle, one emailaddress or array with multiple emailaddresses

      bcc ($recipients) - one emailaddress or array with multiple emailaddresses

       
      from = 'person@example.com' - emailaddress, can be set in module config (called Sender Emailaddress) but it can be overwritten here

      fromName = 'Name Surname' - optional, can be set in module config (called Sender Name) but it can be overwritten here


      priority (3) - 1 = Highest | 2 = High | 3 = Normal | 4 = Low | 5 = Lowest

      dispositionNotification () or notification () - request a Disposition Notification


      subject ($subject) - subject of the message

      body ($textBody) - use this one alone to create and send plainText emailmessages

      bodyHTML ($htmlBody) - use this to create a Multipart Alternative Emailmessage (containing a HTML-Part and a Plaintext-Part as fallback)

      addSignature ( true | false ) - the default-behave is selectable in config screen, this can be overridden here
      (only available if a signature is defined in the config screen)

      attachment ($filename, $alternativeBasename = "") - add attachment file, optionally alternative basename


      send () - send the message(s) and return number of successful sent messages


      getResult () - returns a dump (array) with all recipients (to, cc, bcc) and settings you have selected with the message, the message subject and body, and lists of successfull addresses and failed addresses,


      logActivity ($logmessage) - you may log success if you want

      logError ($logmessage) - you may log warnings, too. - Errors are logged automaticaly
       
       
      useSentLog (true | false) - intended for usage with e.g. third party newsletter modules - tells the send() method to make usage of the sentLog-methods - the following three sentLog methods are hookable, e.g. if you don't want log into files you may provide your own storage, or add additional functionality here

      sentLogReset ()  - starts a new LogSession - Best usage would be interactively once when setting up a new Newsletter

      sentLogGet ()  - is called automaticly within the send() method - returns an array containing all previously used emailaddresses

      sentLogAdd ($emailaddress)  - is called automaticly within the send() method
       
      Changelog: https://github.com/horst-n/WireMailSmtp/blob/master/CHANGELOG.md
       
    • By celfred
      Hello,
      I'm desperately trying to update my website to PW 3.0.62 and I'm facing issues to to module compatibility. I was stuck with Pages2Pdf which I managed to solve bu updating the module from Github, but now it's the Pages Web Service module... and this time, I don't know wht to do
      The Module is found there. But it is quite old and I can't find it in the modules catalogue... and my site is making quite a use of it (I can't think of a way to do otherwise, sorry...)
      After adding the FileCompiler=0 to the module pages, the error I'm stuck with is :
      Fatal error: Class 'WireData' not found in /home/celfred/PlanetAlert/site/modules/ServicePages/ServicePages.module on line 22
      and I have no idea on what to do... I must admit I'm not a programmer but a middle-school teacher... (for your information, here's the site I'm talking about : http://planetalert.tuxfamily.org ) but I'm struggling hard to solve the different issues I have to face and I'm wlling to understand things. I have just spent many hours trying to make 2.8 work on my localhost (and it seems ok ) but I'd like to switch to 3.x to prepare the future
      If anyone had the will to spend a few minutes to try and help me, I would greatly appreciate.
      Thanks in advance !
      If you need more information to understand my problem, feel free to ask.
    • By dimitrios
      Hello,
      I have created a module that, given a Facebook app ID and secret, posts on Facebook on behalf of a user profile or page after a PW page is saved.
      This module is configurable as follows:
      Templates: posts can take place only for pages with the defined templates On/Off switch: specify a checkbox field that will not allow the post if checked Specify a message and/or an image for the post
      Usage
      edit the desired PW page and save; it will post right after the initial Facebook log in and permission granting. After that, a token is kept.
       
      Download
      PW module directory: http://modules.processwire.com/modules/auto-fb-post/ Github: https://github.com/kastrind/AutoFbPost   Note: Facebook SDK for PHP is used.