tpr

AdminOnSteroids

Recommended Posts

Hi @theo,

please try this and see if you can manage to make it work.

What would be handy here having an ajax button to check whether these assets exist.

AdminOnSteroids.module

Share this post


Link to post
Share on other sites
13 hours ago, tpr said:

Hi @theo,

please try this and see if you can manage to make it work.

What would be handy here having an ajax button to check whether these assets exist.

AdminOnSteroids.module

Thank you Roland.

But I can't make it work.

I show you what I did to test it. There are 6 "echos" marked like (0) ... (5). Code snippet is from about line 989 of the module.

        echo $root.' (0)<br>';
        echo $rootPath.' (1)<br>';

        // remove install subdirectory
        $rootPath = rtrim($rootPath, $root);
        echo $rootPath.' (2)<br>';

        $rootUrl = $this->config->urls->httpRoot;
        $rootUrl = rtrim($rootUrl, $root);

        $templatesUrlRelative = $this->config->urls->templates;
        
        echo $rootUrl.' (3) <br>';
        echo $templatesUrlRelative.' (4)<br>';

        // do not add JS to page on login page
        if ($this->page->id != 23) {

            // custom CKEaddons config js and css

            $ckeCSS = $this->getAssetPath('CKEStyle', 'admin/cke.css', $templatesUrlRelative, $configData, $root);
            $ckeJS = $this->getAssetPath('CKEScript', 'admin/cke.js', $templatesUrlRelative, $configData, $root);
            $ckeTemplates = $this->getAssetPath('CKEtemplates', 'admin/templates.js', $templatesUrlRelative,
                $configData, $root);
                
            echo $rootPath . $ckeJS.' (5)<br>';

This outputs:

/~theo/pw3061/ (0)
/home/theo/public_html/pw3061 (1)
/home/theo/public_html (2)
http://localhos (3)
/~theo/pw3061/site/templates/ (4)
/home/theo/public_html/~theo/pw3061/site/templates/admin/cke.js (5)

Where settings are:

Assets Root Path: /home/theo/public_html/pw3061/

CKEditor custom configuration script: /site/templates/admin/cke.js

 

Thank you.

Share this post


Link to post
Share on other sites

I'm thinking of removing the default paths and load only files that the user has written something into the inputs, and also remove the file_exists() limitation. So it would be entirely the user's responsibility to add an asset that is surely available (to avoid 404s).

Share this post


Link to post
Share on other sites
3 minutes ago, tpr said:

I'm thinking of removing the default paths and load only files that the user has written something into the inputs, and also remove the file_exists() limitation. So it would be entirely the user's responsibility to add an asset that is surely available (to avoid 404s).

I don't know PW well enough, but isn't there a setting anywhere to get or set (in my case:)

rootURL: http://localhost/~theo/pw3061/

rootPath: /home/theo/public_html/pw3061/

It think this would be handy in many situations. I'm usually setting such values in init.php, but it should probably go to config.php as a PW standard variable.

Or does sth. like this already exist?

 

Share this post


Link to post
Share on other sites

AFAIK you can overwrite some paths/urls but I wouldn't use it if not necessary (to avoid breaking things).

I'll implement the idea I wrote above, that would simplify things a lot (although autoloading assets will be gone).

Share this post


Link to post
Share on other sites
1 hour ago, tpr said:

I'll implement the idea I wrote above, that would simplify things a lot (although autoloading assets will be gone).

OK, thank you.

Share this post


Link to post
Share on other sites

Here are the updates. You can use absolute (fully qualified) or relative paths (relative to site root).

aos-assetpaths.gif.86282f210bcb85034d5dbbda9825827a.gif

 

aos-assetpaths.zip

  • Like 1

Share this post


Link to post
Share on other sites
On 14.5.2017 at 10:16 PM, tpr said:

Btw there are a few filterboxes: a "general" one for datatables, one for the Language Translator and one for File fields, are you covering them all?

Yes, i try to support all filterboxes. Sadly right now I am busy with some projects. Hope I find the time to finish this soon.

  • Like 1

Share this post


Link to post
Share on other sites

The last update made Notices appear at some of our websites (not on all):


Notice: Undefined index: CKEStyle in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: CKEScript in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: CKEtemplates in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: AdminStyle in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: AdminScript in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Share this post


Link to post
Share on other sites

Thanks, please re-download (only .module file was changed).

  • Like 1

Share this post


Link to post
Share on other sites

A new pagelist action "Refresh" will be added in the next update. This refreshes the displayed page data in the page list + reloads children too. Can be useful if you renamed or deleted pages in another browser tab and would like to save a page reload :) 

aos-refresh-action.gif

  • Like 1

Share this post


Link to post
Share on other sites

hi @tpr

i just found a bug when using latest version of AOS (just did the update from 1.4.1 to 1.4.6). it also existed in the later version.

i have a repeater including an image field and an "editor" role with edit-access for the home-template (and all children). the problem is that the image in the repeater field gets uploaded and after reaching 100% disappears. i did some debugging and i found out the following:

  • aos uninstalled: works
  • aos installed: does not work (either enabled or disabled)
  • upload as superuser works at all setups
  • ajax error after fileupload: {"error":false,"message":"The requested process does not exist"}
  • when i try to edit the repeater item directly ( /admin/page/edit/?id=1024&InputfieldFileAjax=1 ) in the admin i get this error:
    59317c4d1da3b_2017-06-0216_54_51-ProgramManager.png.416cf1bd70f1a500fee7a57143be2282.png
 
i hope i was clear enough with my informations so that you can fix this as easy as possible :) if you need more information just let me know!
 
PS: regular image fields outside repeaters work as expected

Share this post


Link to post
Share on other sites

I have a site with similar editor role and could not reproduce the issue. You could try uncommenting things above these lines in init() and ready() functions and see where it fails:

if (!$this->enabled) {
	return;
}

Only lines above these will be run if you have disabled AOS in its settings page.

By any chance have you added new permission from these pre-defined ones? I had a site where "page-edit-created" caused similar issues if I remember right.

new-roles.thumb.png.b234308988efc9e5a206df516892f856.png

Share this post


Link to post
Share on other sites

Thanks! Could you try replacing the line 408 with this, and check if it fixes the issue and doesn't break other things? I clicked around in the admin and everything seems to be fine (in another PW).

Update: there was an issue with the previous fix, pls try this (lines 408-414):

        $editedPageId = $this->input->get->id ? $this->sanitizer->int($this->input->get->id) : false;

        if ($editedPageId && is_numeric($editedPageId) && $this->pages->find('id=' . $editedPageId . ',check_access=0')->count()) {
            $this->editedPage = $this->pages->find('id=' . $editedPageId . ',check_access=0')->first();
        } else {
            $this->editedPage = null;
        }

 

Share this post


Link to post
Share on other sites

Hi @tpr, I spotted an issue with the position of the InputfieldPageListSelect restore icon when the inputfield's width is not the last/only inputfield in a row:

2017-06-08_121232.png.61e391db43d0b800e7bc14c5aa272f7c.png

I fixed it with this:

html.aos .InputfieldPageListSelect { position:relative; }
.aos_pagelist_unselect.restore { right:0; transform:none; -webkit-transform:none; }

 

  • Like 1

Share this post


Link to post
Share on other sites

Thanks, this part was always buggy but I think I've found a better way, namely floating clear btn and pagelist to the left, and setting pagelist width using calc(). It's OK here in Firefox and Chrome, even with long page titles, could you try?

unselect-placement.thumb.png.ac12031b3f4377807a29250df6877dcd.png

AdminOnSteroids.css

  • Like 1

Share this post


Link to post
Share on other sites
1 hour ago, tpr said:

It's OK here in Firefox and Chrome, even with long page titles, could you try?

Works great, thanks!

  • Like 1

Share this post


Link to post
Share on other sites

Hi,
I having a problem with image field inside a repeater field and with extra image fields and user profiles and the AdminOnSteroids.

With the superuser profile there is no problem, but the user has other profile then superuser the image in the repeater field does not show the image after upload and do not save the image and the extra image fields does not show correctly  (each language in a row) and the internal link selector does not work and does not show any error.

After a week trying to understand why the non superuser users where not able to upload the images and creating new fields to verify if the originals ones where with some kind of problem I come to the conclusion that the problem where not the fields on them selfs but with some module that was causing this behavior.

After trying to disable the module a tweak the AdminOnSteroids configurations the only thing that work for me was to uninstall the module and the users can upload the image the the extra image fields show correctly.

Its is a great module and I hope you can resolve this issue.

Thank you

Share this post


Link to post
Share on other sites
3 hours ago, vmo said:

having a problem with image field inside a repeater

It's the same issue as of @bernhard's, could you try the fix I posted on June 2?

  • Like 1

Share this post


Link to post
Share on other sites

sorry for my late reply! your fix didn't work for me. curious if it helps vmo...

Share this post


Link to post
Share on other sites

@tpr, I've been having a look at the images-in-repeater issue for non-superusers (I discovered this one a while back but forgot to report it here, sorry :().

-----

Edit: I did report it over in the Github repo.

Edit 2: looking at some PM history it looks like a solution (same intent but different implementation to that proposed below) was found but never merged into the repo?

-----

As you found, the $this->editedPage property is the source of the issue. Seeing as the things this property is used for within the module either don't work within repeaters (e.g. field edit links) or aren't needed for repeater pages (e.g. breadcrumb features) I think $this->editedPage should never be set to a repeater page. But it's much easier to exclude repeater pages in ready() because in init() it is not yet known which class a page is an instance of. So could $this->editedPage be set in ready() instead?

This is what I did in my testing and it seems to work okay:

public function init()
{
    // removed code that sets $this->edited page
    
    // populate self::$configData
    self::$configData = $this->modules->getModuleConfigData($this);
    
    // ...
    
    // a bit further down we need to change $configData[$subModule] to self::$configData[$subModule]
public function ready()
{
    // set $this->editedPage
    // excluded repeater pages, minor refactoring
    $this->editedPage = false;
    $editedPageId = $this->sanitizer->int($this->config->input->get->id);
    $editedPage = $this->pages->get($editedPageId);
    if( $editedPage->id && !($editedPage instanceof RepeaterPage) ) $this->editedPage = $editedPage;

    self::$configData = $this->modifyConfigData(
        $this->modules->getModuleConfigData($this),
        $this->editedPage
    );
    
    // ...

 

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By netcarver
      Part 1 of a 2 part Module & Service Reveal.
      I'm currently working on a new module: ModuleReleaseNotes that was inspired by the work I originally did on making Ryan's ProcessWireUpgrades module "release" aware. In the end, I decided to ditch the approach I was originally taking and instead work on a module that hooked in to the UpgradeConfirmation dialog and the module edit page.
      Aims
      My aims for this module are as follows...
      Make discovery of a module's changes prior to an upgrade a trivial task. Make breaking changes very obvious. Make reading of a module's support documentation post-install a trivial task. Make module authors start to think about how they can improve the change discovery process for their modules. Make sure the display of information from the module support files/commit messages doesn't introduce a vulnerability. Looking at these in turn...
      Making discovery of a module's changes prior to upgrade a trivial task.
      This is done by adding a "What's changed section" to the upgrade confirmation dialog.  This section takes a best-effort approach to showing what's changed between the installed version and the updated version that's available via the module repository.
      At present, it is only able to talk to github-hosted repositories in order to ask them for the release notes, the changelog file (if present) and a list of commits between the git tag that matches the installed version and the tag matching the latest version.
      It will display the Release Notes (if the author is using the feature), else it will display the commits between the tags (if tagging is used by the module author) else it will show the changelog file (if present) else it will show the latest N commits on the master branch (N, of course, being configurable to your liking.)
      An example of the Github Release Notes pulled in for you, taken from Mike Rockett's TextformatterTypographer Module...

      An example of a tag-to-tag commit list from the same module...

      An example of a changelog - formatted to show just the changes (formatting styles will change)...

      Finally, an example of a fallback list of commits - sorry Adrian ...

       
      Making breaking changes obvious.
      This is currently done by searching for a set of configurable search strings. Later versions may be able to support breaking change detection via use of Semantic Versioning - but this may require some way of signalling the use of this versioning standard on a module-by-module basis.
      For now, then, you can customise the default set of change markers. Here I have added my own alias to the list of breaking change markers and the changes section of the changelog is styled accordingly (these will be improved)...

       
      Make reading of a module's support documentation, post-install, a trivial task.
      This is done by making some of the support files (like the README, CHANGELOG and LICENSE files) readable from the module's information/settings screen. There is an option to control the initial open/closed state of this section...

      Here is Tracy's README file from within the module settings page... 

       
      Make module authors start to think about how they can improve the change discovery process for their modules.
      There are notes in each of the sections displayed on the upgrade confirmation page that help authors use each of the features...

       
      Make sure display of external information doesn't introduce a vulnerability.
      This is an ongoing concern, and is the thing that is most likely to delay or prevent this module's release lead to this module's withdrawl should a vulnerability be found. Currently, output is formatted either via Markdown + HTML Purifier (if it was originally a Markdown file) or via htmlspecialchars() if it has come from a plaintext file.
      If you discover a vulnerability, please get in contact with me via the forum PM system.
       
      Ongoing...
      For now, I've concentrated on integration with GitHub, as most people use that platform to host their code. I know a few people are hosting their repositories with BitBucket (PWFoo comes to mind) and some with GitLab (Mike Rockett?) and I would eventually like to have adaptor implementations for these providers (and perhaps GitKraken) - but for now, GitHub rules and the other hosts are unsupported.
       
      Links
      Github: ModuleReleaseNotes
      PW Module Repository: Here
    • By FrancisChung
      Hi,
      I was wondering if anyone knew what this did? 

      If so, do you know what modules it actually impacts? Is there another log that lists the action it took?

      I'm having some weird problems with PHP duplicate declaration per link below, since this module was run.
       
       
    • By Macrura
      Field Descriptions Extended
      This module enables you to extend field descriptions by dividing short descriptions with a longer text that is revealed in a toggle.
      Github: https://github.com/outflux3/FieldDescriptionsExtended
      Extending your field descriptions using the standard field's description field.
      Once this module is installed, it will automatically search your description field for the presence of 5 dashes (-----).
      Any content above the 5 dashes will be visible and the content below the dashes will be hidden. A 'More...' link will appear at the end of the short description which when clicked will reveal the rest of the description.
      Using Simple Markdown Editor with the description field
      If you have Simple Markdown Editor (InputfieldSimpleMDE) installed, you can enable the field description to have that editor.
      *When using Simple MDE, you can use the button (Insert Horizontal Line) instead of typing 5 dashes. More about SimpleMDE.
      Extending your field descriptions using content from a ProcessWire Page for the field description.
      You may use the content from a ProcessWire page as a field description. This would allow you to easily insert images, links, and use hanna codes.
      To use page content for your field descriptions, please follow these instructions:
      Install Select Fields module (FieldtypeFields) http://modules.processwire.com/modules/fieldtype-fields/ Create a new field using this field type, e.g. field_select. Add the field to any template you will be using for your field descriptions. Setup your help pages (for example under a settings branch) where you will store the field description content,using the template containing the Field Select. Add content to a page and select the field where that content should show. To show a short text before the link to the longer content, separate them with 5 dashes Be sure to update your settings on this page, first enable page content descriptions,then specify the name of the Select Fields field, template to search, and content field. If you create a field description using this method, please note that the description field must be blank for contexts where you want the page content to appear.
      You can freely use template context for field descriptions, but the Page Content method is not context sensitive and will display under all contexts where the description is blank.
      ----
      original post:
      This is a new module, hope to release soon, which allows extended field descriptions, in currently 2 ways.
      The main feature of the module is that you can have a short description and then a 'more...' link which drops down a longer block of text.
      This is achieved by separating the intro/visible text and the rest with 5 dashes.

      Example setup:

      the 2nd way is if you are using AdminThemeUiKit, you can show extended field instructions in a panel. The content of the panel is edited on a regular PW page. This use case would probably not be that common, but if you had a field that required some extended instructions for how to use, this could be useful; Also, since this allows you to target information and instructions down at the field level, it could reduce the amount of documentation needed on a global level, since it is a lot more context targeted.

    • By blynx
      Hej,
      A module which helps including Photoswipe and brings some modules for rendering gallery markup. Feedback highly appreciated

      Modules directory: http://modules.processwire.com/modules/markup-processwire-photoswipe
      .zip download: https://github.com/blynx/MarkupProcesswirePhotoswipe/archive/master.zip
      You can add a photoswipe enabled thumbnail gallery / lightbox to your site like this. Just pass an image field to the renderGallery method:
      <?php $pwpswp = $modules->get('Pwpswp'); echo $pwpswp->renderGallery($page->nicePictures); Options are provided like so:
      <?php $galleryOptions = [ 'imageResizerOptions' => [ 'size' => '500x500' 'quality' => 70, 'upscaling' => false, 'cropping' => false ], 'loresResizerOptions' => [ 'size' => '500x500' 'quality' => 20, 'upscaling' => false, 'cropping' => false ], 'pswpOptions' => (object) [ 'shareEl' => false, 'indexIndicatorSep' => ' von ', 'closeOnScroll' => false ] ]; echo $pswp->renderGallery($page->images, $galleryOptions); More info about all that is in the readme: https://github.com/blynx/MarkupProcesswirePhotoswipe
      What do you think? Any ideas, bugs, critique, requests?
      cheers
      Steffen
    • By mtwebit
      Tasker is a module to handle and execute long-running jobs in Processwire. It provides a simple API  to create tasks (stored as PW pages), to set and query their state (Active, Waiting, Suspended etc.), and to execute them via Cron, LazyCron or HTTP calls.
      Creating a task
      $task = wire('modules')->Tasker->createTask($class, $method, $page, 'Task title', $arguments); where $class and $method specify the function that performs the job, $page is the task's parent page and $arguments provide optional configuration for the task.
      Executing a task
      You need to activate a task first
      wire('modules')->Tasker->activateTask($task); then Tasker will automatically execute it using one of its schedulers: Unix cron, LazyCron or TaskerAdmin's REST API + JS client.
      Getting the job done
      Your method that performs the task looks like
      public function longTask($page, &$taskData, $params) { ... } where $taskData is a persistent storage and $params are run-time options for the task.
      Monitoring progress, management
      The TaskerAdmin module provides a Javascript-based front-end to list tasks, to change their state and to monitor their progress (using a JQuery progressbar and a debug log area). It also allows the on-line execution of tasks using periodic HTTP calls performed by Javascript.

       
      Monitoring task progress (and log messages if debug mode is active)

       
      Task data and log

      Detailed info (setup, task dependencies, time limits, REST API etc.) and examples can be found on GitHub.
      This is my first public PW module. I'm sure it needs improvement