tpr

AdminOnSteroids

Recommended Posts

Hi @theo,

please try this and see if you can manage to make it work.

What would be handy here having an ajax button to check whether these assets exist.

AdminOnSteroids.module

Share this post


Link to post
Share on other sites
13 hours ago, tpr said:

Hi @theo,

please try this and see if you can manage to make it work.

What would be handy here having an ajax button to check whether these assets exist.

AdminOnSteroids.module

Thank you Roland.

But I can't make it work.

I show you what I did to test it. There are 6 "echos" marked like (0) ... (5). Code snippet is from about line 989 of the module.

        echo $root.' (0)<br>';
        echo $rootPath.' (1)<br>';

        // remove install subdirectory
        $rootPath = rtrim($rootPath, $root);
        echo $rootPath.' (2)<br>';

        $rootUrl = $this->config->urls->httpRoot;
        $rootUrl = rtrim($rootUrl, $root);

        $templatesUrlRelative = $this->config->urls->templates;
        
        echo $rootUrl.' (3) <br>';
        echo $templatesUrlRelative.' (4)<br>';

        // do not add JS to page on login page
        if ($this->page->id != 23) {

            // custom CKEaddons config js and css

            $ckeCSS = $this->getAssetPath('CKEStyle', 'admin/cke.css', $templatesUrlRelative, $configData, $root);
            $ckeJS = $this->getAssetPath('CKEScript', 'admin/cke.js', $templatesUrlRelative, $configData, $root);
            $ckeTemplates = $this->getAssetPath('CKEtemplates', 'admin/templates.js', $templatesUrlRelative,
                $configData, $root);
                
            echo $rootPath . $ckeJS.' (5)<br>';

This outputs:

/~theo/pw3061/ (0)
/home/theo/public_html/pw3061 (1)
/home/theo/public_html (2)
http://localhos (3)
/~theo/pw3061/site/templates/ (4)
/home/theo/public_html/~theo/pw3061/site/templates/admin/cke.js (5)

Where settings are:

Assets Root Path: /home/theo/public_html/pw3061/

CKEditor custom configuration script: /site/templates/admin/cke.js

 

Thank you.

Share this post


Link to post
Share on other sites

I'm thinking of removing the default paths and load only files that the user has written something into the inputs, and also remove the file_exists() limitation. So it would be entirely the user's responsibility to add an asset that is surely available (to avoid 404s).

Share this post


Link to post
Share on other sites
3 minutes ago, tpr said:

I'm thinking of removing the default paths and load only files that the user has written something into the inputs, and also remove the file_exists() limitation. So it would be entirely the user's responsibility to add an asset that is surely available (to avoid 404s).

I don't know PW well enough, but isn't there a setting anywhere to get or set (in my case:)

rootURL: http://localhost/~theo/pw3061/

rootPath: /home/theo/public_html/pw3061/

It think this would be handy in many situations. I'm usually setting such values in init.php, but it should probably go to config.php as a PW standard variable.

Or does sth. like this already exist?

 

Share this post


Link to post
Share on other sites

AFAIK you can overwrite some paths/urls but I wouldn't use it if not necessary (to avoid breaking things).

I'll implement the idea I wrote above, that would simplify things a lot (although autoloading assets will be gone).

Share this post


Link to post
Share on other sites
1 hour ago, tpr said:

I'll implement the idea I wrote above, that would simplify things a lot (although autoloading assets will be gone).

OK, thank you.

Share this post


Link to post
Share on other sites

Here are the updates. You can use absolute (fully qualified) or relative paths (relative to site root).

aos-assetpaths.gif.86282f210bcb85034d5dbbda9825827a.gif

 

aos-assetpaths.zip

  • Like 1

Share this post


Link to post
Share on other sites
On 14.5.2017 at 10:16 PM, tpr said:

Btw there are a few filterboxes: a "general" one for datatables, one for the Language Translator and one for File fields, are you covering them all?

Yes, i try to support all filterboxes. Sadly right now I am busy with some projects. Hope I find the time to finish this soon.

  • Like 1

Share this post


Link to post
Share on other sites

The last update made Notices appear at some of our websites (not on all):


Notice: Undefined index: CKEStyle in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: CKEScript in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: CKEtemplates in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: AdminStyle in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Notice: Undefined index: AdminScript in /Users/.../site/modules/AdminOnSteroids/AdminOnSteroids.module on line 1012

Share this post


Link to post
Share on other sites

Thanks, please re-download (only .module file was changed).

  • Like 1

Share this post


Link to post
Share on other sites

A new pagelist action "Refresh" will be added in the next update. This refreshes the displayed page data in the page list + reloads children too. Can be useful if you renamed or deleted pages in another browser tab and would like to save a page reload :) 

aos-refresh-action.gif

  • Like 1

Share this post


Link to post
Share on other sites

hi @tpr

i just found a bug when using latest version of AOS (just did the update from 1.4.1 to 1.4.6). it also existed in the later version.

i have a repeater including an image field and an "editor" role with edit-access for the home-template (and all children). the problem is that the image in the repeater field gets uploaded and after reaching 100% disappears. i did some debugging and i found out the following:

  • aos uninstalled: works
  • aos installed: does not work (either enabled or disabled)
  • upload as superuser works at all setups
  • ajax error after fileupload: {"error":false,"message":"The requested process does not exist"}
  • when i try to edit the repeater item directly ( /admin/page/edit/?id=1024&InputfieldFileAjax=1 ) in the admin i get this error:
    59317c4d1da3b_2017-06-0216_54_51-ProgramManager.png.416cf1bd70f1a500fee7a57143be2282.png
 
i hope i was clear enough with my informations so that you can fix this as easy as possible :) if you need more information just let me know!
 
PS: regular image fields outside repeaters work as expected

Share this post


Link to post
Share on other sites

I have a site with similar editor role and could not reproduce the issue. You could try uncommenting things above these lines in init() and ready() functions and see where it fails:

if (!$this->enabled) {
	return;
}

Only lines above these will be run if you have disabled AOS in its settings page.

By any chance have you added new permission from these pre-defined ones? I had a site where "page-edit-created" caused similar issues if I remember right.

new-roles.thumb.png.b234308988efc9e5a206df516892f856.png

Share this post


Link to post
Share on other sites

thanks for your answer. i tried it on a fresh install on my local dev and had the same issue. i created a zip of the installation so you can try:

https://transfer.sh/eAZ7L/reptest.zip (8,5MB)

admin url /processwire

admin
admin!

test
tprtest1!

reptest.gif.f70de65905220ec95829c5ce3c34811b.gif

Share this post


Link to post
Share on other sites

Thanks! Could you try replacing the line 408 with this, and check if it fixes the issue and doesn't break other things? I clicked around in the admin and everything seems to be fine (in another PW).

Update: there was an issue with the previous fix, pls try this (lines 408-414):

        $editedPageId = $this->input->get->id ? $this->sanitizer->int($this->input->get->id) : false;

        if ($editedPageId && is_numeric($editedPageId) && $this->pages->find('id=' . $editedPageId . ',check_access=0')->count()) {
            $this->editedPage = $this->pages->find('id=' . $editedPageId . ',check_access=0')->first();
        } else {
            $this->editedPage = null;
        }

 

Share this post


Link to post
Share on other sites

Hi @tpr, I spotted an issue with the position of the InputfieldPageListSelect restore icon when the inputfield's width is not the last/only inputfield in a row:

2017-06-08_121232.png.61e391db43d0b800e7bc14c5aa272f7c.png

I fixed it with this:

html.aos .InputfieldPageListSelect { position:relative; }
.aos_pagelist_unselect.restore { right:0; transform:none; -webkit-transform:none; }

 

  • Like 1

Share this post


Link to post
Share on other sites

Thanks, this part was always buggy but I think I've found a better way, namely floating clear btn and pagelist to the left, and setting pagelist width using calc(). It's OK here in Firefox and Chrome, even with long page titles, could you try?

unselect-placement.thumb.png.ac12031b3f4377807a29250df6877dcd.png

AdminOnSteroids.css

  • Like 1

Share this post


Link to post
Share on other sites
1 hour ago, tpr said:

It's OK here in Firefox and Chrome, even with long page titles, could you try?

Works great, thanks!

  • Like 1

Share this post


Link to post
Share on other sites

Hi,
I having a problem with image field inside a repeater field and with extra image fields and user profiles and the AdminOnSteroids.

With the superuser profile there is no problem, but the user has other profile then superuser the image in the repeater field does not show the image after upload and do not save the image and the extra image fields does not show correctly  (each language in a row) and the internal link selector does not work and does not show any error.

After a week trying to understand why the non superuser users where not able to upload the images and creating new fields to verify if the originals ones where with some kind of problem I come to the conclusion that the problem where not the fields on them selfs but with some module that was causing this behavior.

After trying to disable the module a tweak the AdminOnSteroids configurations the only thing that work for me was to uninstall the module and the users can upload the image the the extra image fields show correctly.

Its is a great module and I hope you can resolve this issue.

Thank you

Share this post


Link to post
Share on other sites
3 hours ago, vmo said:

having a problem with image field inside a repeater

It's the same issue as of @bernhard's, could you try the fix I posted on June 2?

  • Like 1

Share this post


Link to post
Share on other sites

sorry for my late reply! your fix didn't work for me. curious if it helps vmo...

Share this post


Link to post
Share on other sites

@tpr, I've been having a look at the images-in-repeater issue for non-superusers (I discovered this one a while back but forgot to report it here, sorry :().

-----

Edit: I did report it over in the Github repo.

Edit 2: looking at some PM history it looks like a solution (same intent but different implementation to that proposed below) was found but never merged into the repo?

-----

As you found, the $this->editedPage property is the source of the issue. Seeing as the things this property is used for within the module either don't work within repeaters (e.g. field edit links) or aren't needed for repeater pages (e.g. breadcrumb features) I think $this->editedPage should never be set to a repeater page. But it's much easier to exclude repeater pages in ready() because in init() it is not yet known which class a page is an instance of. So could $this->editedPage be set in ready() instead?

This is what I did in my testing and it seems to work okay:

public function init()
{
    // removed code that sets $this->edited page
    
    // populate self::$configData
    self::$configData = $this->modules->getModuleConfigData($this);
    
    // ...
    
    // a bit further down we need to change $configData[$subModule] to self::$configData[$subModule]
public function ready()
{
    // set $this->editedPage
    // excluded repeater pages, minor refactoring
    $this->editedPage = false;
    $editedPageId = $this->sanitizer->int($this->config->input->get->id);
    $editedPage = $this->pages->get($editedPageId);
    if( $editedPage->id && !($editedPage instanceof RepeaterPage) ) $this->editedPage = $editedPage;

    self::$configData = $this->modifyConfigData(
        $this->modules->getModuleConfigData($this),
        $this->editedPage
    );
    
    // ...

 

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By thomasaull
      Some time ago I created a site profile for creation of a REST API with ProcessWire. Since I kept struggeling with updating stuff between different projects which use this, I decided to convert it into a module. It is now ready for testing: https://github.com/thomasaull/RestApi
      Additionally I added a few small features:
      automatic creation of JWT Secret at module install routes can be flagged as auth: false, which makes them publicly accessible even though JWT Auth is activated in module settings To check things out, download and install the module and check the folder /site/api for examples.
      If you find any bugs or can think of improvements, please let me know!
    • By kongondo
      Sites Manager
       
      16 September 2018:
      FOR NOW, PLEASE DO NOT USE THIS MODULE IN A PRODUCTION SITE. A  RECENT ProcessWire UPDATE HAS BROKEN THE MODULE. I AM WORKING ON A FIX.
       
      ################
       
      Sites Manager is a module for ProcessWire that allows Superusers to easily create/install ProcessWire sites on the same serverspace the module is running in. Only Superusers can use the module. You can create both stand-alone and multi-sites.
       
      Single/Stand-alone Sites
      Stand-alone or single-sites are sites that will run in their own document root/directory with their own wire and site folders, .htaccess, index.php, etc. In other words, a normal ProcessWire site.
      Multiple Sites
      Multi-sites are sites that will run off one wire folder (shared amongst two or more sites) each having their own site folder and database. In this regard, it is important to note that Sites Manager is not in itself a multiple sites solution! Rather, it is a utility that helps you create multi-sites to be run using the ProcessWire core multiple sites feature. For more on this core feature, see the official ProcessWire documentation, specifically the solution referred to as Option #1.
      Option #1 approach requires the site admin to initially install ProcessWire in a temporary directory for each new site. The directory then needs to be renamed as site-xxx, where ‘xxx’ is any name you want to use to differentiate the installation from other sites, before it is moved to the webroot. For instance, site-mysite, site-another, site-whatever. In addition, the /wire/index.config.php file must be copied/moved to the webroot. Each time a site is added, the index.config.php has to be edited to add ‘domain’ => ‘site-directory’ key=>value pairs for the site. This process can become a bit tedious. This module aims to automate the whole multi-site site creation process.
      The module is based off the official ProcessWire installer. Creating a site is as simple as completing and submitting a single form! You also have the option to type and paste values or reuse a pre-defined install configuration.
       
      The module will:
      Install a ProcessWire site in your named directory, applying chmod values as specified
      Move the directory to your webroot
      Update/Create a Superuser account as per the submitted form, including setting the desired admin theme and colour
      For multi sites, update sites.json (used by index.config.php to get array of installed sites)
       
      For multi sites, the only difference in relation to the core multi-sites index.config.php is that this file is slightly different from the one that ships with ProcessWire.
      Download from GitHub: Sites Manager (Beta Release)
      Features
      Install unlimited number of sites in one (multi-sites) or independent (single-site) ProcessWire installs. Install by completing a Form, Typing or pasting in configurations or using pre-created install configurations. Choose an Admin Theme to auto-install along with the site installation. For single-sites installation, download, save and reuse ProcessWire versions of your choice. Install and maintain site profiles for reuse to create other sites. Create install configurations to speed up installation tasks. Client and server-side validation of site creation values. Edit uploaded profiles (e.g., replace profile file). Lock installed sites, configurations and profiles to prevent editing. Bulk delete items such as site profiles, installed site directories and/or databases (confirmation required for latter two). View important site details (admin login, chmod, etc). Links to installed sites home and admin pages. Timezones auto-complete/-suggest. Pre-requisites, Installation & Usage
      Please see the documentation.
      Technicalities/Issues
      Only Superusers can use the module.
      ProcessWire 2.7 - 3.x compatible
      Currently using ProcessWire 2.7 installer (install.php)
      For multi-sites, potential race condition when sites.json is being updated on a new site install vs. index.config.php accessing the json file?
      Not tested with sub-directory installs (for instance localhost/pw/my-site-here/)
      Currently not doing the extra/experimental database stuff (database charset and engine)
      Future Possibilities
      Install specified modules along with the ProcessWire install
      Profile previews?
      Credits
      @ryan: for the ProcessWire installer
      @abdus: for the index.config.php reading from JSON idea
      @swampmusic: for the challenge
      Video Demo
      Demo  showing how quick module works on a remote server [YMMV!]. Video shows downloading and processing two versions of ProcessWire (~takes 7 seconds) and installing a single/stand-alone ProcessWire 3 site using the new Admin Theme UI Kit (~2 seconds) on a remote server.
       
      Screens
      1

      2

       
       
    • By Robin S
      Breadcrumb Dropdowns
      Adds dropdown menus of page edit links to the breadcrumbs in Page Edit.

      Installation
      Install the Breadcrumb Dropdowns module. The module requires ProcessWire >= v3.0.83 and AdminThemeUikit.
      There is a checkbox option in the module config that determines if the breadcrumb dropdowns will include pages that the user does not have permission to edit.
      Features/details
      The module adds an additional breadcrumb item at the end for the currently edited page. That's because I think it's more intuitive for the dropdown under each breadcrumb item to show the item's sibling pages rather than the item's child pages. In the dropdown menus the current page and the current page's parents are highlighted in a crimson colour to make it easier to quickly locate them in case you want to edit the next or previous sibling page. Unpublished and hidden pages are indicated in the dropdowns with similar styling to that used in Page List. If the option to include uneditable pages is selected then those pages are indicated by italics with a reduced text opacity and the "not-allowed" cursor is shown on hover. There is a limit of 25 pages per dropdown for performance reasons and to avoid the dropdown becoming unwieldy. If the current user is allowed to add new pages under the parent page an "Add New" link is shown at the bottom of the breadcrumb dropdown. If the currently edited page has children or the user may add children, a caret at the end of the breadcrumbs reveals a dropdown of up to the first 25 children and/or an "Add New" link. Overriding the listed siblings for a page
      If you want to override the siblings that are listed in the dropdowns you can hook the BreadcrumbDropdowns::getSiblingsmethod and change the returned PageArray. For most use cases this won't be necessary.
      Incompatibilities
      This module replaces the AdminThemeUikit::renderBreadcrumbs method so will potentially be incompatible with other modules that hook the same method.
       
      https://modules.processwire.com/modules/breadcrumb-dropdowns/
      https://github.com/Toutouwai/BreadcrumbDropdowns
    • By bernhard
      Some of you might have followed the development of this module here: https://processwire.com/talk/topic/15524-previewdiscussion-rockdatatables/ . It is the successor of "RockDataTables" and requires RockFinder to get the data for the grid easily and efficiently. It uses the open source part of agGrid for grid rendering.
       
      WHY?
      ProcessWire is awesome for creating all kinds of custom backend applications, but where it is not so awesome in my opinion is when it comes to listing this data. Of course we have the built in page lister and we have ListerPro, but none of that solutions is capable of properly displaying large amounts of data, for example lists of revenues, aggregations, quick and easy sorts by the user, instant filter and those kind of features. RockGrid to the rescue 😉 
       
      Features/Highlights:
      100k+ rows Instant (client side) filter, search, sort (different sort based on data type, eg "lower/greater than" for numbers, "contains" for strings) extendable via plugins (available plugins at the moment: fullscreen, csv export, reload, batch-processing of data, column sum/statistics, row selection) all the agGrid features (cell renderers, cell styling, pagination, column grouping etc) vanilla javascript, backend and frontend support (though not all plugins are working on the frontend yet and I don't plan to support it as long as I don't need it myself)  
      Limitations:
      While there is an option to retrieve data via AJAX the actual processing of the grid (displaying, filtering, sorting) is done on the client side, meaning that you can get into troubles when handling really large datasets of several thousands of rows. agGrid should be one of the most performant grid options in the world (see the official example page with a 100k row example) and does a lot to prevent problems (such as virtual row rendering), but you should always have this limitation in mind as this is a major difference to the available lister options that do not have this limitation.
      Currently it only supports AdminThemeUikit and I don't plan to support any other admin theme.
       
      Download: https://gitlab.com/baumrock/FieldtypeRockGrid
      Installation: https://gitlab.com/baumrock/RockGrid/wikis/Installation
      Quikckstart: https://gitlab.com/baumrock/RockGrid/wikis/quickstart
      Further instructions: https://gitlab.com/baumrock/RockGrid/wikis/quickstart#further-instructions
      Changelog: https://gitlab.com/baumrock/FieldtypeRockGrid/raw/master/changelog.md
       
      Module status: alpha, License: MIT
      Note that every installation and uninstallation sends an anonymous google analytics event to my google analytics account. If you don't want that feel free to remove the appropriate lines of code before installation/uninstallation.
       
      Contribute:
      You can contribute to the development of this and other modules or just say thank you by
      testing, reporting issues and making PRs at gitlab liking this post buying me a drink: paypal.me/baumrock/5 liking my facebook page: facebook.com/baumrock hiring me for pw work: baumrock.com  
      Support: Please note that this module might not be as easy and plug&play as many other modules. It needs a good understanding of agGrid (and JavaScript in general) and it likely needs some looks into the code to get all the options. Please understand that I can not provide free support for every request here in the forum. I try to answer all questions that might also help others or that might improve the module but for individual requests I offer paid support for 60€ per hour (excl vat).
       
      Use Cases / Examples:
      Colored grid cells, Icons, Links etc. The Grid also has a "batcher" feature built in that helps communicating with the server via AJAX and managing resource intensive tasks in batches:

      Filters, PW panel links and instant reload on panel close:

      You can combine the grid with a chart library like I did with the (outdated) RockDataTables module:

    • By Ken Muldrew
      I'm trying to get a short routine to run once per day that will look at some pages and send a reminder email when that customer's subscription (yearly) is about to expire. When I run the code in a template then it works without issue, but inside my lazycron service routine, I get an "Error: Uncaught Error: Call to a member function get() on null" as if the database cannot be found. My autoload module is just the sample HelloWorld module included with ProcessWire, editted to perform this task. The whole of it is included below (I've stripped out the code that generates the email because it never gets past $pages->find):
       
      <?php namespace ProcessWire;
      /**
       * ProcessWire 'LazyCronLoad'  module
       *
       */
      class LazyCronLoad extends WireData implements Module {
          public static function getModuleInfo() {
              return array(
                  'title' => 'LazyCronLoad', 
                  'version' => 1, 
                  'summary' => 'Just loads a lazy cron callback.',
                  'singular' => true, 
                  'autoload' => true, 
                  );
          }
          public function init() {
              // initialize the hook in the AutoLoad module
              $this->addHook('LazyCron::everyDay', $this, 'myHook');
              
          }
          public function myHook(HookEvent $e) {
              // called once per day
              wire('log')->save('user_activities',' lazy cron service routine');
                  $transport_pages = $pages->find("template=aggregate-entry, aggregate_type.title='Transport'");
                  foreach ($transport_pages as $page) {
                      if (($page->purchase_date + 30325800 < time()) && ($page->purchase_date + 30412600 > time())) { // between 351 and 352 days
                          wire('log')->save('user_activities', $page->id . ' email reminder sent');
                          // send email
                  }
              }
          }        
          
      }
      The first wire('log') shows up but the second one doesn't (the purchase_date condition is met (as demonstrated by running the code in a template close in time to when the lazycron routine executes)). The error log gives the Uncaught Error shown above. 
      I think this is a beginner's mistake with something obvious being missed and would be grateful for any assistance in fixing it.