tpr

AdminOnSteroids

Recommended Posts

bernhard    1,328
4 minutes ago, tpr said:

For ckeditor there is already a Maximize plugin in aos (ckeaddons).

i am quite busy those days so i missed that ;)

6 minutes ago, tpr said:

As for the other fields the biggest issue is the button placement, or finding another solution to trigger.

yeah i was not sure about that as well. i thought of placing it beside the open/close toggle of the field label.

Share this post


Link to post
Share on other sites
szabesz    1,390
11 hours ago, tpr said:

For ckeditor there is already a Maximize plugin in aos (ckeaddons).

Hi @tpr Should ctrl+S/command+S trigger the save action in the maximized view as well? It does not work for me on Mac/Chrome.

Share this post


Link to post
Share on other sites
tpr    2,229

It seems that the Maximize plugin replaces the DOM entirely and there's no Save button at all. My only idea is to trigger a click on the pushed Maximize button which works, though the transition to the non-maximized state is visible for a few milliseconds.

  • Like 1

Share this post


Link to post
Share on other sites
szabesz    1,390
5 minutes ago, tpr said:

...non-maximized state is visible for a few milliseconds

Better than nothing :) It would be awesome if you could add it.

Share this post


Link to post
Share on other sites
szabesz    1,390

Thanks! Save works but it cannot re-maximize it afterwards. At first I got a PW error notification which said something like: "body field could not be found" (I do not have the exact message) but after that it just fails without any error in sight.

Share this post


Link to post
Share on other sites
tpr    2,229

No idea what is happening there :) No errors here on latest PW dev and latest AOS, default and Reno themes. Cache?

Edit: have you added CKEditor buttons to the body field before AOS? Sometimes that can cause JS errors, re-saving the field usually helps.

  • Like 1

Share this post


Link to post
Share on other sites
szabesz    1,390
8 hours ago, tpr said:

Edit: have you added CKEditor buttons to the body field before AOS? Sometimes that can cause JS errors, re-saving the field usually helps.

Thanks for the tip, sadly it did not work :( Anyway, I only use/used AOS to mod the editor.

I cleared the cache, tried it in Firefox too, and it does save the page so it is the new JS at work, it just cannot do maximize at the end. No JS error in the console either. Worst kinda issue...

Share this post


Link to post
Share on other sites
tpr    2,229

I may not understand it correctly but it sounds that the page you are editing is not reloaded after ctrl+s. On reload everything should start clean so no idea how this could fail.

Anyway I committed the update (no version change), plus made ctrl+s work in cases when the page is opened in a modal, eg. when using FEEL or perhaps the bult-in front-end editor.

Share this post


Link to post
Share on other sites
szabesz    1,390

I updated to AOS 1.3.6, nothing has changed (as expected). This is what happens:

Edit: screenshot was removed because of privacy concerns.

Share this post


Link to post
Share on other sites
tpr    2,229

Thanks, but it seems OK to me, at least I can't see the issue on the gif. So at the end of the video if you click on the Maximize button nothing happens? My best guess is that you expect the editor to re-maximize automatically which is not the case.

I've installed SystemNotifications module and disabled all other submodules of AOS but it's still working as expected here (on "expected" I mean what I expect :)).

If you think it's still an issue and could provide a login to me to check, that would be great (or install a new PW instance for me to check, it's a few minutes using Soma’s Online Installer)

Share this post


Link to post
Share on other sites
szabesz    1,390
13 minutes ago, tpr said:

My best guess is that you expect the editor to re-maximize automatically which is not the case.

Yes, I do. Oh well, then it was just a misunderstanding.

So you mean it is not possible to re-maximize it automatically? The idea here is to work in maximized mode only, not being distracted (too much) by periodic saves.

Share this post


Link to post
Share on other sites
tpr    2,229

AOS triggers the save button only, what you need would be ajax save which is harder to implement. Maybe I'll check it some day though.

Of course I could find a way to Maximize after ctrl+s but I'm not sure this won't be a nuissance.

  • Like 1

Share this post


Link to post
Share on other sites
szabesz    1,390
4 minutes ago, tpr said:

I'm not sure this won't be a nuissance.

Not sure either, however, the feature in its current state could be "improved" that way. After all, now we have to do it manually. Maybe an option in the Settings for those who want it to "stay" maximized?

Share this post


Link to post
Share on other sites
tpr    2,229

I think the time I could invest in this workaround could be spent on adding ajax save to ckeditor :)

  • Like 1

Share this post


Link to post
Share on other sites
Zeka    282

Hi @tpr

I have found one small issue with CKEditor plugins, didn't find any mentioning in this threed, but maybe you are alreade aware about it. 

If field is just in a page all additional plugins are loaded and initilated, but if field is inside of matrix/repeater field with ajax loading. After opening of collapsed item CKEditor in it is initializing just with plugins set in field settings.

  • Like 1

Share this post


Link to post
Share on other sites
tpr    2,229

Thanks, got it sorted out, now it works with Repeaters and ajax-loaded fields, need to check with RepeaterMatrix too. Will update the module later if all goes well.

aos-ckeaddons-repeater-ajax.gif.e3a70bc22f25a74ab4e18fb55c982e49.gif

Share this post


Link to post
Share on other sites
tpr    2,229

Sneak preview of draggable column splitter when using AOS admin columns:

aos-column-splitter.gif.3017d341279e382c69f3fc35b332aabc.gif

  • Like 6

Share this post


Link to post
Share on other sites
fbg13    270
3 hours ago, tpr said:

Sneak preview of draggable column splitter when using AOS admin columns:

Does it remember the widths on a refresh or on a new session?

Share this post


Link to post
Share on other sites
adrian    7,674

Draggable column width looks awesome, but at the moment I am getting this:

58d40f8b552f7_ScreenShot2017-03-23at11_09_24AM.png.bfa9150345ad20a63ff7309010740887.png

 

Share this post


Link to post
Share on other sites
tpr    2,229

Yep, sorry for that, should be fixed in v138.

  • Like 1

Share this post


Link to post
Share on other sites
adrian    7,674
17 minutes ago, tpr said:

Yep, sorry for that, should be fixed in v138.

Thanks, it works now, but it no longer honors the width setting defined in the template. I have it set to 50%, but now it starts about 70 / 30. It might also be nice if it were optional - in some cases it will be a great addition, but sometime it's just a superfluous bit of UI. Please don't take that the wrong way - it really will be awesome in many cases.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Marc
      I am trying to make a simple wiredata module that lets me select a page I want all visitors to be redirected to. I have this working in ready.php but then I decided on putting it in a module and I can't get it to work. Here's the relevant bits:
      public function ready() { $this->addHookBefore('Page::render', $this, 'redirectUsers'); } public function redirectUsers(HookEvent $e) { $page = $e->object; // The page we want to redirect to. $redirect = $e->pages->get($this->redirectPage); if ($page->id == $redirect->id) return; // Prevent infinite loop. if (!$e->user->isLoggedin()) { $e->session->redirect($redirect, false); // 'false' indicates 302 temp redirect. } } I left some checks out for simplification. Whenever I'm not on the page that I want to redirect to, an infinite redirect loop starts. Could anybody explain why that is?
    • By alxndre
      I just happened upon something that I think is curious, and I'm wondering if this is default behavior. So help me because I know nothing.
      While writing a module, i logged something in wire('log') inside the module's init() function. I was surprised to see that the text was being logged multiple times continuously. So I tried to open a small random module and logged something in its init() function as well, and the same thing happened - the text being logged many times.
      My question is, is this supposed to happen? I just want to understand what's going on. My concern is that if I do something huge in the init function, it will get called repeatedly, as with the log, and cause performance issue. Please note that these are both autoload modules. I was expecting them to log at least once when I refresh, but not continuously like what happened.
      Please let me know. Thanks.
    • By abdus
      I'm developing a multi value fieldtype and there's this method called getLoadQueryAutojoin().
      // FieldtypeMulti.php /** * Return the query used for Autojoining this field (if different from getLoadQuery) or NULL if autojoin not allowed. * * @param Field $field * @param DatabaseQuerySelect $query * @return DatabaseQuerySelect|NULL * */ public function getLoadQueryAutojoin(Field $field, DatabaseQuerySelect $query) { if($this->get('useOrderByCols')) { // autojoin is not used if sorting or pagination is active $orderByCols = $field->get('orderByCols'); if(count($orderByCols) > 0) return null; } $table = $this->database->escapeTable($field->table); $schema = $this->trimDatabaseSchema($this->getDatabaseSchema($field)); $fieldName = $this->database->escapeCol($field->name); $separator = self::multiValueSeparator; foreach($schema as $key => $unused) { $query->select("GROUP_CONCAT($table.$key SEPARATOR '$separator') AS `{$fieldName}__$key`"); // QA } return $query; } Why would someone need to autojoin a field, or not need a autojoin? Any benefits/drawbacks? I havent used the feature it at all in my 3+ years PW experience.
      I'm not sure whether I need to implement it but I am leaning towards returning null and disable it altogether.
    • By antoiba86
      I am a bit confused, because I don't know how to solve this problem.
      When I install the module Languages Support - Page Names, my web falls apart.
      I have all the necessary modules installed as Language support for example.
      This is the error I get in the admin panel.
      Warning: Invalid argument supplied for foreach() in /hosting/www/antoibaprogramming.com/public/wire/modules/LanguageSupport/LanguageSupportPageNames.module on line 107 Warning: Invalid argument supplied for foreach() in /hosting/www/antoibaprogramming.com/public/wire/modules/LanguageSupport/LanguageSupportPageNames.module on line 198 Warning: Invalid argument supplied for foreach() in /hosting/www/antoibaprogramming.com/public/wire/modules/LanguageSupport/LanguageSupportPageNames.module on line 1011 Warning: Invalid argument supplied for foreach() in /hosting/www/antoibaprogramming.com/public/wire/modules/LanguageSupport/LanguageSupportPageNames.module on line 1011 Warning: Invalid argument supplied for foreach() in /hosting/www/antoibaprogramming.com/public/wire/modules/LanguageSupport/LanguageSupportPageNames.module on line 1041
      And this in the front-end.
      Warning: Invalid argument supplied for foreach() in /hosting/www/antoibaprogramming.com/public/wire/modules/LanguageSupport/LanguageSupportPageNames.module on line 107
      Fatal error: Call to a member function get() on null in /hosting/www/antoibaprogramming.com/public/wire/modules/LanguageSupport/LanguageSupportPageNames.module on line 605 Fatal error: Call to a member function get() on null in /hosting/www/antoibaprogramming.com/public/wire/modules/LanguageSupport/LanguageSupportPageNames.module on line 605
    • By kongondo
      The Module Blog for ProcessWire replicates and extends the popular Blog Profile.
      Blog is now in version 2.
      Please read the README in the Github link below in its entirety before using this module 
      Blog Documentation is here (Work in Progress!)
      See this post for new features in version 2 or the readme in GitHub.
      To upgrade from version 1, see these instructions.
      ##################################################
      Most of the text below refers to Blog version 1 (left here for posterity). 
       
      Blog version 1 consists of two modules:
      ProcessBlog: Manage Blog in the backend/Admin.
      MarkupBlog: Display Blog in the frontend.
      Being a module, Blog can be installed in both fresh and existing sites. Note, however, that presently, ProcessBlog is not compatible with existing installs of the Blog Profile. This is because of various structural and naming differences in respect of Fields, Templates, Template Files and Pages. If there is demand for such compatibility, I will code a separate version for managing Blog Profile installs.
      In order to use the 'Recent Tweets Widget', you will need to separately install and setup the module 'MarkupTwitterFeed'.
      Please read the README in the Github link below in its entirety before using this module (especially the bit about the Pages, etc. created by the module). 
      I'll appreciate Beta testers, thanks! Stable release works fine.
      Download
      Modules Directory: http://modules.processwire.com/modules/process-blog/
      Github: https://github.com/kongondo/Blog
      You can also install from right within your ProcessWire install.
      Screenshots (Blog version 1)

      Video Demos
      ProcessBlog
      MarkupBlog
      Credits
      Ryan Cramer
      The Alpha Testers and 'Critics' 
      License
      GPL2