tpr

AdminOnSteroids

Recommended Posts

The hover on the entire pagelist line feature is a little buggy. It's a little sporadic, but if you open a branch and then collapse it, the hover no longer brings up the action buttons. Let me know if you can't reproduce and I'll try to investigate.

Share this post


Link to post
Share on other sites

Are you sure it's AOS? I can reproduce this when AOS is disabled but maybe that's not what you wrote. Which AOS feature is it (classname?) and which admin theme?

aos-hover.gif

Share this post


Link to post
Share on other sites
23 hours ago, tpr said:

Are you sure it's AOS? I can reproduce this when AOS is disabled but maybe that's not what you wrote. Which AOS feature is it (classname?) and which admin theme?

I am on the default theme. I can't reproduce without AOS. It's not consistent, but it's also not a huge deal :)

Share this post


Link to post
Share on other sites

@tpr - I have struck an access problem with Repeaters that seems to be caused by AOS. I opened a GitHub issue for it rather than clutter up this thread.

  • Like 1

Share this post


Link to post
Share on other sites

Hi @tpr Can you please somehow make it optional the CKE stuff in AOS? I mean I do not want to use it, so it is just a waste of resources to have the CKE folder around with its hefty 903 files (5.6MB).

For the time being can I just delete the whole folder? Any nasty side-effects if I do so? :) 

Edited by szabesz
typo

Share this post


Link to post
Share on other sites

I think it's safe to delete if you don't use it.

I don't know how could I make it optional without making it uncomfortable for others who are using it. What I could do (and it's on my todo) to reduce the number of files in the CKE plugins directory.

  • Like 1

Share this post


Link to post
Share on other sites

If it is possible to download this CKE plugins directory as a ZIP file than there could be a download button on the settings page to optionally get it later, but let's just leave it at this theoretical stage and see how you can trim the number of files in the first place. And I will just delete it to see what happens :) Thanx!

EDIT: still theoretically :) but it might be a better way to include the whole stuff by default, but on the settings page there could be a "remove CKE plugin support" or something like that, which deletes the direcory and the plugin can keep it that way during upgrades. There should be some warnings, of course, etc...

Edited by szabesz

Share this post


Link to post
Share on other sites

Hi @tpr! I want to propose some improvements in auto-loaded files. 

By default these files are loaded:

/site/templates/admin.css: CSS file loaded for the entire admin
/site/templates/admin.js: JavaScript file loaded for the entire admin
/site/templates/cke.js: JavaScript file loaded for CKEditor fields
/site/templates/cke.css: CSS file loaded for CKEditor fields
/site/templates/templates.js: fallback for the CKEditor "templates" plugin templates

From the point that we try to keep templates folder as much structured as possible, it would be great that auto-loaded files, by default, will be loaded for example from "templates/admin/" folder. It also would be conveniently when you use some task runner as Gulp. It that way you can create one task for custom admin assets.

Tough, we have settings for custom assets path, it is not very handy to set these paths on every new project. 

So I want to propose to change how files are auto-loaded by default: 

1. AOS looks for files in "templates";

2. AOS looks for files in "templates/admin";

3.  AOS looks for files in custom paths.

What do you think about it? 

  • Like 1

Share this post


Link to post
Share on other sites

It's fine to me, will try not to forget on the next update :)

  • Like 2

Share this post


Link to post
Share on other sites

I guess it's safe to set the defaults to "templates/admin/...", I don't want to use so many file_exists(). Is this template structure what you need?

aos-assets.png

Btw until the update you can just replace the string "cke.js" with "admin/cke.js" in AdminOnSteroids.module (and do this with all 5 assets).

 

  • Like 1

Share this post


Link to post
Share on other sites
On 2/5/2017 at 7:33 AM, szabesz said:

it might be a better way to include the whole stuff by default, but on the settings page there could be a "remove CKE plugin support" or something like that, which deletes the direcory and the plugin can keep it that way during upgrades. There should be some warnings, of course, etc...

That could work but it would add an unnecessary complication imho. In the meantime I managed to reduce the number of files to about 200 and overally module size to 2.1MB. So far so good, but I'll keep click around to see if all goes well.

  • Like 1

Share this post


Link to post
Share on other sites
21 hours ago, tpr said:

Is this template structure what you need?

Yes, it is. 

"templates/admin/..." by default would be ok. But what about backward capability, if there is no check for the root of templates folder? 

Share this post


Link to post
Share on other sites
17 minutes ago, Zeka said:

"templates/admin/..." by default would be ok. But what about backward capability, if there is no check for the root of templates folder? 

No, there's not. Imho it's better to leave out that extra 5 file check on every admin page load. This might be a nuissance for existing users but on the long run it's better this way.

FYI, v124 is uploaded, containging fewer files and with overall module files weighing 1.7MB. The Modules Directory doesn't contain the documentation anymore as it was moved to GitHub Wiki. I just tested AOS on a new install and so far so good but please report if you find something.

  • Like 2

Share this post


Link to post
Share on other sites

Evening @tpr :) Is it just me who is missing text-decoration: line-through; from the page list (tree)? See:

no-line-through.png

It was also missing at least in the previous version. I have a site with AOS 0.9.96 where unpublished pages are crossed out (I know it's way back in time...).

Share this post


Link to post
Share on other sites

Good catch - it's the double span issue inside the A element. I think it's safe to apply line-through on the inner span too, will update soon.

  • Like 1

Share this post


Link to post
Share on other sites

FYI I commited the fix (no version change). Only AdminOnSteroids.css needs to be replaced.

  • Like 1

Share this post


Link to post
Share on other sites

vary small thing: could you please make the column width inputfield selected by default after clicking on the width shortcuts? that would make it very fast to change multiple columns at once:

  • click column
  • type number
  • ctrl+s

2017-02-11 16_40_48-Edit Template_ rockprojecteffort • hrd.baumrock.com.png

thank you :)

Share this post


Link to post
Share on other sites

after upgrade all of a sudden my sites all started to show the alternate skin on CK editor, even though we I don't have that sub module enabled; enabling disabling the CKEaddons doesn't change anything, e.g. it still shows the wrong skin, and also the editor has redundant text align buttons; only way to fix was to disable module.

Edit_Page__Djuna_Barnes_•_apps_williamanderson_us.jpg

Share this post


Link to post
Share on other sites

Could you check the Body field settings? Re-saving the field may fix this.

My idea is to make a hard reload, config.js often gets cached.

What have you upgraded and to what version?

Share this post


Link to post
Share on other sites

AOS 1.2.4, PW 3.0.52; hard reload doesn't affect anything; re-saving field no effect; body field settings look correct...

Share this post


Link to post
Share on other sites

I think I got it - I've refactored the submodule enabled state to a function but haven't updated it everywhere, will commit a new version soon.

Update - @Macrura could you test if this solves the issue?

 

AdminOnSteroids.min.js

Share this post


Link to post
Share on other sites

that does indeed fix the issue - thanks!!

 

  • Like 1

Share this post


Link to post
Share on other sites

Thanks! That was a silly mistake, interestingly noone spotted it, including me :) v125 is uploaded with the fix.

  • Like 1

Share this post


Link to post
Share on other sites

Experiment with pagelist counters (CSS only):

aos-pagelist-counter.gif.4ff0cf99465600778efd438da152f1e3.gif

  • Like 2

Share this post


Link to post
Share on other sites

@tpr, I noticed that the filter box icon is out of alignment on Lister Pro pages. Not sure if you have Lister Pro available to test on but the culprit is a CSS rule that sets text inputs to 100% width inside #ProcessListerResults. Maybe force the width back to auto for the filterbox?

html.aos div.filterbox input[type="text"] { width:auto !important; }

2017-02-28_103120.png.dfc359ee4b58a743a984729d2b4e147b.png

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By kixe
      Email Verification
      This module provides functions to validate email adresses and hosts. The module generates a textfile for blacklisted mailhosts (trashmail), which will be always up to date.
      Download
      https://modules.processwire.com/modules/email-verification/
      API
      // get module $mailcheck = $modules->get('EmailVerification'); // return bool/ string - automatted update of blacklist file $mailcheck->blacklisted(email|domain) // return bool - validate a top level domain, checks against IANA list $mailcheck->validTLD(tld) // return array of punycoded TLDs - cyclic updated, data pulled from IANA $mailcheck->getTLDs(cycle=2592000) // return bool - checks syntax converts to punycode $mailcheck->validDomainName(domain); // return bool - checks punycode encoded syntax $mailcheck->validHostName(host); // return bool - checks syntax and accessibility $mailcheck->validHost(email|domain) // add a single value to blacklist $mailcheck->addToBlacklist(email|domain) USAGE
      $mailcheck = $modules->get('EmailCheck'); $email = 'susi@trashmail.com'; if($mailcheck->blacklisted($email)) echo 'Email Provider not allowed'; if(!$mailcheck->validHost($email)) echo 'Mailhost not available'; Example blacklist file:  blacklist.txt
       
    • By teppo
      Code Blocks Textformatter is a tiny Textformatter module I cooked up to add support for code blocks to text/textarea/RTE fields on some of the sites I work with. Unlike a full-blown Markdown Textformatter – which is something that we already have in the core – this module simply adds support for fenced and inline code blocks.
      The syntax is based on the GitHub code block documentation, so please refer to that for additional instructions. The README at GitHub also includes some basic examples. As with any Textformatter, in order to enable this one, install it and enable it via field settings. Note that there's no syntax highlighting built in (at least for the time being), so use a tool of your choice for that – personally I prefer Prism.js.
      Since this module doesn't use a Markdown tool behind the scenes, but rather some home baked regular expressions, there's always the possibility that I've missed something – but please let me know if you use this module and run into any issues. On the other hand this module should be relatively fast and unobtrusive, as there are no unnecessary bits of code to run 
      GitHub repository: https://github.com/teppokoivula/TextformatterCodeBlocks Modules directory: http://modules.processwire.com/modules/textformatter-code-blocks/
    • By theo
      Here is my first processwire module (beta).
      https://github.com/theo222/ImagePickerField
      A lot of "first times". First time Github, Markdown and of course PW Modules.
      So be gentle please.
      I hope it works.

    • By horst
      Image Animated GIF  v 2.0.2
       
      Module for PW 2.5 stable or newer, but is obsolete for PW Versions greater then 3.0.89 (... read more ...)
       
      This module helps with resizing and cropping of animated GIFs when using the GD-Library.
      The GD-Library does not support this.


      This module is completely based upon the fantastic work of

         László Zsidi (http://www.gifs.hu/, builts the initial classes)
         xurei (https://github.com/xurei/GIFDecoder_optimized, enhanced the classes)


      I have ported it to a PW module and it works with core imagefields, together with Pia and with CropImagefields that uses the new naming scheme since PW 2.5.
       
      ------------------------------------------------------------------------------------------------------------------------------------------
      read more in this post about the rewrite from version 1.0.0 to version 2.0.0
      ------------------------------------------------------------------------------------------------------------------------------------------
      You can find it in the modules directory: https://modules.processwire.com/modules/image-animated-gif/
      and on Github: https://github.com/horst-n/ImageAnimatedGif
      ------
      A preview can be found here