Jump to content
tpr

MarkupSrcSet

Recommended Posts

Currently it's not possible. I could redesign the image sets like this:

{
    "featured": [
        [435,210], 2, 4
    ],
    "hero": [
        "720w 990w 1220w" => [
            [720,320], 2, 3
        ]
     ]
}

It's getting a bit complicated but if I'll have some time I could create an UI for this so it will be easier to set.

  • Like 1

Share this post


Link to post
Share on other sites

Can anyone get bgset to work, it just always uses the fall back background image for me.

 

Nevermind. Sorted it.

Edited by neonwired

Share this post


Link to post
Share on other sites

Could you show your code and module settings?

Share this post


Link to post
Share on other sites

I moved some posts not related to MarkupSrcSet to the ImageAnimatedGif thread.

Share this post


Link to post
Share on other sites

It works perfectly well:

<div <?php echo $page->images->first()->bgset('hero'); ?>>Lorem ipsum</div>

Call to a member function srcset() on a non-object

<img <?php echo $page->featured_image->srcset('featured-image'); ?>>

What should I do?

Share this post


Link to post
Share on other sites
$page->featured_image

doesn't return a valid object! (It returns a "non-object")
You need to check that it returns a valid image object. Check if you set the image field to return a single image or an array of images.
Also you always need a fallback for cases where no image is uploaded to a field!

  • Like 1

Share this post


Link to post
Share on other sites

Thank you! It works like this:
 

<img <?php echo $page->images->first()->srcset('featured-image'); ?>>

 

  • Like 1

Share this post


Link to post
Share on other sites

Just updated the module to version 0.1. Almost everything in it has changed so reading the docs is a must :)

The module does less "magic" as before, eg. doesn't add the "lazyload" class and data-sizes automatically. These should be added manually or you can write a wrapper function if you would like to simplify things (please notify me if you think you wrote one that should be part of the module).

Also all the module settings are gone except the "Load scripts" checkbox because all other settings became useless after the rewrite.

The new syntax looks like this (here with a helper to add a noscript tag for no-js fallback):

<?php $img = $page->featured_image; ?>

<img data-srcset="<?php echo $img->srcset('200x300,*2,*3'); ?>" class="lazyload" data-sizes="auto" alt="" />

<noscript>
    <img src="<?php echo $img->srcsetUrls[0]; ?>" />
</noscript>

The main change is that you can easily tell what image sizes (sets) you need ("200x300,*2,*3" in the above example). Of course you can use WxH values for each set or use divisors too. What's more you don't have to start with the lowest image size, eg. "1200x900, /2, /4" is perfectly fine. 

  • Like 5

Share this post


Link to post
Share on other sites

Thanks for the update, Something to possible consider -  maybe a field in the module settings where the user can type in the url segment to identify that the page is an AMP page and from there replace the <img> tage with the <amp img ></amp> tag?

Share this post


Link to post
Share on other sites

The module doesn't output the img tag, only the value for the srcset attribute so I don't see how this feature could be implemented.

Share this post


Link to post
Share on other sites

My Apologies, I got the module mixed up with TextformatterSrcset.

Share this post


Link to post
Share on other sites

Maybe that my question is a bit OT. As the new modules version works perfect! ^-^

My question is related to data-bgset. I want to show an image covering the whole vieport. Therefor I use a div with background image. The css for the div is:

        position: relative !important;
        display: block;
        height: 100vh;
        background-position: 50% 50%;
        background-repeat: no-repeat;
        background-size: cover;

My list is defined like: 600x0, 1200x0, 1800x0

Related to the background-size: cover, I believe, I get always the image displayed what is one step to small from the list, because they get stretched by css, to cover the viewport.

Can someone tell me how to solve this with MarkupSrcSet?

Share this post


Link to post
Share on other sites

Ok, I may add a workaround to my own question:

I have found out, that, for what ever reason, the largest variation never was fetched from the server !! ??

With my example form above, the largest variation fetched was the 1200x0. Then, with adding a 1801x0 to the list, the 1800x0 was fetched as largest. So, not sure why this behave is.

Has anyone else seen this for bg-sets?
Besides the workaround, it isn't useful to get the HDs filled up with (regularly) unnessecary large variations.

Share this post


Link to post
Share on other sites

I have previously been using uppercase URL in $page->image->URL for browser cache busting query string purpose. Is this compatible with MarkupSrcSet? My current image url is $page->image->srcset('860x0,/2,/3'). 

  • Like 1

Share this post


Link to post
Share on other sites

I think it doesn't support it yet. I'll check how to add this, thanks for pointing this out.

  • Like 2

Share this post


Link to post
Share on other sites

@franctic-aerobic It was easy to add a new $image->SRCSET method which generates such srcset:

/site/assets/files/1/pic.400x300.png?nc=1545348144 400w,/site/assets/files/1/pic.600x400.png?nc=1545348181 600w

But there's a problem: these resized images won't get re-created if you modify the original image, which I suppose your original plan was. I don't know how to deal with this without overcomplicating things.

Share this post


Link to post
Share on other sites

I've been using LazySizes manually for a while and wanted to try your Module.

Can I check that the following is setup correctly? I'm applyng this is a background image which is new to me.

First of all, I have been setting a variable of photo_header which uses a named, cropped image of 1250x550

<?php $photo_header = $page->image_staff_header->getCrop('crop-staff-photo'); ?>

My actual html which outputs this image looks like this (pre MarkupSrcSet)

<div class="uk-width-uk-width-1-1 staff-pic" style="background-image:url(<?= $photo_header->url?>);">

When I apply my MarkupSrc set, I think this is the proper way

<div 
data-bgset="<?php echo $photo_header->srcset('1200x550,/1.5,/2,/3'); ?>" 
data-sizes="auto"
class="lazyload uk-width-uk-width-1-1 staff-pic" 
style="background-image:url(<?php echo $photo_header->srcsetUrls[0]; ?>);"
>

and it does produce the following...

<div 
data-bgset="/site/assets/files/1089/adams_-_cubes-1.-crop-staff-photo.1200x550.jpg 1200w,
            /site/assets/files/1089/adams_-_cubes-1.-crop-staff-photo.800x366.jpg 800w,
            /site/assets/files/1089/adams_-_cubes-1.-crop-staff-photo.600x275.jpg 600w,
            /site/assets/files/1089/adams_-_cubes-1.-crop-staff-photo.400x183.jpg 400w" 
class="uk-width-uk-width-1-1 staff-pic uk-first-column" 
style="background-image:url(/site/assets/files/1089/adams_-_cubes-1.-crop-staff-photo.1200x550.jpg);"
>

However, I notice that when I inspect the Div above in Chrome, I always seem to have the same image regardless of device width

element.style {
    background-image: url(/site/assets/files/1089/adams_-_cubes-1.-crop-staff-photo.1200x550.jpg);
}

Is this right? Surely I should be seeing different image sizes above?

Cheers @tpr
 

Share this post


Link to post
Share on other sites

If you view the page source, is the largest img variation set for the background image? The 0-index should be the smallest.

Btw if you start devtools in desktop size, then the smaller img variations will not be loaded. Start in small width and check if it loads the larger ones when you resize the viewport.

Edit: there is no lazyload or lazyloaded class in your final src, perhaps some hook is messing with the ing classes?

Share this post


Link to post
Share on other sites

Yep - I think it's all good.

<div data-sizes="auto" 
     data-bgset="/site/assets/files/1089/adams-cubes.-crop-staff-photo.1200x550.jpg 1200w,
                 /site/assets/files/1089/adams-cubes.-crop-staff-photo.800x366.jpg 800w,
                 /site/assets/files/1089/adams-cubes.-crop-staff-photo.600x275.jpg 600w,
                 /site/assets/files/1089/adams-cubes.-crop-staff-photo.400x183.jpg 400w" 
     class="uk-width-uk-width-1-1 staff-pic uk-first-column lazyloaded" 
     style="background-image:url('/site/assets/files/1089/adams-cubes.-crop-staff-photo.1200x550.jpg') ;">

Have cleared the cache, refreshed from small size and expanded that way.

Share this post


Link to post
Share on other sites

Perhaps the 0-index fails to get the smallest img (I do not remember wether if it should or not). Could you try with $photo_header->srcsetUrls['smallest'], or with no initial style attribute at all?

  • Like 1

Share this post


Link to post
Share on other sites
12 minutes ago, tpr said:

Perhaps the 0-index fails to get the smallest img (I do not remember wether if it should or not). Could you try with $photo_header->srcsetUrls['smallest'], or with no initial style attribute at all?

That's it. Removing the [0] at the end worked. Many thanks 🙂

Share this post


Link to post
Share on other sites

You mean replacing with "smallest"? Otherwise it should throw an error.

Share this post


Link to post
Share on other sites

Correct. I am using

echo $photo_header->srcsetUrls['smallest']; 

If I use

echo $photo_header->srcsetUrls; 

there is an error but it only shows up in the network tab. The images seem to still work but they could be cached versions.

  • Like 1

Share this post


Link to post
Share on other sites

Hi again @tpr

I notice on the code below I am getting both a data-srcset and a srcset too. Is this correct?

My input

<?php $myimage = $page->Images->first(); ?>
<img 
     class="lazyload"
     data-src="<?php echo $myimage->url ?>"
     data-srcset="<?php echo $myimage->srcset('800x0, /2, /3') ?>"
     alt="" 
 />

My output in browser

 <img class=" lazyloaded" 
 data-src="/site/assets/files/1/photo-steps-video.jpg" 
 data-srcset="
              /site/assets/files/1/photo-steps-video.800x0.jpg 800w,
              /site/assets/files/1/photo-steps-video.400x0.jpg 400w,
              /site/assets/files/1/photo-steps-video.266x0.jpg 266w" 
alt="" 
srcset="/site/assets/files/1/photo-steps-video.800x0.jpg 800w,
         /site/assets/files/1/photo-steps-video.400x0.jpg 400w,
         /site/assets/files/1/photo-steps-video.266x0.jpg 266w" 
src="/site/assets/files/1/photo-steps-video.jpg"
 >  

 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By d'Hinnisdaël
      Format Datetime fields as Carbon instances.
      You can find the latest release and the complete readme on Github.
      Installation
      composer require daun/datetime-carbon-format Usage
      All Datetime fields will now be formatted as Carbon instances instead of strings. Some examples:
      // $page->date is a Datetime field // Output format: j/n/Y echo $page->date; // 20/10/2020 echo $page->date->add('7 days'); // 27/10/2020 echo $page->date->format('l, F j'); // Monday, October 20 echo $page->date->year; // 2020 echo $page->date->diffForHumans(); // 28 minutes ago Frontend only
      The ProcessWire admin seems to expect datetime fields to be strings. This module will only return Carbon instances on frontend page views.
      Date output format
      When casting a Carbon instance to a string (usually when outputting the field in a template), the field's date output format will be respected.
      Links
      GitHub • Readme • Carbon docs
       
       
      PS. I remember reading about a Carbon module in a recent newsletter, but couldn't find it anywhere. Was that you, @bernhard?
    • By MoritzLost
      TrelloWire
      This is a module that allows you to automatically create Trello cards for ProcessWire pages and update them when the pages are updated. This allows you to setup connected workflows. Card properties and change handling behaviour can be customized through the extensive module configuration. Every action the module performs is hookable, so you can modify when and how cards are created as much as you need to. The module also contains an API-component that makes it easy to make requests to the Trello API and build your own connected ProcessWire-Trello workflows.
      Warning: This module requires ProcessWire 3.0.167 which is above the current stable master release at the moment.
      Features
      All the things the module can do for you without any custom code: Create a new card on Trello whenever a page is added or published (you can select applicable templates). Configure the target board, target list, name and description for new cards. Add default labels and checklists to the card. Update the card whenever the page is updated (optional). When the status of the card changes (published / unpublished, hidden / unhidden, trashed / restored or deleted), move the card to a different list or archive or delete it (configurable). You can extend this through hooks in many ways: Modifiy when and how cards are created. Modify the card properties (Target board & list, title, description, et c.) before they are sent to Trello. Create your own workflows by utilizing an API helper class with many convenient utility methods to access the Trello API directly. Feedback & Future Plans
      Let me know what you think! In particular:
      If you find any bugs report them here or on Github, I'll try to fix them. This module was born out of a use-case for a client project where we manage new form submissions through Trello. I'm not sure how many use-cases there are for this module. If you do use it, tell me about it! The Trello API is pretty extensive, I'll try to add some more helper methods to the TrelloWireApi class (let me know if you need anything in particular). I'll think about how the module can support different workflows that include Twig – talk to me if you have a use-case! Next steps could be a dashboard to manage pages that are connected to a Trello card, or a new section in the settings tab to manage the Trello connection. But it depends on whether there is any interest in this 🙂 Links
      Repository on Github Complete module documentation (getting started, configuration & API documentation) TrelloWire in the modules directory Module configuration

    • By David Karich
      ProcessWire InputfieldRepeaterMatrixDuplicate
      Thanks to the great ProModule "RepeaterMatrix" I have the possibility to create complex repeater items. With it I have created a quite powerful page builder. Many different content modules, with many more possible design options. The RepeaterMatrix module supports the cloning of items, but only within the same page. Now I often have the case that very design-intensive pages and items are created. If you want to use a content module on a different page (e.g. in the same design), you have to rebuild each item manually every time.
      This module extends the commercial ProModule "RepeaterMatrix" by the function to duplicate repeater items from one page to another page. The condition is that the target field is the same matrix field from which the item is duplicated. This module is currently understood as proof of concept. There are a few limitations that need to be considered. The intention of the module is that this functionality is integrated into the core of RepeaterMatrix and does not require an extra module.
      Check out the screencast
      What the module can do
      Duplicate multible repeater items from one page to another No matter how complex the item is Full support for file and image fields Multilingual support Support of Min and Max settings Live synchronization of clipboard between multiple browser tabs. Copy an item and simply switch the browser tab to the target page and you will immediately see the past button Support of multiple RepeaterMatrix fields on one page Configurable which roles and fields are excluded Configurable dialogs for copy and paste Duplicated items are automatically pasted to the end of the target field and set to hidden status so that changes are not directly published Automatic clipboard update when other items are picked Automatically removes old clipboard data if it is not pasted within 6 hours Delete clipboard itself by clicking the selected item again Benefit: unbelievably fast workflow and content replication What the module can't do
      Before an item can be duplicated in its current version, the source page must be saved. This means that if you make changes to an item and copy this, the old saved state will be duplicated Dynamic loading is currently not possible. Means no AJAX. When pasting, the target page is saved completely No support for nested repeater items. Currently only first level items can be duplicated. Means a repeater field in a repeater field cannot be duplicated. Workaround: simply duplicate the parent item Dynamic reloading and adding of repeater items cannot be registered. Several interfaces and events from the core are missing. The initialization occurs only once after the page load event Attention, please note!
      Nested repeaters cannot be supported technically. Therefore a check is made to prevent this. However, a nested repeater can only be detected if the field name ends for example with "_repeater1234". For example, if your MatrixRepeater field is named like this: "content_repeater" or "content_repeater123", this field is identified as nested and the module does not load. In version 2.0.1 the identification has been changed so that a field ending with the name repeater is only detected as nested if at least a two-digit number sequence follows. But to avoid this problem completely, make sure that your repeater matrix field does NOT end with the name "repeater".
      Changelog
       
      2.0.1
      Bug fix: Thanks to @ngrmm I could discover a bug which causes that the module cannot be loaded if the MatrixRepeater field ends with the name "repeater". The code was adjusted and information about the problem was provided 2.0.0
      Feature: Copy multiple items at once! The fundament for copying multiple items was created by @Autofahrn - THX! Feature: Optionally you can disable the copy and/or paste dialog Bug fix: A fix suggestion when additional and normal repeater fields are present was contributed by @joshua - THX! 1.0.4
      Bug fix: Various bug fixes and improvements in live synchronization Bug fix: Items are no longer inserted when the normal save button is clicked. Only when the past button is explicitly clicked Feature: Support of multiple repeater fields in one page Feature: Support of repeater Min/Max settings Feature: Configurable roles and fields Enhancement: Improved clipboard management Enhancement: Documentation improvement Enhancement: Corrected few typos #1 1.0.3
      Feature: Live synchronization Enhancement: Load the module only in the backend Enhancement: Documentation improvement 1.0.2
      Bug fix: Various bug fixes and improvements in JS functions Enhancement: Documentation improvement Enhancement: Corrected few typos 1.0.1
      Bug fix: Various bug fixes and improvements in the duplication process 1.0.0
      Initial release Support this module
      If this module is useful for you, I am very thankful for your small donation: Donate 5,- Euro (via PayPal – or an amount of your choice. Thank you!)
      Download this module (Version 2.0.1)
      > Github: https://github.com/FlipZoomMedia/InputfieldRepeaterMatrixDuplicate
      > PW module directory: https://modules.processwire.com/modules/inputfield-repeater-matrix-duplicate/
      > Old stable version (1.0.4): https://github.com/FlipZoomMedia/InputfieldRepeaterMatrixDuplicate/releases/tag/1.0.4
    • By picarica
      so i am trying to put CustomHooksForVariations.module, a custom module, i am placing it into site/modules direcotry yet my modules page in admin panel gives me errors
      so this is the screen show when i refresh modules, i dont know why the shole hook is written on top of the page :||

      and this next image is when i try to install it, i saw that it is not defiuned modules.php but it shouldnt need to be ?, any ways i dont want to edit site's core just to make one moulde work there has to be a way

    • By Robin S
      A new module that hasn't had a lot of testing yet. Please do your own testing before deploying on any production website.
      Custom Paths
      Allows any page to have a custom path/URL.
      Note: Custom Paths is incompatible with the core LanguageSupportPageNames module. I have no experience working with LanguageSupportPageNames or multi-language sites in general so I'm not in a position to work out if a fix is possible. If anyone with multi-language experience can contribute a fix it would be much appreciated!
      Screenshot

      Usage
      The module creates a field named custom_path on install. Add the custom_path field to the template of any page you want to set a custom path for. Whatever path is entered into this field determines the path and URL of the page ($page->path and $page->url). Page numbers and URL segments are supported if these are enabled for the template, and previous custom paths are managed by PagePathHistory if that module is installed.
      The custom_path field appears on the Settings tab in Page Edit by default but there is an option in the module configuration to disable this if you want to position the field among the other template fields.
      If the custom_path field is populated for a page it should be a path that is relative to the site root and that starts with a forward slash. The module prevents the same custom path being set for more than one page.
      The custom_path value takes precedence over any ProcessWire path. You can even override the Home page by setting a custom path of "/" for a page.
      It is highly recommended to set access controls on the custom_path field so that only privileged roles can edit it: superuser-only is recommended.
      It is up to the user to set and maintain suitable custom paths for any pages where the module is in use. Make sure your custom paths are compatible with ProcessWire's $config and .htaccess settings, and if you are basing the custom path on the names of parent pages you will probably want to have a strategy for updating custom paths if parent pages are renamed or moved.
      Example hooks to Pages::saveReady
      You might want to use a Pages::saveReady hook to automatically set the custom path for some pages. Below are a couple of examples.
      1. In this example the start of the custom path is fixed but the end of the path will update dynamically according to the name of the page:
      $pages->addHookAfter('saveReady', function(HookEvent $event) { $page = $event->arguments(0); if($page->template == 'my_template') { $page->custom_path = "/some-custom/path-segments/$page->name/"; } }); 2. The Custom Paths module adds a new Page::realPath method/property that can be used to get the "real" ProcessWire path to a page that might have a custom path set. In this example the custom path for news items is derived from the real ProcessWire path but a parent named "news-items" is removed:
      $pages->addHookAfter('saveReady', function(HookEvent $event) { $page = $event->arguments(0); if($page->template == 'news_item') { $page->custom_path = str_replace('/news-items/', '/', $page->realPath); } }); Caveats
      The custom paths will be used automatically for links created in CKEditor fields, but if you have the "link abstraction" option enabled for CKEditor fields (Details > Markup/HTML (Content Type) > HTML Options) then you will see notices from MarkupQA warning you that it is unable to resolve the links.
      Installation
      Install the Custom Paths module.
      Uninstallation
      The custom_path field is not automatically deleted when the module is uninstalled. You can delete it manually if the field is no longer needed.
       
      https://github.com/Toutouwai/CustomPaths
      https://modules.processwire.com/modules/custom-paths/
×
×
  • Create New...