Jump to content

adrian

PW-Moderators
  • Posts

    10,961
  • Joined

  • Last visited

  • Days Won

    352

Posts posted by adrian

  1. Just another note on toggles - this impacts even checkboxes that are added to process modules, but in some cases the css for it is broken so it's unusable.

    image.png.a641bebd11cc78ac984e12d1ea86daaa.png

    Also, in this case the checkbox is in a table and it takes up much more space.

    On another topic, I find it weird that the font color for the main menu is so black (mentioned above by someone), but also that for the dropdown items, the unselected items are black whereas for the top level items, the unselected are grey and the selected is black. I also think that dropdown menus should reflect the current page by being in the darker color, but again, definitely not #000

     

    • Like 2
  2. As noted above regarding z-indexes, they also seem weird for top nav menu dropdowns. It looks like they are set to 200, but they still appear behind Tracy panels when they are set to 100. I haven't narrowed down the exact required index, but setting Tracy to 50 lets the menus dropdown over Tracy panels. In the original theme, the menus are also set to 200, so it must have something to do with the new fixed header nav messing with things.

    • Like 4
  3. Sorry, one more thing (for now). I think there should be separate CSS vars for the dropdown menus (vs the --masthead-background).

    And to re-iterate my point above about --blocks-background and --button-color. Having any css var assigned to another css var seems like a real limitation and there are many other cases where this happens.

  4. Any chance we could have css variables for page list action buttons for color, background, border-radius and padding? I really want to go back to the look of them being buttons. Or, we need to separate the usage of --blocks-background, because at the moment it is also used for the hover color when the page list actions are displayed. I don't like the grey page background so I have changed --main-background to white, so I need to change the color of the page list actions hover but if I change that to something useful it makes all fieldsets look awful because --blocks-background is also used for those.

    Actually, it seems that  --blocks-background is also used for some button text colors --button-color: light-dark(var(--blocks-background), var(--text-color)); - this is problematic because you can't override --blocks-background without overriding --button-color

    I honestly think there needs to be quite a bit of tweaking of the css variables to make things usable.

    • Like 6
  5. Thanks everyone for the work on this!

    A couple of issues I noticed right away:

    Tab indicator not positioned correctly.

    image.png.1a7c81dfe216039a48b4fc58f0171436.png
     

    Add new button padding (Repeater Matrix)

    image.png.2e796fcde1ace4aa665e005f05dea9cb.png

    I also really need checkboxes back - toggles don't work en masse and I also heavily rely on https://github.com/baumrock/RockAdminTweaks/tree/main/tweaks/Inputfields/CheckAllCheckboxes for being able to quickly check all checkboxes. This came from AOS originally, but I ported over to RockAdminTweaks.

    • Like 3
  6. @BrendonKoz - the tracyCodeError cookie is only ever set by the Console Panel so I think that might not be related at all to the download issue. In fact I am not Tracy will be able to help you with that because the html download attribute isn't PHP. Or am I missing something?

    As for the tracy-2.x folders - each is a different version depending on the version of the PHP you are running: https://github.com/adrianbj/TracyDebugger/blob/d48ebdc0d962c34042651f82b388df93e872ab81/TracyDebugger.module.php#L355-L366

    You can delete the unused ones if you want, but they'll just come back next time you update Tracy. May I ask why you want to delete them?

  7. On 3/26/2025 at 5:13 PM, elabx said:

    Oh why does this happen? It worries me I might encounter this sometime.

    I am running it on 3.0.247 without issues but let me know if you notice anything.

  8. Hi @psy - maybe I am not understanding exactly the issue. I have Tracy enabled on the frontend for superusers in development mode (with debug bar etc) and in production mode (allowing logging and reporting of errors via email/slack) for guest users. I don't think there should be any Tracy JS on the FE for guest users in production mode.

    Are you trying enable development mode for guest users? If so, then what you probably want it to just enable "Guest Dumps" - the button on the Selector panel. The other tool that might come in handy is the RequestLogger, but then again, I am not certain what you're actually doing - can you provide some code and context?

  9. Really weird for sure but maybe the answer can be found in that function that is calling token_get_all() still - I think it should be pretty easy for you to figure out whether there is an issue reading the Functions.php file or getting the tokens from it by putting some bd() calls in the appropriate places to see where it's getting to.

  10. I feel like I must be missing something very obvious, but I don't understand how you can get an undefined array key when doing an isset() on it. This is essentially what we are doing:

    image.thumb.png.5874a1b2d2c4d165e6a129e718b90e3f.png

     

    Can you please take a look into those functions I mentioned above and figure out where they are failing to populate the ['pwFunctions'] key.

    I just have no idea how to reproduce and haven't had any other reports related to the API data functions in years.

    One final idea - I see that the line number of the error did change, so the files in /assets/cache/FileCompiler seem to be being updated, but I would maybe try deleting them all, just in case.

     

  11. I am really baffled at the moment, but let's try to at least deal with fixing the error even if I can't figure out the actual cause.

    Can you please make this change in PwApiData.php and let me know if it helps.

                elseif($type == 'proceduralFunctions') {
                    $proceduralFunctionsFunctions = $this->getProceduralFunctions('Functions');
                    $apiData = array('Functions' => isset($proceduralFunctionsFunctions['pwFunctions']) ? $proceduralFunctionsFunctions['pwFunctions'] : array());
                    if(file_exists($this->wire('config')->paths->core . 'FunctionsAPI.php')) $apiData += array('FunctionsAPI' => $this->getProceduralFunctions('FunctionsAPI')['pwFunctions']);
                }

    It should prevent the error, although we might end up with another one for $this->getProceduralFunctions('FunctionsAPI')['pwFunctions']) but that can be fixed the same way. 

    I'd rather know why these aren't being populated though so if you feel like looking into the getProceduralFunctions() and getFunctionsInFile() to see where/why it's failing, that would be helpful.

    I can't figure out why this isn't being reported by anyone else. I thought perhaps it might be a file permission issue with reading the core Functions.php and FunctionsAPI.php files but when I made these unreadable, I got a very different error.

  12. @Robin S - I was just testing on a different site (where I hadn't yet checked the clear network cache) and came across the same error that @Macrura reported above. I just updated to 0.5.2 and that seems to have fixed that along with the issue I reported. Thank you!

    • Like 2
  13. Hi @psy - I don't think this is a Tracy issue. It seems like there is an unserialize call somewhere - can you see one in Tracy's callstack? Maybe you can post the entire HTML of it?

    Is your module trying to integrate: https://github.com/lbuchs/WebAuthn ?

    There are lots of results on Google about this error: https://www.google.com/search?q="the+script+tried+to+call+a+method+on+an+incomplete+object.+Please+ensure+that+the+class+definition"&oq="the+script+tried+to+call+a+method+on+an+incomplete+object.+Please+ensure+that+the+class+definition"&gs_lcrp=EgZjaHJvbWUyBggAEEUYOTIGCAEQLhhA0gEJMTM1NjlqMGoxqAIAsAIA&sourceid=chrome&ie=UTF-8 but kinda hard to figure out the cause in this case without seeing the rest of Tracy's stack trace.

×
×
  • Create New...