Jump to content

DrQuincy

Members
  • Posts

    246
  • Joined

  • Last visited

  • Days Won

    1

Posts posted by DrQuincy

  1. On 1/27/2020 at 10:23 PM, Arcturus said:

    During a recent maintenance routine we found that our website's database (1,700+ pages) had thousands of instances of unnecessary, garbage code that had come with copied text from Word. Passages with margins expressed in points, cms and inches, and some that were wrapped in upwards of 7 spans were among the most easily identified crimes. Purging all of this dropped our database size by over 4%.

    A few of the code examples above nuke all inline styles, which will impact some important out-of-the-box functionality for PW3 and CkEditor (depending on your use); specifically with many of the options with tables and lists, such as setting a column width or changing the bullet styles within a nested list.

    To work around that, I made some changes to Ryan's code to target specific tags and to eliminate spans (which you can only add via Source view without pasting them in).

    $wire->addHookAfter('InputfieldCKEditor::processInput', function($event) {
      $inputfield = $event->object;
      $value = $inputfield->attr('value');
      if ((strpos($value, 'style=') === false) && (strpos($value, '<span>') === false)) return;
      $count = 0;
      $qty = 0;
    
      // Optional remove spans
      $value = preg_replace('/<span.*?>/i', '', $value, -1, $qty);
      $value = preg_replace('/<\/span.*?>/i', '', $value, -1);
      $count = $count + $qty;
    
      // Remove inline styles from specified tags
      $tags = array('p','h2','h3','h4','li');
      foreach ($tags as $tag){
        $value = preg_replace('/(<'.$tag.'[^>]*) style=("[^"]+"|\'[^\']+\')([^>]*>)/i', '$1$3', $value, -1, $qty);
    	$count = $count + $qty;	
      }
    
      if(!$count) return;
      $inputfield->attr('value', $value);
      $inputfield->trackChange('value');
      $inputfield->warning("Stripped $count style attribute(s) from field $inputfield->name");	
    });

     

    This is great, thanks!

    In my settings I am allowing spans with classes. Do you know how I might adapt your code to allow this? If I have HTML with <span class="foo">bar</span> but no empty spans or style assets, <span class="foo">bar</span> stays. But if I add in <span>foo</span>, <span>foo</span> changes to just foo (great!) but <span class="foo">bar</span> also change to bar.

    Also, by default, CKEditor seems to allow style="margin: " I assume this is related to indentation. Any idea how you can disable this? Extraneous spans are annoying but harmless. However, the margin styles mess the formatting up. I do not even have the indentation buttons visible in the toolbar.

    Thanks!

  2. Thanks for the explanation, Jan. And, yes, that makes sense as to the difference between roles and permissions.

    I have created the permission tasks-list-access and assigned it to the role content-manager. I have then added 'permission' => 'tasks-list-access' to my Process class but it hasn't made a difference. Am I missing something?

    I refreshed the module and it worked. Hoorah! Thanks very much for your help. ?

    • Like 1
  3. I have a simple Process installed that displays some dynamic HTML that I want to allow a logged in person to view who doesn't have the superuser role. Is this possible? I am assuming because a class that extends Process is used by the admin template this doesn't happen by default. How do I did it?

    I have tried adding  'permission' => 'content-manager' to getModuleinfo() by when I access the page as a content-manager user it just redirects to the site tree.

    Thanks. ?

  4. I'm trying to find an existing PW field that is simple enough for me to duplicate and adjust to suit my needs.

    All I'm after is the ability to create some custom HTML with a hidden field — and then hidden field is used as the database value. There is no fancy validation needed other than the value can not be empty.

    I have bought an icon pack for a client that is stored in a folder for the website and I simple want to be able to show the icons in a grid and when clicked the name of the icon goes into the hidden field.

    I've looked through some of the core modules and it's a bit overwhelming. I'm sure if I had a simple example I'd be fine with it.

    Thanks.

  5. Thanks for your suggestion!

    In this case it's for something that runs on cron in the night and syncs a website property listing with third-party listing software. It takes a long time to run as it needs to copy images over HTTP and then resize some of them so when the website is accessed during the day it's a lot faster.

    Thanks for your suggestion though. I must admit I have never thought of doing it that way — it's a neat solution. If you run curl and then redirect via a session as you have done, does curl honour the redirect? I can't say I've never tried that but from when I have used curl in the command line I'm sure it just returns redirect headers, location, etc.

    I just thought maybe there was a way with the API and get a page's rendered HTML as opposed to as an object to force ProcessWire to run the task as it would if you visited it via a browser.

    I don't know, I thought maybe there'd be something like $pages->get('/path/to/page/')->render() that returns the page HTML. If so, from my command line script I could simply map the arguments to $_GET and also pass a path.

    • Like 1
  6. Thanks, I've seen that. I just wondered if there was a way to — rather then get a page through the API which I could do per your link — get PW to actually process it as though it were a front-end request. If I do wire('page')->get(123) it will retrieve all the data but what I want is to trigger something that is the same as accessing the page through HTTP.

    Is there a built-in function for this?

  7. My hosting environment does not allow for PHP to run for more than 120 seconds when it is a web request. However, there is no limit via command line PHP.

    Is it possible take a ProcessWire URL such as http://domain.com/foo/bar/?bar=foo and run it as a PHP command line? Something like:

    php /path/to/pw/site/index.php route=/foo/bar/ bar=foo

    Is such a thing possible? Thanks.

  8. I'm not sure if I'm missing something glaringly obvious here but if you set URLs (not segments) to not have trailing slashes you will still get one at the end when accessing $page->path.

    So $page->path for my sitemap.xml file is /sitemap.xml/. Yes if you visit /sitemap.xml/ it redirects to /sitemap.xml — but why doesn't it just return /sitemap.xml? This will end up adding an awful lot of unnecessary requests.

    Is this intended behaviour?

    I have also noticed the API only seems to work with forward slashes too (e.g. parent=/foo/bar/, not parent=/foo/bar) — but I get that as a design decision since the the trailing slash setting is effectively abstract from that.

  9. Hi,

    I am doing a site that does a fair bit of number crunching and decided to try PHP 8 as I read it was a fair bit faster.

    The front-end works fine but when I log in to /processwire/ I get:

    Quote

    ProcessWire: ProcessLogin: This request was aborted because it appears to be forged.

    When switching back to PHP 7.4 it works as expected. I did also try it on a computer that had never accessed the back-end before and got the same error (though in hindsight I wonder if I should've cleared the cookies first).

    Does PW definitely work on PHP 8? I am using 3.0.184. If so, I wonder if it is a module that's the problem — or maybe the CSRF token needed clearing. I know you can disable CSRF but I am reluctant to do that. I have session fingerprinting disabled also.

    I just thought I'd check first to see if the core is fine to run on PHP 8. Searching the forums you find threads of people saying don't use v8 yet — but they're all about a year old.

    Thanks.

  10. When looking at the source there are quite a few page statuses beyond those visible in the Status > Settings panel; these are marked as #pw-internal in the comments. Is it better to avoid using these as it could mess up how PW works? I just wondered as the 'flagged' status could potentially be quite useful. I can just unpublish though and if it's possible uses these statuses could cause issues I'll leave them alone.

×
×
  • Create New...