Jump to content

xportde

Members
  • Posts

    47
  • Joined

  • Last visited

Posts posted by xportde

  1. Hi @kongondo,

    after setting some of our PHP environments to 8.0, we registered an error on deleting menu items (ProcessWire 3.0.200, MenuBuilder 0.2.7, Multi-language):

    method_exists(): Argument #1 ($object_or_class) must be of type object|string, null given in line 2602 in ProcessMenuBuilder.module. To prevent this, a check for item related page existence was successful:

    if (!$itemID || !$pages->get($itemID)->id) continue;

    Could you publish a bug fix release für this issue, please?

    Thanks in advance,

    Thomas from xport.

    • Like 1
  2. Hi @teppo

    thank you for the great module! We use it for an internal project where the search function is very important.

    Actually we have replaced some fields of type FieldtypeTextareas by FieldtypeCombo (both pro fields). Unfortunately FieldtypeCombo is not yet supported by SearchEngine, we have done this temporarily by the follwing lines in Indexer::___getIndexValue() at line 243:

                } else if ($field->type instanceof \ProcessWire\FieldtypeCombo) {
                    return implode(
                        ' ... ',
                        array_filter(
                            array_values($page->get($field->name)->getArray()),
                            'strlen'
                        )
                    );

    Could you consider this in your next release of SearchEngine, please?

    Best regards,

    Thomas from XPORT.

    • Thanks 1
  3. On 9/1/2021 at 10:28 AM, AndZyk said:

    Thank you for the new master version. 👍

    But after the upgrade from 3.0.165 to 3.0.184 I get an JavaScript error on the field editing page, which results in a blank page:

    875922157_Bildschirmfoto2021-09-01um10_23_12.png.6f0662638b76449a9c03be1054aca1e3.png

    137328005_Bildschirmfoto2021-09-01um10_22_50.png.9db2734e9635c26da480a8ce472593d9.png

    Has anybody else this issue?

    I think I have to wait for the upgrade a little bit.

    Regards, Andreas

    Edit: Ok, this issue seems to only occur on my local MAMP PRO server so far. I try to investigate further. 😉

    Edit 2: By the way, I use to add tags to my fields and templates for better organization. The tags I add have usually capitalization like "Foo" or "Bar". It seems to be an issue with the newly introduced InputfieldTextTags.

    We have the identical situation, same error an all edit pages since 3.0.184 because of the following error:

    image.thumb.png.58c95e7a06975207128c5941a0d0051f.png

    Strangely enough, we don't use the new field InputfieldTextTags at all yet! As hotfix, we have surrounded the JSON.parse() call with try ... catch statement:

    try {
       var o = JSON.parse($select.attr('data-opts'));
    }
    catch (e) {
       return
    }

    But this cannot remain a permanent solution. Are there any other findings on this problem yet?

    Best Regards,

    Thomas.

    • Like 1
    • Thanks 1
  4. @FireWire Thank you for the page-edit-fix, this was one of the most important things to make this module usable in real!

    Quote

    Out of curiosity- do you see a need to break down access to the translator tool to a specific permission? I'm curious about that idea but didn't think there was a use case.

    From our point of view, a separate translation permission would make perfect sense, because not everyone, who can edit a page, should do translations. Mainly because the service is subject to a charge, one should be sensitive when giving the translation service permission.

     

    Best regards,

    Thomas.

    • Thanks 1
  5. Thank you for the clarification! 

     

    In fact, the translations service works as expected, and the hint text is only a cosmetic issue. 

    We have unfortunately discovered another problem with CKEditor fields in inline mode, where the translation is not transfered into the target field. Knowing this, we may use the regular mode for CKEditor. Maybe, it's very tricky to implement the translation service here, because the inline editor is loaded dynamically on demand.

     

    Best regards,

    Thomas.

  6. We were on the verge of developing such a module ourselves, but you have beaten us to it ... Thank you very much for this great work!

    Unfortunately we have a problem with the integration of the translation service into text fields, because our default language is set to german, as also set in Fluency module settings. But in text fields, we can only translate englisch texts from english, instead from german. Have we done something wrong?

     

    Thank you in advance,

    Thomas.

    settings.png

    text_field.png

    • Like 1
  7. @Mike Rockett Hi Mike, Google should index those pages, but only in one language. To achieve this, we simply leave out all language related metatags, this is no problem. Corresponding to this, the sitemap should also be monolingual, even if all languages are activated in the backend for being edited and previewed.

  8. Hi @Mike Rockett,

    first of all many thanks for this useful module!

    I have a language related question: Would it be possible in the near future to exclude certain languages from sitemap via modules config page? We have many customers, who want to prepare other languages in the backend, so the languages have to be enabled and active, e.g. for having preview option. But the languages should not be shown in sitemap, until the translations etc. are finished. 

    Thanks in advance,

    Thomas.

  9. No, is happens actually in a SelectOptions field ($value) render template, that generates css classes depending on settings made by user:

    $css = '';
    
    foreach ($value as $device) {
        switch ($device->value) {
            case 'mobile':
                $css .= ' sm-hide';
                break;
            case 'tablet':
                $css .= ' md-hide';
                break;
            case 'desktop':
                $css .= ' xlg-hide lg-hide';
                break;
        }
    }
    
    echo $css;

    In case of checking the mobile option, $css contains ' sm-hide'. But in the calling template, only 'sm-hide' is delivered, without the trailing whitespace:

    <section class="class1 class2 class3<?=$page->render->devices?>">
      
    is rendered as
      
    <section class="class1 class2 class3sm-hide">

    Of course we could set the space directly after 'class3', but in case of no selected device option it would be unnecessary.

  10. Hello together,

    I have a question about field templates: When the output of a field template (using with $page->render->field) starts with a whitespace, it will be automatically trimmed off. Is it possible to suppress this behaviour, in case we need the whitespace explicitely?

    Thanks in advance,

    Thomas.

  11. Hi Kongondo,

     

    first of all many thanks for this useful module!

    My question is about the behaviour of RM fields on save. Usually, we fill the RM fields with some static html markup. After saving pages with RM fields, these fields always are anounced as "changed", but why? Is is possible to prevent this?

     

    Best regards,

    Thomas.

    • Like 1
  12.  

    Hi @teppo,

    thanks for the great module, we already use it with several customers.

    I have a question concerning the savePageIndex-Hook: It works perfectly on saving a single page, but not, when I use the "Index pages now"-function in module settings page. How could I achieve this?

    Best regards,

    Thomas.

    • Like 1
  13. Hello together,

    I try to preset the password on creating users of a certain role by the hook Users::added in ready.php. This is successful (the pass field value is stored in the database), but in the following screen, where the new user data have to be specified, the password input is still required. Is there any chance to prevent this?

    If this is not possible, and the password would be entered manually, how could I read it later unhashed via API to send a mail to the new user? The scenario is: A user with appropriate permissions adds other users with other role, which should be informed by email about their credentials.

    Thanks in advance,

    Thomas.

  14. Quote

    Actually, there is 😁. See under Settings > Upload Settings > Image. There are settings for min/max height and min/max width

    Do you mean Image maximum width / height? So I misunderstood the notes Maximum width / height of resized images (pixels), I thought, this settings are for resizing, not for uploading? But in fact, it corresponds with the equivalent image fields. Maybe you could write the notes accordingly (Max width / height for uploaded images)?

    Greetings, Thomas.

×
×
  • Create New...