Jozsef

I don't know where those various websites you mention quote their text, the below quote is directly from https://gdpr.eu/gdpr-consent-requirements/:

"The GDPR does not indicate a shelf life for consent. Theoretically, a person’s consent is indefinite…"

It is a requirement though that a person must be able to revoke their consent at any time. But asking them each time is just bad user experience in my opinion.

Question on behalf of those who are not fluent in JS.
I read through the js code but still not much smarter on how to setup Google Tag Manager so a tag would fire once consent was given.

If I understand correctly I can setup a trigger in GTM that it checks. But would that trigger without page reload?
I want Google Analytics report the current page load as soon as the consent is given so I won't loose tracking the entry page.

Does the tag manager automatically tracks changes in the dataLayer or only on page load?

Thanks, that is brilliant, multiple solutions for the same problem, built right into the core. PW just keeps giving. ?

Sorry if it was covered, I haven't found an answer by searching in Google or on the forum.
The client is an estate agency and they want that all images, pdf brochures etc… would disappear from their site when they unpublish or delete a property page.

Is that only possible with a custom module that hooks into unpublish or delete? It seems that ProcessWire doesn't delete the folder associated with the page from assets/files/ automatically. Similarly, if the page is unpublished, file uploads are still publicly available with the direct url.
As a result, Google would keep them in their index forever giving false results.

I understand that images can be used elsewhere in the site so it makes sense to keep them available, however since images/files belong to a page, keeping their public status synced could also make sense.
Any suggestion is welcome, maybe I haven't thought of something else.

1 minute ago, Mikie said:

Hey @kongondo, speaking of classnames, has there been any thought of rebranding to something more accessible for people outside the PW community, like eg Procommerce or Commercewire ?? Just feel like the name was always pretty random and doesn't really seem to have any particular meaning – worlds smallest turtle? – or evoke feelings of a power and capability.

Yes, I completely agree with that and wanted to bring it up. Especially in the backend when previously we got "Padloper Orders" and "Padloper Reports" etc… It feels much more integrated when you look at something like "Craft Commerce" or "Perch Shop"

10 minutes ago, kongondo said:

The only core Fieldtype Padloper 2 uses are Pagefields (2), Textarea(2, 1 of which is rich text), Title and Images.

Does that mean that products are not going to be ProcessWire pages the same way as they were in Padloper 1?
It was such a great integration and made it super easy to edit product templates.
Or will they still be available in the Templates section in admin?

Great progress, can't wait to test it out.

I agree, Padloper should work the Processwire way, that's the whole point of it. Using multi-language fields and page objects for products is the way to go.
I guess most of us who builds a PW store will expect it that way.

On 1/13/2019 at 2:03 PM, kongondo said:

2-column layout with vertical sidebar menu on the left and main content on the right (maybe with an option to collapse the sidebar)

I put my vote on this one too. Conventions play a big role in usability and people still use computers or large enough tablets to get work done (e.g. managing a shop).

6 minutes ago, kongondo said:

A couple of things have derailed me some, so I cannot promise this. Beta testing will also take a bit of time, sorry.

Count me in too. ? I'm also waiting for this for a project where the website is done and I have to add the shop in later. No point to go with the old version. Let me know if you need any testing done, happy to help and pay the price.

Hi @kongondo, thanks for the updates. Do you have a rough idea on when will an initial release be available? I'd need to add a simple store to a PW site after the holidays. You said there won't be an upgrade path so I'd rather not use V1 anymore.

Will do, thanks. I don't know why I didn't think of that earlier. ?

I can't see an option to apply classes on the link itself, on the <a> tag. When using Bootstrap, links must have the nav-link class.
Did I miss something? What workaround can I use without messing with the module code?
The module is working great, this is really the only thing I missed.

Solved:
It turned out I had no template file for any of the pages in the menu and the module checks if pages are viewable.
Since non of the pages were viewable, menuItems returned an empty array.
Thanks @kongondo for the help and pointing me to the right direction. All is well now.

But that's the thing, there's no space in the menu name anywhere so I don't know where it came from.
I sent you a PM with login details.

It's not live, unfortunately. If I do a

print_r($menuItems)

in line 86, the output is ' main_menu' instead of an array. Interestingly, there's a space before the name of the menu, I'm not sure if it's important.
I'll try to upload it to the server later today.
 

That also returns nothing. That is, no output appears on screen from Tracy.

That has no output at all. I'm very curious what is that, I must overlook something.

ProcessWire\WireArray #1f8a
	data protected => array ()
	extraData protected => array ()
	itemsRemoved protected => array ()
	itemsAdded protected => array ()
	duplicateChecking protected => FALSE
	useFuel protected => TRUE
	_instanceNum private => 0
	localHooks protected => array ()
	trackChanges private => 0
	changes private => array ()
	_notices protected => array (3)
		errors => NULL
		warnings => NULL
		messages => NULL
	_wire protected => NULL

I also deleted the content of the file compiler and cache folders.
TracyDebugger shows the same two php errors I quoted before but I don't know how to dig deeper, I don't have a lot of experience with PHP debugging.

Hi Kongondo, it's just a fresh install of PW 3.0.118 with a site profile that I took from the previous site.
All modules were added by the site profile backup. I use the same code in the template to output the menu.

My development machine is a Mac running AMPPS with PHP 7.1
The menu doesn't render, I get the error message instead.

Steps I tried (to no avail):
- Delete and recreate the menu
- Uninstall and delete the module, download a fresh copy and reinstall
- Downgrade the core to the same version as the other (working) site by overwriting the "wire" folder

I hope someone can help: I get an error message and can't figure out what's wrong. I'm getting the following errors:

Warning: Creating default object from empty value in .../site/modules/ProcessMenuBuilder/MarkupMenuBuilder.module on line 302
Warning: Creating default object from empty value in .../site/modules/ProcessMenuBuilder/MarkupMenuBuilder.module on line 305

I use the same code on two sites, in the same environment, one works, the other one doesn't. Latest module version: 0.2.4 and latest Processwire dev.
The code:

<?php
  // Output the main menu
  $menu_builder = $modules->get("MarkupMenuBuilder");
  $menu_options = array(
    "menu_css_class" => "navbar-nav justify-content-end main-menu",
    "current_class" => "active",
    "default_class" => "nav-item"
  );
  echo $menu_builder->render("main_menu", $menu_options);
?>

It looks like the menu items get lost somewhere but I'm not that great with reading code and debugging.

2 hours ago, kongondo said:

That's a tick then ?. It's already implemented ?!

Thanks, it seems to tick all boxes for common discounts, well done. 

14 minutes ago, kongondo said:

Apart from promotion (we can think about that in the future), the rest of your list is tick, tick, tick, tick + more...

Sorry, when I said promotion, I meant discount codes or discount rules including option for free shipping.

Hi @kongondo, I've just seen this thread and couldn't be happier.
I used Padloper in the past as an early adopter but I always felt it wasn't for the faint hearted. It's great to know that it has a future and I hope v2 will be possible to use without PHP guru skills. I build almost all my sites on ProcessWire and it'd be nice to have the basic features covered by the module itself (promotion, tax, shipping, user accounts, order management etc…). Many of these were up to us to implement and it was prohibiting for front-end people.
Best of luck with the project and thank you for your commitment!

Thanks for the quick reply, I haven't checked the github issues… 

Creating the user and publish it when confirmed could work well, however it would lead to other problems when something goes wrong (such as email address is already taken etc…). On the top of it, security is important because there is order and payment processing involved for those registered users.