Jump to content

NorbertH

Members
  • Posts

    211
  • Joined

  • Last visited

Posts posted by NorbertH

  1. The error message was from  "CustomPageRoles" the zip seems to be corrupted.

    UserGroups would be the perfect solution if its more or less production ready ?

    When i look at this thread it seems to be not ready yet + i guess i have to use a certain dev version of PW ?

    Template  inheritance would make using templates for usermanagement much more easy plus it would be good to have anyway . Just a thought .

    Going to test usergroups now :-)

  2. Just wanted to mention, when i try to load the module from the repository i get :

     Session: Unable to open ZIP file, error code: 19

    Usermanagement would be much more easy if we had something like chillds an parent in templates.

    Right now i if i want a protected version of my basic page i need to copy the template and then change accessrights.  But if i change my basic  template i have to manually change all of its protected versions, thats ok if you have just a few templates, but becomes impossible if you have many templates. So it would be great to have something like child templates that always have all fields their parents have , but you can assign different accessright to them .  Even if this is not a perfect solution it would make accesscontroll a lot more easy .

  3. Getting this nice little error (see screenshot)

    The image_main of this template actually is just a single image so i guess $main_image does not return the array or object your functions expects. Plus the "Formated value" of this field is set to  "single item(null if empty)" in field settings.  

    But i am not sure if this is the reason ?

    Edit: I used the image_main field as fallback for seo_url in module settings , even if this is not wanted for as one is a plaintext(url) field and the other is an image field , i think a fatal error should not happen.

    post-2434-0-86433000-1419267352_thumb.pn

  4. That means: I won't add a special "robots" field to pages, but if you define "robots := index,follow" in the custom area, that will overwrite config settings. Guess that should do the job, too.

    Good idea!

    And some more minor changes: I switched to PHP_EOL instead of \n and \n\r, which should solve the double line break issue. And I added a option, to add a whitespace at the beginning if automatically inserted. (will publish it in 10min) 

    Even more good ideas :-)

    • Like 1
  5. @NorbertH: This is not an image field because you can't have an image field in the modules config settings page. And I think this is good enough for now. Maybe I change my mind later on  :)

    Sorry, simply did not know that you cannot have Image fields in module config ...

    As Google handles each subpage of a site as a seperate page (you often can see subpages ranking much better than the main page at least at a speciffic topic ) it may be a good Idea to have this image setting in the page speciffic settings  and use the one set on the home page as default maybe? 

    Same goes for the Robot settings where user want to exclude certain pages or areas .

    @toothpaste: Why no line breaks?

    I guess hes is talking about the double linebreaks which look ugly and makes HTML source harder to read.

    Personallly i would even prefer to add some tabs before the actual tags to have a propper formating of HTML source :

    <head>
    ​    <title>titel</title><meta name="keywords" content="voorbeeld, voorbeeld, voorbeeld">
     
        <meta name="description" content="Dit is de omschrijving">
        <meta name="image" content="">
        <meta name="canonical" content="[url=http://www.testpagina/]http://www.testpagina/">[/url]
        <meta name="generator" content="ProcessWire 2.5.3">
        <meta name="author" content="">
        <meta name="robots" content="index, follow">
        <meta name="og:site_name" content="">
        <meta name="og:title" content="titel">
        <meta name="og:url" content="">
        <meta name="og:description" content="Dit is de omschrijving">
        <meta name="og:type" content="website">
        <meta name="og:image" content="">
        <meta name="twitter:card" content="summary">
        <meta name="twitter:site" content="@">
        <meta name="twitter:title" content="titel">
        <meta name="twitter:url" content="">
        <meta name="twitter:description" content="Dit is de omschrijving">
        <meta name="twitter:image" content="">
    ...
    </head>
    ​
     

    Last thing i found was a bunch of notices  while saving the page settings:

    Notice: Undefined variable: page in [/size]/home/p4a/domains/009.pw4all.org/public_html/site/modules/MarkupSEO/MarkupSEO.module on line [/size]137

    Notice: Trying to get property of non-object in [/size]/home/p4a/domains/009.pw4all.org/public_html/site/modules/MarkupSEO/MarkupSEO.module on line [/size]137

  6. About global custom field.

    A while ago i had some trouble whith google indexing HTML entities in my meta Descriptions rigth as that.

    So when i loocked at google search results i was looking at some ü> and a few other.

    I am not sure if this is still an issue as i don't do much SEO right now but if it is i guess we schould use a regex

    filter that only allows word characters and a few choosen special chars and simply drops all other.

    And again maybe its an option to make the global custom field whithout filter as it can be only edited by an admin.

    What i did not test yet was if the global field is overridden by the page based one or if both are concatenated?

    About image field in page SEO :

    Is there a reason why this is still no Imagefield ? Maybe i missed something ?

    About page SEO:

    maybe add a field  for a per page Robots setting? This is no must have , but would make it almost feature complete :-)

    Google Preview :

    What do i have to do to get a google prewiew displayed ?

    And again, great work, i love it!!! 

  7. Hmm.... reinstalled this module and got quite a few questions ...

    1. In Module settings

    1.1  "Include Generator" , what does this setting do ?

    1.2  "Do you want to get the generated code included automatically or use hooks in your template files?"

    What exactly does this do on automatic setting ?

    In manual setting you are expected to add the fields manually in your template or are there any other hooks ?

    1.3 The "custom" field does this has any form of safety or does this allow to simply inject anything you like into the template head?

    (If it would allow to inject anything this still is only a minor security risk as the person who is setting this needs access to mudule settings and is able to install own custom modules.)

    1.4 Maybe a switch for automatic redirect to https would be nice as i just read that Google  starts to prefer HTTPS Pages.

    http://googlewebmastercentral.blogspot.de/2014/08/https-as-ranking-signal.html

    http://www.golem.de/news/hsts-google-fuehrt-liste-von-reinen-https-seiten-1408-108531.html

    http://www.spiegel.de/netzwelt/web/google-belohnt-https-verbindungen-im-ranking-a-984872.html

    Just an idea?

    2. In page seo settings.

    2.1 Warning:

    in_array() expects parameter 2 to be array, string given in /home/p4a/domains/009.pw4all.org/public_html/site/modules/MarkupSEO/MarkupSEO.module on line 76

    2.2 Maybe an Image field for the image ? But i really have no idea for what reason there is a Image field in SEO settings of a page ?

    2.3 Again the custom field , if its only meaned for metas maybe a small repeater woudl do the job better ? Or maybe at least add some Regex filter to stop the average writer from adding  unlimited Javascript into ths page.? 

    Edit:

    Ist just an idea but i have often seen an underscore added to tab fields like  _seo  and _seo_END so you can see its a tab field on first view  again, just an idea.

  8. Hi There

    Using Processwire : 2.5.10 (in Debug mode, but same happend with error reporting turned on for the server)

    Module version : 1.0.6

    i get several error notices when saving a field of this fieldtype:

    Notice: Undefined index: output_format in /home/p4a/domains/009.pw4all.org/public_html/site/modules/FieldtypePhone/InputfieldPhone.module on line 45

    Notice: Undefined index: output_format_options in /home/p4a/domains/009.pw4all.org/public_html/site/modules/FieldtypePhone/InputfieldPhone.module on line 46

    Notice: Undefined index: example_country in /home/p4a/domains/009.pw4all.org/public_html/site/modules/FieldtypePhone/InputfieldPhone.module on line 47

    Notice: Undefined index: example_area_code in /home/p4a/domains/009.pw4all.org/public_html/site/modules/FieldtypePhone/InputfieldPhone.module on line 48

    Notice: Undefined index: example_number in /home/p4a/domains/009.pw4all.org/public_html/site/modules/FieldtypePhone/InputfieldPhone.module on line 49

    Notice: Undefined index: example_extension in /home/p4a/domains/009.pw4all.org/public_html/site/modules/FieldtypePhone/InputfieldPhone.module on line 50

    This is pretty annoying ...

  9. Not sure if this is a bug or a feature.

    PW 2.5 Stable

    When i clone a field in advanced tab of field settings i got instantly moved to fieldlist after saving, which is kind of annoying as i wanted to clone the field several times :huh:

    Even when i use  "Admin Save Actions" Module i still get moved to fieldlist.

    Have a nice day

    Norbert

  10. At least for this simple question you gone far to far, maybe you misunderstand me.

    I just prefer the alternative php syntax as it feels far more like templating.

    (plus it looks a lot like other templating language)

    <? foreach ($file as $f) : ?>

    ... some stuff ...

    <? endforeach; ?>

    but to put this into a variable you need to use output buffer.

    Using the conventional syntax in templates feels entirely wrong, at least for me.

    I am no template engine freak that likes to remove php from templates just to add php tags like smarty does.

    Its really nice of you trying to explain the concepts of PW templating but i am pretty sure i already know whats going on in PW templates.

    The only thing i really want to know if it is possible to suppress the default call for the template file but keep the _init.php and _done.php call.

    It may be that it allows a way to an interesting templating alternative or maybe at least one that fits my personal needs best.

  11. @mr-fan and LostKobrakai

    I already know that approach but it need to wirte the content into variables either by using outputbuffer or by suing something like
     

    $sidebar .= "<ul class='nav'>";
      foreach($page->children as $child) {
        $sidebar .= "<li><a href='$child->url'>$child->title</a></li>";
      }
      $sidebar .= "</ul>";
    

    Which i don't like very much in templating as it just not fells like a template that way.(at least not to me !)
    Feels like mixing code and HTML instead of templating.

    Another option is that you use each templatefile as a dispatcher in its onw that has an additional file(same name) inside the markup folder very much like in the blog profile.

    Just having empty templatefiles in the templatefolder  and then following Somas approach whith a view folder would solve the problen but still i then have redundant files lying around on the server .

×
×
  • Create New...