Jump to content

matjazp

Members
 View Profile  See their activity

  • Posts

    687

  • Joined

  • Last visited

  • Days Won

    4

 Content Type 

Posts posted by matjazp

    Speed up modal page editing by adding a "Save + Close" button, plus easily add custom CSS and JS to the PW admin

    in Tutorials

    Posted

    Thx Robin! While the Save + Close button is there (as expected), the js part makes the edit links all open home page, eg. they all have the link /processwire/page/edit/?id=1&quick_edit=1 I fixed that with: 

    const $links = $('.PageListActionEdit a:not([data-autoclose])');
$links.each(function() {
    $link = $(this);
    $link.attr('data-autoclose', '#save-and-close').attr('href', $link.attr('href') + '&quick_edit=1');
});

    Just to mention that using uk-hidden class (as a "belt and suspender" approach) would only work in AdminThemeUIkit, leaving out newer (and older) admin themes.

    • Like 3

    Speed up modal page editing by adding a "Save + Close" button, plus easily add custom CSS and JS to the PW admin

    in Tutorials

    Posted

    Now that you explain it, I remember this behavior of modal.js. But, unfortunately, it doesn't work here, only the Save button is cloned. Looking at the modal.js line 417, $icontents.find(buttonSelector) only returns one button, not two as expected. It seems like the Save+Close button is added too late, after the modal has already cloned the Save button. While debugging, I added the button unconditionally and also removed the uk-hidden class, and then edited the page in a new tab with modal=1, and both buttons were there, as expected. But not in modal. I guess if I add the button directly to the ProcessPageEdit.module (or via hook), it would work. But it's working for you, so there must be something with my installation. It's a bit late here, so I'll continue testing tomorrow. 

    Problems with outdated modules in PHP8

    in General Support

    Posted

    Quote

    Do you have numbers for that? I can't really believe it and it sounds interesting ? 

    Nope, as I don't have ProCache, but based on what I've read and info from the forum, ProCache serves static files and there might be directives needed in .htaccess. I'm on IIS so it's not an option for me. AIOM+ leverages the template page cache built in core and uses a small php file to render those files. It's not perfect as modification of index.php is needed for best results (I have a feature request open). It also works if you modify some settings in site config.php, but it's not that effective.

    File Editor

    in Modules/Plugins

    Posted

    Thanks. You can comment this line.

    This module is still working, but need some love and could be simplified if required PHP version is bumped up. There is also a new version of file editor (with the same namespace) written by someone else (can't remember the name), I think it's actively maintained?

    Microsoft Teams meeting link into a URL field

    in General Support

    Posted

    It's not just quotation marks. In setAttributeValue() in InputfieldURL.module: 

    input (dirty) value:
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTY0NjAwYmUtOGIxNy11OGI5LWExMWMtNThlMmRmZGU5YTZl%40thread.v2/0?context={"Tid"%3a"36cabc20-3b53-4a0d-be6d-1fb3a94f9786"%2c"Oid"%3a"a508db2a-aff9-475e-9cf2-e51581a58320"}

sanitized value using sanititer()->url() method:
https://teams.microsoft.com/l/meetup-join/19:meeting_OTY0NjAwYmUtOGIxNy11OGI5LWExMWMtNThlMmRmZGU5YTZl@thread.v2/0?context={"Tid"%3a"36cabc20-3b53-4a0d-be6d-1fb3a94f9786"%2c"Oid"%3a"a508db2a-aff9-475e-9cf2-e51581a58320"}

rawurldecoded value:
https://teams.microsoft.com/l/meetup-join/19:meeting_OTY0NjAwYmUtOGIxNy11OGI5LWExMWMtNThlMmRmZGU5YTZl@thread.v2/0?context={"Tid":"36cabc20-3b53-4a0d-be6d-1fb3a94f9786","Oid":"a508db2a-aff9-475e-9cf2-e51581a58320"}

    As sanitized and rawurldecoded values differ, PW returns an error. I'm not sure how te deal with that, perhaps open an issue report? What could you do: a) use plain text field, b) instruct users to rawurldecode the url ? 

    • Like 1
×
×
  • Create New...