Jump to content

gebeer

Members
  • Content Count

    1,007
  • Joined

  • Last visited

  • Days Won

    23

Posts posted by gebeer


  1. HAving similar PHP warnings here

    PHP Warning: exif_read_data(1-transf-kosk4-min.gif): File not supported in /home/m1698/Sites/processwire/site/modules/FileValidatorImage/FileValidatorImage.module:398

    On this install I'm running images attached to a frontend form upload through the FileValidatorImage module which I installed first. This module uses PHP's exif_read_data function. And that doesn't seem to support gif. Couldn't find a list of supported file types in the PHP docs, though.

    I don't really worry too much about the warning itself. Only the mails I get from Tracydebugger get annoying after a while ;-)
    Just posting for reference.


  2. 1 hour ago, kongondo said:

    Other than that, it should go away if you add wire as a folder in the workspace.

    The wire folder is already in my workspace. Or do you mean I have to add it in VSCode in the workspace settings?

    After adding namespace ProcessWire to my template files, I got rid of these errors.

    • Like 1

  3. VSCode with intelephense, in the Problems tab I always get this error for __() language string function

    1937865171_2020-05-06-114443.png.21870f838d89176b204f7f654a304abd.png

    Anyone knows how to get rid of this?

    Just found out that it was a namespace problem. When namespace ProcessWire is not declared, intelephense will throw this error.


  4. 8 hours ago, FlorianA said:

    it seems to be a blocker for me forcing my users to fill in all (English) default language fields if the site's text is by 95% in German.

    If I understand this correctly, then your default language should be German. What was the reasoning behind switching languages in your case?

    If you want to write a PHP script, maybe my old script can give you some pointers. I wrote that years ago when I wasn't very experienced in working with the PW API. So there sure is much room for improvement.


  5. On 1/11/2020 at 1:16 AM, Peter said:

    I found your gist. Is this code compatible with PW 3.0?

    After looking through it, it should be compatible with 3.x. Most paths haven't changed since 2.x

    But in 3.x there are lots of new .htaccess rules. I wonder if anyone has already "translated" them to Nginx?


  6. Guess you need to initialise the map in your callback function to make it render.

    I'm using Openstreetmaps with this code

            {
                name: 'openstreetmaps',
                default: false,
                title: 'Open Street Maps',
                purposes: ['localityinfo'],
                cookies: [],
                callback: function (consent, app) {
                    if(consent && window.initMap !== undefined) {
                        setTimeout(function() {
                            window.initMap();
                        }, 1000);
                    }
                }
            }

    You see that window initMap() gets called here.

    You need to make sure that you can call your init function code for your Google map from the global namespace.

    I have a function initMap() that sets aup the map

    function initMap() {
        // console.log(window.L);
        if (window.L === undefined) return false;
        const mapcontainer = document.getElementById('map');
        const latlng = JSON.parse(mapcontainer.getAttribute('data-latlng'));
        const address = JSON.parse(mapcontainer.getAttribute('data-address'));
    
        mapcontainer.removeChild(mapcontainer.getElementsByTagName('img').item(0));
        var mymap = window.L.map('map').setView(latlng, 10);
    
        window.L.tileLayer('https://api.tiles.mapbox.com/v4/{id}/{z}/{x}/{y}.png?access_token={accessToken}', {
            attribution: 'Map data &copy; <a href="https://www.openstreetmap.org/">OpenStreetMap</a> contributors, <a href="https://creativecommons.org/licenses/by-sa/2.0/">CC-BY-SA</a>, Imagery © <a href="https://www.mapbox.com/">Mapbox</a>',
            maxZoom: 18,
            id: 'mapbox.streets',
            accessToken: 'xxx' // get from https://account.mapbox.com/access-tokens/
        }).addTo(mymap);
    
        var marker = window.L.marker(latlng).addTo(mymap);
        marker.bindPopup(address)/* .openPopup() */;
    }

    and attach it in my JS to the global namespace

    addEventListener('DOMContentLoaded', () => {
        if (document.getElementById('map')) {
            window.initMap = initMap;
        }
    });

     


  7. Hi, I'm facing a strange issue with priority values being output with colon (0,5) instead of period (0.5) which I guess is wrong.

    On some servers PW issues a warning to translate the locale setting:

    locale-warning.thumb.png.9e46dd3548f696721e0dba635ba39a21.png

    I have a site with a single language (German) and language support enabled to have the backend translated to German.
    So I translated the locale setting to de_DE.UTF-8

    63362521_localesetting-translate.png.a703c1d729e96d18aae94c2c745197b3.png

    But now sitemap items that are generated through a hook will output 0,5 (which is correct for German locale). Other pages in the sitemap output correctly like 0.5.

    I have automatic sitemap generation disabled because I update it manually whenever some data changes that comes from an external XML and is converted to virtual pages on runtime that do not get saved to the DB.

    My code for adding those virtual page entries to the sitemap

        public function updateXmlSitemap()
        {
            $config = $this->wire('modules')->getConfig('SeoMaestro');
            $items = $this->stellenangeboteXMLToPageArray(); // results in array of virtual pages
            $entries = array();
            foreach ($items as $item) {
                $entry = (new SitemapItem())
                    ->set('loc', $config['baseUrl'] . $item->url)
                    ->set('lastmod', date('c'), time())
                    ->set('priority', (float) 0.7) // casting explicitly to float doesn't help
                    ->set('changefreq', 'daily');
                $entries[] = $entry;
            }
            $this->addHookAfter('SeoMaestro::sitemapItems', function (HookEvent $event) use ($entries) {
                $event->return = array_merge($event->return, $entries); // add my entries to the sitemap
            });
            $manager = new SitemapManager($config);
            try {
                $sitemap = $manager->generate($this->wire('config')->paths->root . $config['sitemapPath']);
                if (!$sitemap) {
                    $this->wire('log')->save(strtolower($this->className), 'Could not generate sitemap');
                } else {
                    $this->wire('log')->save(strtolower($this->className), 'sitemap generated');
                }
            } catch (\Throwable $th) {
                $this->wire('log')->save($this->className, 'Error generating sitemap' . $th->getMessage());
            }
        }

    I don't know why the items added to the sitemap through my hook produce different output (0,5) from the items that are generated by the module (0.5).

    Could you make sure in the module code that the priority value is always being rendered as a float value, no matter what locale setting? That would be awesome.


  8. 11 hours ago, Jens Martsch - dotnetic said:

    The newest version of Klaro gives you the option if the CSS is included or you provide your own CSS. This is based on my PR.

    How do you actually build a version without css? I cloned the repo and added this to the scripts section of package.json and then run npm run makenocss

        "makenocss": "cross-env APP_ENV=production cross-env APP_VERSION=$(git tag --points-at HEAD) cross-env APP_COMMIT=$(git rev-parse HEAD) cross-env SEPARATE_CSS=true webpack --config webpack.config.js"

    This will build a klaro-no-css.js inside dist.

    Is there a simpler way passing the SEPARATE_CSS flag to the make script?


  9. 16 hours ago, Sergio said:

    Another question, do you know if there's a way to have a granular control on the scripts loaded by Google Tag Manager?

    With klaro consent manager you can gain control over the scripts loaded by GTM. See this issue. (I'm not affiliated with that project in any way, just using it on a couple of sites)

    It is implemented via custom callback functions for each app that is managed by the consent manager. @joshua Maybe you could go a similar route to make configuration more flexible and tweakable? And thanks for putting this together!

    And a suggestion for improvement: The type="optin" attribute is not a valid script attribute. So W3C Validator will not like it. You could use text/plain instead. That is not very semantic but could help to pass validator tests...

    • Like 3

  10. Hello all,

    wasn't sure where to put this, so it goes in General section.

    Ryan shows a hook that we can use to mirror files on demand from live server to development environment to be up to date with the files on the server without having to download complete site/assets/files folder.

    I just implemented this but had problems getting files to load from a site in development that is secured with user/password via htaccess.

    First I tried to use WireHttp setHeader method for basic authentication like this

        function mirrorFilesfromLiveServer(HookEvent $event)
        {
            $config = $event->wire('config');
            $file = $event->return;
    
            if ($event->method == 'url') {
                // convert url to disk path
                $file = $config->paths->root . substr($file, strlen($config->urls->root));
            }
    
            if (!file_exists($file)) {
                // download file from source if it doesn't exist here
                $src = 'http://mydomain.com/site/assets/files/';
                $url = str_replace($config->paths->files, $src, $file);
                $http = new WireHttp();
                // basic authentication
                $u = 'myuser';
                $pw = 'mypassword';
                $http->setHeader('Authorization: Basic', base64_encode("$u:$pw"));
                $http->download($url, $file);
            }
        }

    But, unfortunately this didn't work.

    So now I am using curl to do the download. My hook function now looks like this

        function mirrorFilesfromLiveServer(HookEvent $event)
        {
            $config = $event->wire('config');
            $file = $event->return;
    
            if ($event->method == 'url') {
                // convert url to disk path
                $file = $config->paths->root . substr($file, strlen($config->urls->root));
            }
    
            if (!file_exists($file)) {
                // download file from source if it doesn't exist here
                $src = 'http://mydomain.com/site/assets/files/';
                $fp = fopen($file, 'w+'); // init file pointer
                $url = str_replace($config->paths->files, $src, $file);
                $u = 'myuser';
                $pw = 'mypassword';
                $ch = curl_init();
                curl_setopt($ch, CURLOPT_URL, $url);
                curl_setopt($ch, CURLOPT_TIMEOUT, 50); // crazy high timeout just in case there are very large files
                curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
                curl_setopt($ch, CURLOPT_USERPWD, "$u:$pw"); // authentication
                curl_setopt($ch, CURLOPT_HTTPAUTH, CURLAUTH_BASIC); // authentication
                curl_setopt($ch, CURLOPT_FILE, $fp); // give curl the file pointer so that it can write to it
                curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
                $data = curl_exec($ch);
                curl_close($ch);
            }
        }

    Now I can load files and images from the htaccess protected development server 🙂

    If anyone knows how to get this to work with WireHttp, please let me know. Thank you.

    • Like 3

  11. I am having a different issue. With v1.2.0. I get this warning: 
    Warning
    array_key_exists() expects parameter 2 to be array, null given
    File: .../EmailObfuscation/EmailObfuscation.module:352

    352 if(!is_array($options) && !array_key_exists('pageStack', $options)) {
              return false;
        }

    If $options passes the first test, it is not an array. The second test checks for array_key_exists in a non-array. Hence the warning.

    The error is being triggered when $options is null.

    As a temp workaround I amended the if statement to read

    if(is_array($options) && !array_key_exists('pageStack', $options)) {
    	return false;
    }

    Not sure though if this is correct. Maybe you wanted to return false when $options is not an array, too?

     


  12. Instead of having extra fields and saving extra data, you could make use of the $page->references() method, I mentioned above. You could utilize this method inside a ProcessPageEdit::buildFormContent hook and add a Markup field that holds the titles (and even links) of the referenced pages. Just an idea.


  13. 54 minutes ago, bernhard said:

    t would be very easy to create a RockDatetime field based on the core Datetime field but waking up having a RockDatetime object instead of a timestamp. Maybe you want to experiment with that and create a PR?

    I thought I'd just use your new inputfield type 🙂 Won't have time for implementing this before April. If I see room for improvement on your module, I am happy to make a PR. Thanks again!


  14. Since modern browsers support flex and grid and most CSS3 specs, I also moved from using frameworks like BS to setting up things manually with my own, reusable scss partials and the JS libs that I need for a project. Also trying to move more and more to vanilla JS and kick jQuery. This way I get more streamlined assets. If I need to support old browsers (mainly IE11), I write some specific extra CSS to cater for them if need be.

    • Like 1
    • Thanks 1

  15. Did you have a look at $page->references() method? This gives you all pages that reference this page. In the page edit screen you can see those in the "Settings" tab under "What pages link to this page". With this method available in your template php maybe you don't even need your hook.

    And there is @Robin S's module ConnectPageFields that handles those cases.

    You might also want to take a look at @Martijn Geerts' FieldPageSync Module that also does something similar.


  16. 1 hour ago, bernhard said:

    I've put a lot of effort into developing the RockDatetime module. It is already available on Github and has lots of examples and docs in the readme: https://github.com/BernhardBaumrock/RockDatetime

    Thank you so much for all your efforts in putting this together! I'll be using this soon to replace date range logic in 2 live projects that deal with events.

    • Like 1

  17. To find all pages where the repeater field word_object has a field this_word with value apple you can use subfield selectors

    $pageArray = $pages->find("word_object.this_word=apple")

    This will return a PageArray with all those pages.

    Now to get all the word_object repeater fields from this PageArray, you can use the  WireArray explode method

    $repeatersArray = $pageArray->explode("word_object")

    This will return an array with all the repeater fields. You can now foreach through this array and output whatever you need.

    You could also chain this to a single operation

    $repeatersArray = $pages->find("word_object.this_word=apple")->explode("word_object")

     

    • Like 4

  18. 5 hours ago, teppo said:

    Overall there are very few cases where the title attribute should be used

    Thanks for that link! An agency I'm sometimes working for wants to have title attributes on all links, no matter what. They say it's for SEO. Sorry for getting offtopic.

    6 hours ago, bernhard said:
    • Show time input?
    • Show end input?

    I'd call them something like 'Input time' and 'Input end' because that is actually what you can do after clicking on them and is also like an instruction of what to do or what can be done.

     

    10 minutes ago, adrian said:

    I would recommend a full read of the recurme support thread

    That sure is a long read but well worth it.

    • Like 2

  19. 13 minutes ago, bernhard said:

    I've absolutely no experience in handling different timezones, so I'd be happy to get a quickstart or a good read for that topic

    This is really only necessary if you are dealing with user input of users from different time zones.
    You'd also have to know the timezone of the logged in user. For projects where I needed that, I had a field in the user template to save the timezone and did calculations based on that. It is hard to foresee how other people implement it and therefore in the fieldtype you would not know how to get the user timezone. Maybe in a hookable method that by default returns the local server timezone. Then people could hook into it and provide the user timezone only if it differs from the server timezone.
    The common base for calculation between different timezones is the unix timestamp. So the resulting timestamp for 01.01.2020 20:00 will be different, depending on what the timezone is. The DateTime class has the  setTimezone method which helps for conversion of DateTime objects between different timezones. Here's a quick read on the basics.

    • Like 1
    • Thanks 1

  20. That looks great so far, will be a really useful fieldtype!

    55 minutes ago, bernhard said:

    I think option 1 is cleaner and easier to use and develop, so I'll continue with this option

    I also prefer option 1. Much cleaner than having to involve yet another module.

    55 minutes ago, bernhard said:

    I'm of course already thinking of how this could be extended to support recurring events (date ranges) in the future... I'm not sure how to do that yet, but I think it could make a lot of sense to build this feature into this module

    This would be so awesome. Especially since the Recurme module seems to have passed away silently. Maybe you can get some inspiration from there on how to handle recurring stuff. I wouldn't include the whole render a calendar stuff. People who need it can always use some existing framework for that.

    55 minutes ago, bernhard said:

    I'm not sure if/how/when I can realease this module. I'm building it now for one project and want to see how it works first.

    Would be great if you could share the code pre-release on GH so people who are interested could collaborate.

    55 minutes ago, bernhard said:

    I wanted to share the status with you to get some feedback and maybe also get your experiences in working with dates and times or maybe working with recurring events

    I did some date manipulation in the past because I'm involved with quite a few sites that needed it. What I found most challenging is the timezone calculations. Also did some recurring stuff as far as I remember. What I found very helpful at the time for those tasks are the PHP DateTime, DatePeriod and Dateinterval classes. Haven't delved into it for some 3 years but remember that it actually was fun. I guess today I would use the recurr library.

    EDIT: As for the recurring events, I'd probably make this optional in the field settings and only present the inputs if needed.

    • Like 4

  21. 12 hours ago, bernhard said:

    I was tired of adding 6 different fields to an event-template just for storing the time range of the event...

    Great. Can't wait to see it (if you plan to release this) 🙂 Any plans for recurring events?

    • Like 1
×
×
  • Create New...