46 replies to this topic

[Soma]

Ryan, yeah codemagic has some hard reference that makes it impossible to put it outside :/. Thought there's not much translation that we could add.

I don't know if there might be other third party plugin that does the same.

Regarding the "bramus_cssextras", I would like to have that being able to integrate it without touching the core every update, and I use it in many installations meanwhile.

- Either add it to the core like codemagic plugin.
- or adding my version here from this test version, by adding another config textarea "third plugins". ( I added the module and the js code)

Let me know what you need.

[ryan]

If it doesn't add any overhead, or interfere with anything existing, I'm cool to add it in the core as one of those things people can choose to optionally turn on. I think if I could see a diff or GitHub pull request that shows me what's different, that's all I'd need.

I still don't really understand the Bramus CSS extras plugin or know how/why/when to use it, otherwise it would already be added. For instance, their "what is bramus css extras?" screen implies that one can't float images without it (which obviously isn't true), among other things. I only get lost in their demo, which seems to cross some uncomfortable boundaries of turning TinyMCE into a styling tool. So I've always been a bit perplexed by the value of this plugin. However, I do understand that it is apparently very useful, as many don't want TinyMCE without it. So if it makes life easier to have it as an optional component in the core, lets add it.

[Soma]

OK, coming back to this

Thanks Ryan, I'll pull request the tinymce module and js changes I've done to add a third party config textfield to add plugins from outside the core. Hope you'll find the time to pull it in -

bramus_cssextras, mainly it's for fixing the tinymce internal style select, which doesn't work well with nested elements and is cumbersome to deal with. This plugin is context sensitive, as it only enables the style dropdown if you put cursor in an element that has a class specified. Like if you specify p.lead{} in your content.css, it will only be selectable if you select a paragraph. It also provides an solution to an issue where you couldn't add a class to the <ul> element in tinymce, because you can't select it. So if you click inside a ul list, the <li> element is usually selected and classes get appended to the <li> element and not the parent <ul>. Bramus solves this.

WEll I don't know why I'm explaing this the x-time here on the forums The website explains it all and the demo works well to demostrate: http://www.bram.us/d...amus_cssextras/ ... The top row "style" is the regular style select. The disabled ".class" and "#id" menu select on the 3rd row is the one from bramus_cssextras. Click inside the list in the text and see the menu gets enabled and only shows classes that can be added to the current selected element. Pretty cool compared to tinymce default style if you ask me.

[ryan]

Thanks Soma, this is a great explanation and it finally makes sense. I look forward to adding this into the core.

[JeffS]

Question - Is there a particular reason the TinyMCE is back at 3.4.7 in the current release and not current (3.5.1.1)?

I updated the module to use 3.5.1.1 it on my local install and added codemagic and every thing appears to be fine from my experience over the last couple of days. We build HTML5 sites and I was looking for better support in the editor, thus the update.

[ryan]

I updated the version to the latest a few months ago. I guess they are doing a good job of making regular updates to TinyMCE. I don't think we can update every time they release a new version just because everything has to inevitably be tested and re-tested every time we upgrade something like that. But I will plan to pull in the latest version when I bring in Soma's Bramus updates into the core (next week or two).

[JeffS]

@ryan - Totally understand. Just thought there might be an issue that needed to be worked on.